From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-fsdevel-owner@vger.kernel.org>
Received: from userp1040.oracle.com ([156.151.31.81]:19528 "EHLO
        userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1753195AbdBGIgK (ORCPT
        <rfc822;linux-fsdevel@vger.kernel.org>);
        Tue, 7 Feb 2017 03:36:10 -0500
Date: Tue, 7 Feb 2017 11:35:43 +0300
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Mike Marshall <hubcap@omnibond.com>
Cc: viro@zeniv.linux.org.uk, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] orangefs: Dan Carpenter influenced cleanups...
Message-ID: <20170207083543.GF11103@mwanda>
References: <20170206162120.16717-1-hubcap@omnibond.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20170206162120.16717-1-hubcap@omnibond.com>
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

On Mon, Feb 06, 2017 at 11:21:20AM -0500, Mike Marshall wrote:
> @@ -996,7 +996,7 @@ int orangefs_debugfs_new_client_string(void __user *arg)
>  		if (orangefs_prepare_debugfs_help_string(0)) {
>  			gossip_err("%s: no debug help string \n",
>  				   __func__);
> -			return -EIO;
> +			return -EFAULT;
>  		}

The rest looks nice but -EFAULT isn't right here.  It should propogate
the return from orangefs_prepare_debugfs_help_string().

		ret = orangefs_prepare_debugfs_help_string(0);
		if (ret) {
			gossip_err("%s: no debug help string \n",
				   __func__);
			return ret;
		}

regards,
dan carpenter