From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Gunthorpe Subject: Re: [RFC v3 02/11] IB/hfi-vnic: Virtual Network Interface Controller (VNIC) interface Date: Tue, 7 Feb 2017 15:19:25 -0700 Message-ID: <20170207221925.GA30579@obsidianresearch.com> References: <1486498990-76562-1-git-send-email-niranjana.vishwanathapura@intel.com> <1486498990-76562-3-git-send-email-niranjana.vishwanathapura@intel.com> <20170207211901.GB28922@obsidianresearch.com> <20170207220628.GB76652@knc-06.sc.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20170207220628.GB76652@knc-06.sc.intel.com> Sender: netdev-owner@vger.kernel.org To: "Vishwanathapura, Niranjana" Cc: dledford@redhat.com, linux-rdma@vger.kernel.org, netdev@vger.kernel.org, dennis.dalessandro@intel.com, ira.weiny@intel.com, Liran Liss List-Id: linux-rdma@vger.kernel.org On Tue, Feb 07, 2017 at 02:06:30PM -0800, Vishwanathapura, Niranjana wrote: > >> IB_DEVICE_RAW_SCATTER_FCS = (1ULL << 34), > >>+ IB_DEVICE_RDMA_NETDEV_HFI_VNIC = (1ULL << 35), > > > >What is this called HFI_VNIC anyhow? Shouldn't this be OPA_VNIC? There > >is nothing really HFI specific, right? > > Agreed, OPA_VNIC is more appropriate here. Will change it. And probably lots of other places too.. :) > >And this should be rn->dev_priv ? > > Yah, both will result in same behavior. But yah, what you are suggesting > will remove any confusion. Will change in next PATCH series. Only because the struct has no members, as soon as someone adds something it would go booom. Jason