From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932504AbdBGWpu (ORCPT ); Tue, 7 Feb 2017 17:45:50 -0500 Received: from bombadil.infradead.org ([65.50.211.133]:53005 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752108AbdBGWpn (ORCPT ); Tue, 7 Feb 2017 17:45:43 -0500 Date: Tue, 7 Feb 2017 14:44:53 -0800 From: Christoph Hellwig To: "Nicholas A. Bellinger" Cc: target-devel , linux-scsi , lkml , Benjamin ESTRABAUD Subject: Re: [PATCH 1/5] target: Don't BUG_ON during NodeACL dynamic -> explicit conversion Message-ID: <20170207224453.GB5274@infradead.org> References: <1486473470-15837-1-git-send-email-nab@linux-iscsi.org> <1486473470-15837-2-git-send-email-nab@linux-iscsi.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1486473470-15837-2-git-send-email-nab@linux-iscsi.org> User-Agent: Mutt/1.7.1 (2016-10-04) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Feb 07, 2017 at 01:17:46PM +0000, Nicholas A. Bellinger wrote: > + if (orig->se_lun_acl != NULL) { > + pr_warn_ratelimited("Detected existing explicit" > + " se_lun_acl->se_lun_group reference for %s" > + " mapped_lun: %llu, ignoring\n", > + nacl->initiatorname, mapped_lun); The ignoring in the message confused the heck out of me first. But it seems that's just an incorrect leftover from the original message, as the changelog also says fail instead. With that fixed up (and maybe the whole message in a single string literal on a single line): Reviewed-by: Christoph Hellwig