From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Date: Tue, 07 Feb 2017 23:46:01 +0000 Subject: [patch] drm/atomic: fix an error code in mode_fixup() Message-Id: <20170207234601.GA23981@mwanda> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Daniel Vetter , Thierry Reding Cc: kernel-janitors@vger.kernel.org, dri-devel@lists.freedesktop.org Having "ret" be a bool type works for everything except ret = funcs->atomic_check(). The other functions all return zero on error but ->atomic_check() returns negative error codes. We want to propagate the error code but instead we return 1. I found this bug with static analysis and I don't know if it affects run time. Fixes: 4cd4df8080a3 ("drm/atomic: Add ->atomic_check() to encoder helpers") Signed-off-by: Dan Carpenter diff --git a/drivers/gpu/drm/drm_atomic_helper.c b/drivers/gpu/drm/drm_atomic_helper.c index 9a08445a7a7a..01d936b7be43 100644 --- a/drivers/gpu/drm/drm_atomic_helper.c +++ b/drivers/gpu/drm/drm_atomic_helper.c @@ -369,7 +369,7 @@ mode_fixup(struct drm_atomic_state *state) struct drm_connector *connector; struct drm_connector_state *conn_state; int i; - bool ret; + int ret; for_each_crtc_in_state(state, crtc, crtc_state, i) { if (!crtc_state->mode_changed && From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Subject: [patch] drm/atomic: fix an error code in mode_fixup() Date: Wed, 8 Feb 2017 02:46:01 +0300 Message-ID: <20170207234601.GA23981@mwanda> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from userp1040.oracle.com (userp1040.oracle.com [156.151.31.81]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0D29389E9E for ; Tue, 7 Feb 2017 23:46:24 +0000 (UTC) Content-Disposition: inline List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Daniel Vetter , Thierry Reding Cc: kernel-janitors@vger.kernel.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org SGF2aW5nICJyZXQiIGJlIGEgYm9vbCB0eXBlIHdvcmtzIGZvciBldmVyeXRoaW5nIGV4Y2VwdApy ZXQgPSBmdW5jcy0+YXRvbWljX2NoZWNrKCkuICBUaGUgb3RoZXIgZnVuY3Rpb25zIGFsbCByZXR1 cm4gemVybyBvbgplcnJvciBidXQgLT5hdG9taWNfY2hlY2soKSByZXR1cm5zIG5lZ2F0aXZlIGVy cm9yIGNvZGVzLiAgV2Ugd2FudCB0bwpwcm9wYWdhdGUgdGhlIGVycm9yIGNvZGUgYnV0IGluc3Rl YWQgd2UgcmV0dXJuIDEuCgpJIGZvdW5kIHRoaXMgYnVnIHdpdGggc3RhdGljIGFuYWx5c2lzIGFu ZCBJIGRvbid0IGtub3cgaWYgaXQgYWZmZWN0cwpydW4gdGltZS4KCkZpeGVzOiA0Y2Q0ZGY4MDgw YTMgKCJkcm0vYXRvbWljOiBBZGQgLT5hdG9taWNfY2hlY2soKSB0byBlbmNvZGVyIGhlbHBlcnMi KQpTaWduZWQtb2ZmLWJ5OiBEYW4gQ2FycGVudGVyIDxkYW4uY2FycGVudGVyQG9yYWNsZS5jb20+ CgpkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2RybV9hdG9taWNfaGVscGVyLmMgYi9kcml2 ZXJzL2dwdS9kcm0vZHJtX2F0b21pY19oZWxwZXIuYwppbmRleCA5YTA4NDQ1YTdhN2EuLjAxZDkz NmI3YmU0MyAxMDA2NDQKLS0tIGEvZHJpdmVycy9ncHUvZHJtL2RybV9hdG9taWNfaGVscGVyLmMK KysrIGIvZHJpdmVycy9ncHUvZHJtL2RybV9hdG9taWNfaGVscGVyLmMKQEAgLTM2OSw3ICszNjks NyBAQCBtb2RlX2ZpeHVwKHN0cnVjdCBkcm1fYXRvbWljX3N0YXRlICpzdGF0ZSkKIAlzdHJ1Y3Qg ZHJtX2Nvbm5lY3RvciAqY29ubmVjdG9yOwogCXN0cnVjdCBkcm1fY29ubmVjdG9yX3N0YXRlICpj b25uX3N0YXRlOwogCWludCBpOwotCWJvb2wgcmV0OworCWludCByZXQ7CiAKIAlmb3JfZWFjaF9j cnRjX2luX3N0YXRlKHN0YXRlLCBjcnRjLCBjcnRjX3N0YXRlLCBpKSB7CiAJCWlmICghY3J0Y19z dGF0ZS0+bW9kZV9jaGFuZ2VkICYmCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVk ZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZv L2RyaS1kZXZlbAo=