All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: herbert@gondor.apana.org.au
Cc: tgraf@suug.ch, netdev@vger.kernel.org
Subject: Re: [PATCH 0/3] rhashtable: Handle table allocation failure during insertion
Date: Wed, 08 Feb 2017 13:26:42 -0500 (EST)	[thread overview]
Message-ID: <20170208.132642.68242478649592606.davem@davemloft.net> (raw)
In-Reply-To: <20170207123827.GA14678@gondor.apana.org.au>

From: Herbert Xu <herbert@gondor.apana.org.au>
Date: Tue, 7 Feb 2017 20:38:27 +0800

> This series tackles the problem of table allocation failures during
> insertion.  The issue is that we cannot vmalloc during insertion.
> This series deals with this by introducing nested tables.
> 
> The first two patches removes manual hash table walks which cannot
> work on a nested table.
> 
> The final patch introduces nested tables.
> 
> I've tested this with test_rhashtable and it appears to work.

rhashtable is indeed getting quite complex, but I understand your
motivation for doing this work.

I also agree that only true OOM situations should cause insertion
failures.

Given the delicate nature of change rhashtable this way, I'm going
to let these changes sit for a couple days before applying them.

Thanks Herbert.

  parent reply	other threads:[~2017-02-08 18:28 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-07 12:38 [PATCH 0/3] rhashtable: Handle table allocation failure during insertion Herbert Xu
2017-02-07 12:39 ` [PATCH 1/3] gfs2: Use rhashtable walk interface in glock_hash_walk Herbert Xu
2017-02-07 12:39 ` [PATCH 2/3] tipc: Fix tipc_sk_reinit race conditions Herbert Xu
2017-02-10 10:53   ` Ying Xue
2017-02-07 12:39 ` [PATCH 3/3] rhashtable: Add nested tables Herbert Xu
2017-02-07 13:17   ` Florian Westphal
2017-02-07 13:29     ` Herbert Xu
2017-02-07 18:02       ` Florian Westphal
2017-02-08  1:09         ` Herbert Xu
2017-02-09  2:12   ` [lkp-robot] [rhashtable] 60be2ebf32: INFO:suspicious_RCU_usage kernel test robot
2017-02-09  2:12     ` kernel test robot
2017-02-08 18:26 ` David Miller [this message]
2017-02-11 11:22   ` [PATCH 0/3] rhashtable: Handle table allocation failure during insertion Herbert Xu
2017-02-11 11:24 ` [v2 PATCH " Herbert Xu
2017-02-11 11:26   ` [v2 PATCH 1/3] gfs2: Use rhashtable walk interface in glock_hash_walk Herbert Xu
2017-02-11 11:26   ` [v2 PATCH 2/3] tipc: Fix tipc_sk_reinit race conditions Herbert Xu
2017-02-11 11:26   ` [v2 PATCH 3/3] rhashtable: Add nested tables Herbert Xu
2017-02-14  3:18   ` [v2 PATCH 0/3] rhashtable: Handle table allocation failure during insertion David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170208.132642.68242478649592606.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=herbert@gondor.apana.org.au \
    --cc=netdev@vger.kernel.org \
    --cc=tgraf@suug.ch \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.