From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [PATCH v3 0/7] Pad retentions support for Exynos5433 Date: Wed, 8 Feb 2017 11:46:15 +0000 Message-ID: <20170208114615.c4wszjmnuackgzvx@dell> References: <1485779908-32147-1-git-send-email-m.szyprowski@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <1485779908-32147-1-git-send-email-m.szyprowski@samsung.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Marek Szyprowski Cc: linux-samsung-soc@vger.kernel.org, Bartlomiej Zolnierkiewicz , Linus Walleij , linux-kernel@vger.kernel.org, Krzysztof Kozlowski , Tomasz Figa , linux-gpio@vger.kernel.org, Sylwester Nawrocki , linux-arm-kernel@lists.infradead.org List-Id: linux-gpio@vger.kernel.org T24gTW9uLCAzMCBKYW4gMjAxNywgTWFyZWsgU3p5cHJvd3NraSB3cm90ZToKCj4gSGVsbG8sCj4g Cj4gVGhpcyBwYXRjaHNldCBpcyBhIGZpcnN0IHN0ZXAgdG8gYWRkIHN1cHBvcnQgZm9yIGFsbCBw b3dlciBkb21haW5zIG9uCj4gRXh5bm9zNTQzMyBTb0NzLiBUaGlzIHBhdGNoc2V0IGNvbnRhaW5z IHBhdGNoZXMgZm9yIEV4eW5vcyBwaW4gY29udHJvbAo+IGRyaXZlciBhbmQgRXh5bm9zIExQQVNT IE1GRCBkcml2ZXIsIHdoaWNoIGFyZSBuZWVkZWQgdG8gbWFrZSB0aGUKPiBwbGF0Zm9ybSByZWFk eSBmb3IgYWRkaW5nIHBvd2VyIGRvbWFpbnMgc3VwcG9ydC4KPiAKPiBQYXRjaGVzIGluIHRoaXMg cGF0Y2hzZXQgZGVwZW5kcyBvbiBlYWNoIG90aGVyLiBUaGV5IGFyZSBvcmRlciBpbiBzdWNoIGEK PiB3YXkgdG8gbWFrZSB0aGUgY2hhbmdlcyBiaXNlY3RhYmxlLgo+IAo+IFBhdGNoICMyIGhhcyBj b21waWxlIGRlcGVuZGVuY3kgb24gIzEuCj4gUGF0Y2ggIzMgaGFzIHJ1bnRpbWUgZGVwZW5kZW5j eSBvbiBjb21taXQgZmE1OWFhNzA5MDdiMiAoInNvYzogc2Ftc3VuZzoKPiAJcG11OiBBZGQgZHVt bXkgc3VwcG9ydCBmb3IgRXh5bm9zNTQzMyBTb0MiLAo+IAlmb3ItdjQuMTEvZHJpdmVycy1zb2Mt ZXh5bm9zLXBtdS10aGUtam95LW5ldmVyLWVuZHMgYnJhbmNoKS4KPiBQYXRjaCAjNCBoYXMgcnVu dGltZSBkZXBlbmRlbmN5IG9uICMzLgo+IFBhdGNoICM1IGhhcyBydW50aW1lIGRlcGVuZGVuY3kg b24gY29tbWl0IDc1NDcxNjJhYzM1MTQgKCJhcm02NDogZHRzOgo+IAlleHlub3M6IEFkZCBjbG9j a3MgdG8gRXh5bm9zNTQzMyBMUEFTUyBtb2R1bGUsIG5leHQvZHQ2NCBicmFuY2gpLgo+IAo+IFRo aXMgcGF0Y2hzZXQgYWxzbyBkaXJlY3RseSBkZXBlbmRzIG9uIHRoZSAiTW92ZSBwYWQgcmV0ZW50 aW9uIGNvbnRyb2wgdG8KPiBFeHlub3MgcGluIGNvbnRyb2xsZXIgZHJpdmVyIiBwYXRjaHNldDoK PiBodHRwczovL3d3dy5zcGluaWNzLm5ldC9saXN0cy9hcm0ta2VybmVsL21zZzU1NjA3NC5odG1s Cj4gCj4gUGF0Y2hlcyBoYXZlIGJlZW4gZ2VuZXJhdGVkIG9uIHRvcCBvZiBsaW51eC1uZXh0IGZy b20gMzB0aCBKYW51YXJ5IDIwMTcKPiB3aXRoIHRoZSBhYm92ZSBtZW50aW9uZWQgcGF0Y2hzZXQg YXBwbGllZC4KPiAKPiBUaGlzIGlzIGEgcGFydCBvZiBhIGxhcmdlciB0YXNrLCB3aGljaCBnb2Fs IGlzIHRvIGFkZCBzdXBwb3J0IGZvciBwb3dlcgo+IGRvbWFpbnMgb24gRXh5bm9zNTQzMyBTb0Nz IC8gVE0yIGJvYXJkcy4gRmlyc3QgdmVyc2lvbiBvZiB0aGUgYWxsIHBhdGNoZXMKPiBuZWVkZWQg dG8gZ2V0IGl0IHdvcmtpbmcgaGF2ZSBiZWVuIHB1c2hlZCB0byB0aGUgZm9sbG93aW5nIGdpdCBy ZXBvOgo+IGh0dHBzOi8vZ2l0LmxpbmFyby5vcmcvcGVvcGxlL21hcmVrLnN6eXByb3dza2kvbGlu dXgtc3Jwb2wuZ2l0IHY0LjEwLW5leHQtdG0yLXBkCj4gCj4gQmVzdCByZWdhcmRzCj4gTWFyZWsg U3p5cHJvd3NraQo+IFNhbXN1bmcgUiZEIEluc3RpdHV0ZSBQb2xhbmQKCkxvb2tzIGxpa2UgSSBy ZXZpZXdlZCB2Mi4KCklmIHRoZSBwYXRjaGVzIGhhdmVuJ3QgY2hhbmdlZCB0aGF0IG11Y2gsIHBs ZWFzZSBhcHBseSBteSBBY2tzIHRvIHRoaXMKc2V0IGluc3RlYWQuICBBbnl0aGluZyB0aGF0IGhh cyBjaGFuZ2VkLCBwbGVhc2UgbGVhdmUgdGhlbSBvZmYgYW5kCnJlcG9zdC4KCj4gQ2hhbmdlbG9n Ogo+IHYzOgo+IC0gbW92ZWQgYWRkaW5nIG5ldyBQTVUgcmVnaXN0ZXIgZGVmaW5lcyB0byBzZXBh cmF0ZSBwYXRjaCAocmVxdWVzdGVkIGJ5Cj4gICBLcnp5c3p0b2YgS296bG93c2tpKQo+IC0gcmVi YXNlZCBvbnRvIExpbnV4IG5leHQtMjAxNzAxMzAgKHJlbW92ZWQgInNvYzogc2Ftc3VuZzogcG11 OiBBZGQgZHVtbXkKPiAgIHN1cHBvcnQgZm9yIEV4eW5vczU0MzMgU29DIiBhbmQgImFybTY0OiBk dHM6IGV4eW5vczogQWRkIGNsb2NrcyB0bwo+ICAgRXh5bm9zNTQzMyBMUEFTUyBtb2R1bGUiIHBh dGNoZXMsIHdoaWNoIGFyZSBhbHJlYWR5IG1lcmdlZCkKPiAKPiB2MjoKPiAtIGZpeGVkIGlzc3Vl cyBwb2ludGVkIGJ5IEtyenlzenRvZiBLb3psb3dza2k6Cj4gICAxLiBhZGRlZCBtb3JlIGNoZWNr cyB0byBFeHlub3MgUE1VIGRyaXZlciBmb3IgTlVMTCBkcnZkYXRhCj4gICAyLiByZXVzZWQgRVhZ Tk9TX1dBS0VVUF9GUk9NX0xPV1BXUiBpbiByZXRlbnRpb24gZGF0YSBmb3IgRXh5bm9zNTQzMwo+ ICAgMy4gY29udmVydGVkIGxwYXNzIGRyaXZlciB0byBkZXZtX2Nsa19nZXQKPiAgIDQuIGFkZGVk IG1pc3NpbmcgLT5yZW1vdmUgY2FsbGJhY2sgdG8gbHBhc3MgZHJpdmVyCj4gCj4gdjE6IGh0dHBz Oi8vbGttbC5vcmcvbGttbC8yMDE3LzEvMjUvMjE0Cj4gLSBpbml0aWFsIHZlcnNpb24KPiAKPiAK PiBQYXRjaCBzdW1tYXJ5Ogo+IAo+IE1hcmVrIFN6eXByb3dza2kgKDcpOgo+ICAgc29jOiBzbWFz dW5nOiBwbXU6IEFkZCByZWdpc3RlciBkZWZpbmVzIGZvciBwYWQgcmV0ZW50aW9uIGNvbnRyb2wK PiAgIHBpbmN0cmw6IHNhbXN1bmc6IEVuc3VyZSB0aGF0IHBhZCByZXRlbnRpb24gaXMgZGlzYWJs ZWQgb24gZHJpdmVyIGluaXQKPiAgIHBpbmN0cmw6IHNhbXN1bmc6IEFkZCBzdXBwb3J0IGZvciBw YWQgcmV0ZW50aW9uIGNvbnRyb2wgZm9yIEV4eW5vczU0MzMKPiAgICAgU29Dcwo+ICAgbWZkOiBl eHlub3MtbHBhc3M6IFJlbW92ZSBwYWQgcmV0ZW50aW9uIGNvbnRyb2wKPiAgIG1mZDogZXh5bm9z LWxwYXNzOiBBZGQgc3VwcG9ydCBmb3IgY2xvY2tzCj4gICBtZmQ6IGV4eW5vcy1scGFzczogQWRk IG1pc3NpbmcgcmVtb3ZlKCkgZnVuY3Rpb24KPiAgIG1mZDogZXh5bm9zLWxwYXNzOiBBZGQgcnVu dGltZSBQTSBzdXBwb3J0Cj4gCj4gIC4uLi9iaW5kaW5ncy9tZmQvc2Ftc3VuZyxleHlub3M1NDMz LWxwYXNzLnR4dCAgICAgIHwgIDggKystCj4gIGRyaXZlcnMvbWZkL2V4eW5vcy1scGFzcy5jICAg ICAgICAgICAgICAgICAgICAgICAgIHwgNDggKysrKysrKysrKy0tLS0tLS0KPiAgZHJpdmVycy9w aW5jdHJsL3NhbXN1bmcvcGluY3RybC1leHlub3MuYyAgICAgICAgICAgfCA2MyArKysrKysrKysr KysrKysrKysrKysrCj4gIGluY2x1ZGUvbGludXgvbWZkL3N5c2Nvbi9leHlub3M1LXBtdS5oICAg ICAgICAgICAgIHwgIDMgLS0KPiAgaW5jbHVkZS9saW51eC9zb2Mvc2Ftc3VuZy9leHlub3MtcmVn cy1wbXUuaCAgICAgICAgfCAxNiArKysrKysKPiAgNSBmaWxlcyBjaGFuZ2VkLCAxMTUgaW5zZXJ0 aW9ucygrKSwgMjMgZGVsZXRpb25zKC0pCj4gCgotLSAKTGVlIEpvbmVzCkxpbmFybyBTVE1pY3Jv ZWxlY3Ryb25pY3MgTGFuZGluZyBUZWFtIExlYWQKTGluYXJvLm9yZyDilIIgT3BlbiBzb3VyY2Ug c29mdHdhcmUgZm9yIEFSTSBTb0NzCkZvbGxvdyBMaW5hcm86IEZhY2Vib29rIHwgVHdpdHRlciB8 IEJsb2cKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxp bnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFk ZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4 LWFybS1rZXJuZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753684AbdBHLxY (ORCPT ); Wed, 8 Feb 2017 06:53:24 -0500 Received: from mail-wm0-f47.google.com ([74.125.82.47]:35742 "EHLO mail-wm0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751714AbdBHLxW (ORCPT ); Wed, 8 Feb 2017 06:53:22 -0500 Date: Wed, 8 Feb 2017 11:46:15 +0000 From: Lee Jones To: Marek Szyprowski Cc: linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Sylwester Nawrocki , Krzysztof Kozlowski , Linus Walleij , Tomasz Figa , Bartlomiej Zolnierkiewicz Subject: Re: [PATCH v3 0/7] Pad retentions support for Exynos5433 Message-ID: <20170208114615.c4wszjmnuackgzvx@dell> References: <1485779908-32147-1-git-send-email-m.szyprowski@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1485779908-32147-1-git-send-email-m.szyprowski@samsung.com> User-Agent: Mutt/1.6.2-neo (2016-08-21) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 30 Jan 2017, Marek Szyprowski wrote: > Hello, > > This patchset is a first step to add support for all power domains on > Exynos5433 SoCs. This patchset contains patches for Exynos pin control > driver and Exynos LPASS MFD driver, which are needed to make the > platform ready for adding power domains support. > > Patches in this patchset depends on each other. They are order in such a > way to make the changes bisectable. > > Patch #2 has compile dependency on #1. > Patch #3 has runtime dependency on commit fa59aa70907b2 ("soc: samsung: > pmu: Add dummy support for Exynos5433 SoC", > for-v4.11/drivers-soc-exynos-pmu-the-joy-never-ends branch). > Patch #4 has runtime dependency on #3. > Patch #5 has runtime dependency on commit 7547162ac3514 ("arm64: dts: > exynos: Add clocks to Exynos5433 LPASS module, next/dt64 branch). > > This patchset also directly depends on the "Move pad retention control to > Exynos pin controller driver" patchset: > https://www.spinics.net/lists/arm-kernel/msg556074.html > > Patches have been generated on top of linux-next from 30th January 2017 > with the above mentioned patchset applied. > > This is a part of a larger task, which goal is to add support for power > domains on Exynos5433 SoCs / TM2 boards. First version of the all patches > needed to get it working have been pushed to the following git repo: > https://git.linaro.org/people/marek.szyprowski/linux-srpol.git v4.10-next-tm2-pd > > Best regards > Marek Szyprowski > Samsung R&D Institute Poland Looks like I reviewed v2. If the patches haven't changed that much, please apply my Acks to this set instead. Anything that has changed, please leave them off and repost. > Changelog: > v3: > - moved adding new PMU register defines to separate patch (requested by > Krzysztof Kozlowski) > - rebased onto Linux next-20170130 (removed "soc: samsung: pmu: Add dummy > support for Exynos5433 SoC" and "arm64: dts: exynos: Add clocks to > Exynos5433 LPASS module" patches, which are already merged) > > v2: > - fixed issues pointed by Krzysztof Kozlowski: > 1. added more checks to Exynos PMU driver for NULL drvdata > 2. reused EXYNOS_WAKEUP_FROM_LOWPWR in retention data for Exynos5433 > 3. converted lpass driver to devm_clk_get > 4. added missing ->remove callback to lpass driver > > v1: https://lkml.org/lkml/2017/1/25/214 > - initial version > > > Patch summary: > > Marek Szyprowski (7): > soc: smasung: pmu: Add register defines for pad retention control > pinctrl: samsung: Ensure that pad retention is disabled on driver init > pinctrl: samsung: Add support for pad retention control for Exynos5433 > SoCs > mfd: exynos-lpass: Remove pad retention control > mfd: exynos-lpass: Add support for clocks > mfd: exynos-lpass: Add missing remove() function > mfd: exynos-lpass: Add runtime PM support > > .../bindings/mfd/samsung,exynos5433-lpass.txt | 8 ++- > drivers/mfd/exynos-lpass.c | 48 ++++++++++------- > drivers/pinctrl/samsung/pinctrl-exynos.c | 63 ++++++++++++++++++++++ > include/linux/mfd/syscon/exynos5-pmu.h | 3 -- > include/linux/soc/samsung/exynos-regs-pmu.h | 16 ++++++ > 5 files changed, 115 insertions(+), 23 deletions(-) > -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog From mboxrd@z Thu Jan 1 00:00:00 1970 From: lee.jones@linaro.org (Lee Jones) Date: Wed, 8 Feb 2017 11:46:15 +0000 Subject: [PATCH v3 0/7] Pad retentions support for Exynos5433 In-Reply-To: <1485779908-32147-1-git-send-email-m.szyprowski@samsung.com> References: <1485779908-32147-1-git-send-email-m.szyprowski@samsung.com> Message-ID: <20170208114615.c4wszjmnuackgzvx@dell> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Mon, 30 Jan 2017, Marek Szyprowski wrote: > Hello, > > This patchset is a first step to add support for all power domains on > Exynos5433 SoCs. This patchset contains patches for Exynos pin control > driver and Exynos LPASS MFD driver, which are needed to make the > platform ready for adding power domains support. > > Patches in this patchset depends on each other. They are order in such a > way to make the changes bisectable. > > Patch #2 has compile dependency on #1. > Patch #3 has runtime dependency on commit fa59aa70907b2 ("soc: samsung: > pmu: Add dummy support for Exynos5433 SoC", > for-v4.11/drivers-soc-exynos-pmu-the-joy-never-ends branch). > Patch #4 has runtime dependency on #3. > Patch #5 has runtime dependency on commit 7547162ac3514 ("arm64: dts: > exynos: Add clocks to Exynos5433 LPASS module, next/dt64 branch). > > This patchset also directly depends on the "Move pad retention control to > Exynos pin controller driver" patchset: > https://www.spinics.net/lists/arm-kernel/msg556074.html > > Patches have been generated on top of linux-next from 30th January 2017 > with the above mentioned patchset applied. > > This is a part of a larger task, which goal is to add support for power > domains on Exynos5433 SoCs / TM2 boards. First version of the all patches > needed to get it working have been pushed to the following git repo: > https://git.linaro.org/people/marek.szyprowski/linux-srpol.git v4.10-next-tm2-pd > > Best regards > Marek Szyprowski > Samsung R&D Institute Poland Looks like I reviewed v2. If the patches haven't changed that much, please apply my Acks to this set instead. Anything that has changed, please leave them off and repost. > Changelog: > v3: > - moved adding new PMU register defines to separate patch (requested by > Krzysztof Kozlowski) > - rebased onto Linux next-20170130 (removed "soc: samsung: pmu: Add dummy > support for Exynos5433 SoC" and "arm64: dts: exynos: Add clocks to > Exynos5433 LPASS module" patches, which are already merged) > > v2: > - fixed issues pointed by Krzysztof Kozlowski: > 1. added more checks to Exynos PMU driver for NULL drvdata > 2. reused EXYNOS_WAKEUP_FROM_LOWPWR in retention data for Exynos5433 > 3. converted lpass driver to devm_clk_get > 4. added missing ->remove callback to lpass driver > > v1: https://lkml.org/lkml/2017/1/25/214 > - initial version > > > Patch summary: > > Marek Szyprowski (7): > soc: smasung: pmu: Add register defines for pad retention control > pinctrl: samsung: Ensure that pad retention is disabled on driver init > pinctrl: samsung: Add support for pad retention control for Exynos5433 > SoCs > mfd: exynos-lpass: Remove pad retention control > mfd: exynos-lpass: Add support for clocks > mfd: exynos-lpass: Add missing remove() function > mfd: exynos-lpass: Add runtime PM support > > .../bindings/mfd/samsung,exynos5433-lpass.txt | 8 ++- > drivers/mfd/exynos-lpass.c | 48 ++++++++++------- > drivers/pinctrl/samsung/pinctrl-exynos.c | 63 ++++++++++++++++++++++ > include/linux/mfd/syscon/exynos5-pmu.h | 3 -- > include/linux/soc/samsung/exynos-regs-pmu.h | 16 ++++++ > 5 files changed, 115 insertions(+), 23 deletions(-) > -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org ? Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog