From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754281AbdBHMC1 (ORCPT ); Wed, 8 Feb 2017 07:02:27 -0500 Received: from mail-wm0-f48.google.com ([74.125.82.48]:34584 "EHLO mail-wm0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752949AbdBHMC0 (ORCPT ); Wed, 8 Feb 2017 07:02:26 -0500 Date: Wed, 8 Feb 2017 12:02:22 +0000 From: Lee Jones To: Borislav Petkov Cc: LKML Subject: Re: [PATCH] mfd: rtsx: Convert forgotten dev_info() statement to pcr_dbg() Message-ID: <20170208120222.pyhxy2c4yfzy32sj@dell> References: <20170202205935.1452-1-bp@alien8.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20170202205935.1452-1-bp@alien8.de> User-Agent: Mutt/1.6.2-neo (2016-08-21) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 02 Feb 2017, Borislav Petkov wrote: > From: Borislav Petkov > > It is a debugging statement so make it be issued only then. > > No functionality change. > > Signed-off-by: Borislav Petkov > Cc: Lee Jones > --- > drivers/mfd/rtsx_pcr.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mfd/rtsx_pcr.c b/drivers/mfd/rtsx_pcr.c > index 98029ee0959e..850590aac008 100644 > --- a/drivers/mfd/rtsx_pcr.c > +++ b/drivers/mfd/rtsx_pcr.c > @@ -927,7 +927,7 @@ static irqreturn_t rtsx_pci_isr(int irq, void *dev_id) > > static int rtsx_pci_acquire_irq(struct rtsx_pcr *pcr) > { > - dev_info(&(pcr->pci->dev), "%s: pcr->msi_en = %d, pci->irq = %d\n", > + pcr_dbg(pcr, "%s: pcr->msi_en = %d, pci->irq = %d\n", > __func__, pcr->msi_en, pcr->pci->irq); I usually disapprove of these kinds of abstractions. What is the point of it? Why can't you just use dev_dbg()? > if (request_irq(pcr->pci->irq, rtsx_pci_isr, -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog