From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933276AbdBHNN0 (ORCPT ); Wed, 8 Feb 2017 08:13:26 -0500 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:43370 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S933264AbdBHNNO (ORCPT ); Wed, 8 Feb 2017 08:13:14 -0500 Date: Wed, 8 Feb 2017 05:02:46 -0800 From: "Paul E. McKenney" To: Peter Zijlstra Cc: Waiman Long , Ingo Molnar , Ingo Molnar , linux-kernel@vger.kernel.org, Linus Torvalds , Thomas Gleixner , Andrew Morton Subject: Re: [PATCH v3 0/3] locking/spinlock_debug: Change it to a mostly fair lock Reply-To: paulmck@linux.vnet.ibm.com References: <1486044929-7244-1-git-send-email-longman@redhat.com> <20170207084553.GW6500@twins.programming.kicks-ass.net> <20170207094816.GC9829@gmail.com> <20170207195308.GY30506@linux.vnet.ibm.com> <20170208092726.GV6515@twins.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170208092726.GV6515@twins.programming.kicks-ass.net> User-Agent: Mutt/1.5.21 (2010-09-15) X-TM-AS-GCONF: 00 X-Content-Scanned: Fidelis XPS MAILER x-cbid: 17020813-0012-0000-0000-000013973058 X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00006579; HX=3.00000240; KW=3.00000007; PH=3.00000004; SC=3.00000203; SDB=6.00818944; UDB=6.00400250; IPR=6.00596403; BA=6.00005126; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009; ZB=6.00000000; ZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00014223; XFM=3.00000011; UTC=2017-02-08 13:02:49 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17020813-0013-0000-0000-00004B3BA429 Message-Id: <20170208130246.GJ30506@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-02-08_08:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1612050000 definitions=main-1702080127 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 08, 2017 at 10:27:26AM +0100, Peter Zijlstra wrote: > On Tue, Feb 07, 2017 at 11:53:08AM -0800, Paul E. McKenney wrote: > > My usual question is "how often does the spinlock_debug code find a > > problem that would be hard to find otherwise?" Probably unanswerable > > given the nature of Linux-kernel development, but I figured I would ask > > anyway. ;-) > > So I've not found it useful in many years, and quite to the contrary, > its proven prone to generate false positives because the lock timeout > gets hit because of various reasons. > > But that's just me of course.. I have seen neither useful information nor false positives from it, nor have I heard of anyone else having recently done so. So I have nothing indicating that I should either defend it on the one hand or advocate for its removal on the other. But I was asked, so... One approach would be to push the patch and see if anyone complained. But there are quite a few people who wouldn't complain about anything until it bit them, which wouldn't happen for some time. Which -might- be OK, but... Another would be to announce the patch widely, via social media, LWN articles, presentations, etc., in order to increase the probability of finding out if anyone relies on it sooner rather than later. My recommendation is to do both in parallel. Get the patch out there for testing, get it headed for mainline, and make noise about it along the way. If no one complains, it goes in. If someone does complain, we can see what they really need, which would hopefully point the way to an improved mechanism. But that's just me of course... ;-) Thanx, Paul