From: "Nélio Laranjeiro" <nelio.laranjeiro@6wind.com>
To: Yongseok Koh <yskoh@mellanox.com>
Cc: guillaume.gaudonville@6wind.com, ferruh.yigit@intel.com,
dev@dpdk.org, adrien.mazarguil@6wind.com, stable@dpdk.org
Subject: Re: [PATCH] net/mlx5: fix updating total length of multi-packet send
Date: Wed, 8 Feb 2017 15:28:28 +0100 [thread overview]
Message-ID: <20170208142828.GH28684@autoinstall.dev.6wind.com> (raw)
In-Reply-To: <20170202184332.22187-1-yskoh@mellanox.com>
On Thu, Feb 02, 2017 at 10:43:32AM -0800, Yongseok Koh wrote:
> The total length field in descriptor of inlined multi-packet send must be
> updated before closing a seesion. There's possibility of updating it
> afterward. This bug might cause one packet out of MLX5_MPW_DSEG_MAX gets
> silently dropped by HW and impact performance, escpecially lossless test.
>
> Fixes: 230189d9ff22 ("net/mlx5: support multi-packet send")
> CC: stable@dpdk.org
>
> Signed-off-by: Yongseok Koh <yskoh@mellanox.com>
> ---
> drivers/net/mlx5/mlx5_rxtx.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/mlx5/mlx5_rxtx.c b/drivers/net/mlx5/mlx5_rxtx.c
> index 94fe74763..1043ebbc0 100644
> --- a/drivers/net/mlx5/mlx5_rxtx.c
> +++ b/drivers/net/mlx5/mlx5_rxtx.c
> @@ -1046,6 +1046,7 @@ mlx5_tx_burst_mpw_inline(void *dpdk_txq, struct rte_mbuf **pkts,
> mpw.data.raw += length;
> }
> ++mpw.pkts_n;
> + mpw.total_len += length;
> ++j;
> if (mpw.pkts_n == MLX5_MPW_DSEG_MAX) {
> mlx5_mpw_inline_close(txq, &mpw);
> @@ -1055,7 +1056,6 @@ mlx5_tx_burst_mpw_inline(void *dpdk_txq, struct rte_mbuf **pkts,
> inline_room -= length;
> }
> }
> - mpw.total_len += length;
> elts_head = elts_head_next;
> #ifdef MLX5_PMD_SOFT_COUNTERS
> /* Increment sent bytes counter. */
> --
> 2.11.0
Acked-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
--
Nélio Laranjeiro
6WIND
next prev parent reply other threads:[~2017-02-08 14:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-02 18:43 [PATCH] net/mlx5: fix updating total length of multi-packet send Yongseok Koh
2017-02-08 14:28 ` Nélio Laranjeiro [this message]
2017-02-08 15:37 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170208142828.GH28684@autoinstall.dev.6wind.com \
--to=nelio.laranjeiro@6wind.com \
--cc=adrien.mazarguil@6wind.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=guillaume.gaudonville@6wind.com \
--cc=stable@dpdk.org \
--cc=yskoh@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.