From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932995AbdBHPIx (ORCPT ); Wed, 8 Feb 2017 10:08:53 -0500 Received: from mail-wr0-f193.google.com ([209.85.128.193]:34724 "EHLO mail-wr0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751714AbdBHPII (ORCPT ); Wed, 8 Feb 2017 10:08:08 -0500 Date: Wed, 8 Feb 2017 16:06:45 +0100 From: Corentin Labbe To: Joe Perches Cc: peppe.cavallaro@st.com, alexandre.torgue@st.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 06/16] net: stmmac: fix some code style problem Message-ID: <20170208150645.GA11421@Red> References: <20170208083121.27949-1-clabbe.montjoie@gmail.com> <20170208083121.27949-7-clabbe.montjoie@gmail.com> <1486550518.27834.13.camel@perches.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1486550518.27834.13.camel@perches.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 08, 2017 at 02:41:58AM -0800, Joe Perches wrote: > On Wed, 2017-02-08 at 09:31 +0100, Corentin Labbe wrote: > > Checkpatch complains about some code style problem on stmmac_mdio.c. > > This patch fix them. > [] > > diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c > [] > > @@ -258,6 +258,7 @@ int stmmac_mdio_register(struct net_device *ndev) > > found = 0; > > for (addr = 0; addr < PHY_MAX_ADDR; addr++) { > > struct phy_device *phydev = mdiobus_get_phy(new_bus, addr); > > + > > if (phydev) { > > int act = 0; > > char irq_num[4]; > > Maybe use > if (!phydev) > continue; > to reduce indentation Thanks I will do it in a subsequent patch Regards Corentin Labbe