From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753785AbdBHQPo (ORCPT ); Wed, 8 Feb 2017 11:15:44 -0500 Received: from mail-qk0-f171.google.com ([209.85.220.171]:35061 "EHLO mail-qk0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752056AbdBHQPX (ORCPT ); Wed, 8 Feb 2017 11:15:23 -0500 Date: Wed, 8 Feb 2017 11:14:40 -0500 From: Sean Paul To: Chris Zhong Cc: john@metanate.com, dianders@chromium.org, tfiga@chromium.org, heiko@sntech.de, yzq@rock-chips.com, mark.rutland@arm.com, devicetree@vger.kernel.org, robh+dt@kernel.org, galak@codeaurora.org, pawel.moll@arm.com, seanpaul@chromium.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v6 0/6] Rockchip dw-mipi-dsi driver Message-ID: <20170208161440.GD14321@art_vandelay> References: <1486520722-8853-1-git-send-email-zyw@rock-chips.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1486520722-8853-1-git-send-email-zyw@rock-chips.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 08, 2017 at 10:25:16AM +0800, Chris Zhong wrote: > Hi all > > This patch serial is for RK3399 MIPI DSI. The MIPI DSI controller of > RK3399 is almost the same as RK3288, except a little bit of difference > in phy clock controlling and port id selection register. These patches > add RK3399 support and the power domain support. > > And these patches base on John Keeping's v3 patches[0], it fixes many bugs, > they have been tested on rk3288 evb board. > Hi Chris, The set looks good with the exception of 4/6, since we don't have any bounds checking in vop yet. Once the bounds checking is in place and John's set is merged, this set can be pulled into -misc. Thanks, Sean > [0]: > [01/24] https://patchwork.kernel.org/patch/9544089 > [02/24] https://patchwork.kernel.org/patch/9544061 > [03/24] https://patchwork.kernel.org/patch/9544065 > [04/24] https://patchwork.kernel.org/patch/9544077 > [05/24] https://patchwork.kernel.org/patch/9544033 > [06/24] https://patchwork.kernel.org/patch/9544037 > [07/24] https://patchwork.kernel.org/patch/9544029 > [08/24] https://patchwork.kernel.org/patch/9544031 > [09/24] https://patchwork.kernel.org/patch/9544083 > [10/24] https://patchwork.kernel.org/patch/9544063 > [11/24] https://patchwork.kernel.org/patch/9544085 > [12/24] https://patchwork.kernel.org/patch/9544093 > [13/24] https://patchwork.kernel.org/patch/9544081 > [14/24] https://patchwork.kernel.org/patch/9544057 > [15/24] https://patchwork.kernel.org/patch/9544079 > [16/24] https://patchwork.kernel.org/patch/9544035 > [17/24] https://patchwork.kernel.org/patch/9544105 > [18/24] https://patchwork.kernel.org/patch/9544059 > [21/24] https://patchwork.kernel.org/patch/9544009 > [22/24] https://patchwork.kernel.org/patch/9544049 > [23/24] https://patchwork.kernel.org/patch/9544055 > [24/24] https://patchwork.kernel.org/patch/9544109 > > > Changes in v6: > - no need check phy_cfg_clk before enable/disable > > Changes in v5: > - check the error of phy_cfg_clk in dw_mipi_dsi_bind > > Changes in v4: > - remove the unrelated change > > Changes in v3: > - base on John Keeping's patch series > > Chris Zhong (6): > dt-bindings: add rk3399 support for dw-mipi-rockchip > drm/rockchip/dsi: dw-mipi: support RK3399 mipi dsi > drm/rockchip/dsi: dw-mipi: correct the coding style > drm/rockchip/dsi: remove mode_valid function > dt-bindings: add power domain node for dw-mipi-rockchip > drm/rockchip/dsi: add dw-mipi power domain support > > .../display/rockchip/dw_mipi_dsi_rockchip.txt | 7 +- > drivers/gpu/drm/rockchip/dw-mipi-dsi.c | 156 ++++++++++++--------- > 2 files changed, 98 insertions(+), 65 deletions(-) > > -- > 2.6.3 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Sean Paul, Software Engineer, Google / Chromium OS From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sean Paul Subject: Re: [PATCH v6 0/6] Rockchip dw-mipi-dsi driver Date: Wed, 8 Feb 2017 11:14:40 -0500 Message-ID: <20170208161440.GD14321@art_vandelay> References: <1486520722-8853-1-git-send-email-zyw@rock-chips.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <1486520722-8853-1-git-send-email-zyw@rock-chips.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Chris Zhong Cc: mark.rutland@arm.com, devicetree@vger.kernel.org, pawel.moll@arm.com, yzq@rock-chips.com, linux-kernel@vger.kernel.org, dianders@chromium.org, dri-devel@lists.freedesktop.org, tfiga@chromium.org, linux-rockchip@lists.infradead.org, robh+dt@kernel.org, galak@codeaurora.org, linux-arm-kernel@lists.infradead.org List-Id: devicetree@vger.kernel.org T24gV2VkLCBGZWIgMDgsIDIwMTcgYXQgMTA6MjU6MTZBTSArMDgwMCwgQ2hyaXMgWmhvbmcgd3Jv dGU6Cj4gSGkgYWxsCj4gCj4gVGhpcyBwYXRjaCBzZXJpYWwgaXMgZm9yIFJLMzM5OSBNSVBJIERT SS4gVGhlIE1JUEkgRFNJIGNvbnRyb2xsZXIgb2YKPiBSSzMzOTkgaXMgYWxtb3N0IHRoZSBzYW1l IGFzIFJLMzI4OCwgZXhjZXB0IGEgbGl0dGxlIGJpdCBvZiBkaWZmZXJlbmNlCj4gaW4gcGh5IGNs b2NrIGNvbnRyb2xsaW5nIGFuZCBwb3J0IGlkIHNlbGVjdGlvbiByZWdpc3Rlci4gVGhlc2UgcGF0 Y2hlcwo+IGFkZCBSSzMzOTkgc3VwcG9ydCBhbmQgdGhlIHBvd2VyIGRvbWFpbiBzdXBwb3J0Lgo+ IAo+IEFuZCB0aGVzZSBwYXRjaGVzIGJhc2Ugb24gSm9obiBLZWVwaW5nJ3MgdjMgcGF0Y2hlc1sw XSwgaXQgZml4ZXMgbWFueSBidWdzLAo+IHRoZXkgaGF2ZSBiZWVuIHRlc3RlZCBvbiByazMyODgg ZXZiIGJvYXJkLgo+IAoKSGkgQ2hyaXMsClRoZSBzZXQgbG9va3MgZ29vZCB3aXRoIHRoZSBleGNl cHRpb24gb2YgNC82LCBzaW5jZSB3ZSBkb24ndCBoYXZlIGFueSBib3VuZHMKY2hlY2tpbmcgaW4g dm9wIHlldC4gCgpPbmNlIHRoZSBib3VuZHMgY2hlY2tpbmcgaXMgaW4gcGxhY2UgYW5kIEpvaG4n cyBzZXQgaXMgbWVyZ2VkLCB0aGlzIHNldCBjYW4gYmUKcHVsbGVkIGludG8gLW1pc2MuCgpUaGFu a3MsCgpTZWFuCgoKPiBbMF06Cj4gWzAxLzI0XSBodHRwczovL3BhdGNod29yay5rZXJuZWwub3Jn L3BhdGNoLzk1NDQwODkKPiBbMDIvMjRdIGh0dHBzOi8vcGF0Y2h3b3JrLmtlcm5lbC5vcmcvcGF0 Y2gvOTU0NDA2MQo+IFswMy8yNF0gaHR0cHM6Ly9wYXRjaHdvcmsua2VybmVsLm9yZy9wYXRjaC85 NTQ0MDY1Cj4gWzA0LzI0XSBodHRwczovL3BhdGNod29yay5rZXJuZWwub3JnL3BhdGNoLzk1NDQw NzcKPiBbMDUvMjRdIGh0dHBzOi8vcGF0Y2h3b3JrLmtlcm5lbC5vcmcvcGF0Y2gvOTU0NDAzMwo+ IFswNi8yNF0gaHR0cHM6Ly9wYXRjaHdvcmsua2VybmVsLm9yZy9wYXRjaC85NTQ0MDM3Cj4gWzA3 LzI0XSBodHRwczovL3BhdGNod29yay5rZXJuZWwub3JnL3BhdGNoLzk1NDQwMjkKPiBbMDgvMjRd IGh0dHBzOi8vcGF0Y2h3b3JrLmtlcm5lbC5vcmcvcGF0Y2gvOTU0NDAzMQo+IFswOS8yNF0gaHR0 cHM6Ly9wYXRjaHdvcmsua2VybmVsLm9yZy9wYXRjaC85NTQ0MDgzCj4gWzEwLzI0XSBodHRwczov L3BhdGNod29yay5rZXJuZWwub3JnL3BhdGNoLzk1NDQwNjMKPiBbMTEvMjRdIGh0dHBzOi8vcGF0 Y2h3b3JrLmtlcm5lbC5vcmcvcGF0Y2gvOTU0NDA4NQo+IFsxMi8yNF0gaHR0cHM6Ly9wYXRjaHdv cmsua2VybmVsLm9yZy9wYXRjaC85NTQ0MDkzCj4gWzEzLzI0XSBodHRwczovL3BhdGNod29yay5r ZXJuZWwub3JnL3BhdGNoLzk1NDQwODEKPiBbMTQvMjRdIGh0dHBzOi8vcGF0Y2h3b3JrLmtlcm5l bC5vcmcvcGF0Y2gvOTU0NDA1Nwo+IFsxNS8yNF0gaHR0cHM6Ly9wYXRjaHdvcmsua2VybmVsLm9y Zy9wYXRjaC85NTQ0MDc5Cj4gWzE2LzI0XSBodHRwczovL3BhdGNod29yay5rZXJuZWwub3JnL3Bh dGNoLzk1NDQwMzUKPiBbMTcvMjRdIGh0dHBzOi8vcGF0Y2h3b3JrLmtlcm5lbC5vcmcvcGF0Y2gv OTU0NDEwNQo+IFsxOC8yNF0gaHR0cHM6Ly9wYXRjaHdvcmsua2VybmVsLm9yZy9wYXRjaC85NTQ0 MDU5Cj4gWzIxLzI0XSBodHRwczovL3BhdGNod29yay5rZXJuZWwub3JnL3BhdGNoLzk1NDQwMDkK PiBbMjIvMjRdIGh0dHBzOi8vcGF0Y2h3b3JrLmtlcm5lbC5vcmcvcGF0Y2gvOTU0NDA0OQo+IFsy My8yNF0gaHR0cHM6Ly9wYXRjaHdvcmsua2VybmVsLm9yZy9wYXRjaC85NTQ0MDU1Cj4gWzI0LzI0 XSBodHRwczovL3BhdGNod29yay5rZXJuZWwub3JnL3BhdGNoLzk1NDQxMDkKPiAKPiAKPiBDaGFu Z2VzIGluIHY2Ogo+IC0gbm8gbmVlZCBjaGVjayBwaHlfY2ZnX2NsayBiZWZvcmUgZW5hYmxlL2Rp c2FibGUKPiAKPiBDaGFuZ2VzIGluIHY1Ogo+IC0gY2hlY2sgdGhlIGVycm9yIG9mIHBoeV9jZmdf Y2xrIGluIGR3X21pcGlfZHNpX2JpbmQKPiAKPiBDaGFuZ2VzIGluIHY0Ogo+IC0gcmVtb3ZlIHRo ZSB1bnJlbGF0ZWQgY2hhbmdlCj4gCj4gQ2hhbmdlcyBpbiB2MzoKPiAtIGJhc2Ugb24gSm9obiBL ZWVwaW5nJ3MgcGF0Y2ggc2VyaWVzCj4gCj4gQ2hyaXMgWmhvbmcgKDYpOgo+ICAgZHQtYmluZGlu Z3M6IGFkZCByazMzOTkgc3VwcG9ydCBmb3IgZHctbWlwaS1yb2NrY2hpcAo+ICAgZHJtL3JvY2tj aGlwL2RzaTogZHctbWlwaTogc3VwcG9ydCBSSzMzOTkgbWlwaSBkc2kKPiAgIGRybS9yb2NrY2hp cC9kc2k6IGR3LW1pcGk6IGNvcnJlY3QgdGhlIGNvZGluZyBzdHlsZQo+ICAgZHJtL3JvY2tjaGlw L2RzaTogcmVtb3ZlIG1vZGVfdmFsaWQgZnVuY3Rpb24KPiAgIGR0LWJpbmRpbmdzOiBhZGQgcG93 ZXIgZG9tYWluIG5vZGUgZm9yIGR3LW1pcGktcm9ja2NoaXAKPiAgIGRybS9yb2NrY2hpcC9kc2k6 IGFkZCBkdy1taXBpIHBvd2VyIGRvbWFpbiBzdXBwb3J0Cj4gCj4gIC4uLi9kaXNwbGF5L3JvY2tj aGlwL2R3X21pcGlfZHNpX3JvY2tjaGlwLnR4dCAgICAgIHwgICA3ICstCj4gIGRyaXZlcnMvZ3B1 L2RybS9yb2NrY2hpcC9kdy1taXBpLWRzaS5jICAgICAgICAgICAgIHwgMTU2ICsrKysrKysrKysr Ky0tLS0tLS0tLQo+ICAyIGZpbGVzIGNoYW5nZWQsIDk4IGluc2VydGlvbnMoKyksIDY1IGRlbGV0 aW9ucygtKQo+IAo+IC0tIAo+IDIuNi4zCj4gCj4gX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX18KPiBkcmktZGV2ZWwgbWFpbGluZyBsaXN0Cj4gZHJpLWRldmVs QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+IGh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21h aWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCgotLSAKU2VhbiBQYXVsLCBTb2Z0d2FyZSBFbmdpbmVl ciwgR29vZ2xlIC8gQ2hyb21pdW0gT1MKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJl ZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGlu Zm8vZHJpLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 From: seanpaul@chromium.org (Sean Paul) Date: Wed, 8 Feb 2017 11:14:40 -0500 Subject: [PATCH v6 0/6] Rockchip dw-mipi-dsi driver In-Reply-To: <1486520722-8853-1-git-send-email-zyw@rock-chips.com> References: <1486520722-8853-1-git-send-email-zyw@rock-chips.com> Message-ID: <20170208161440.GD14321@art_vandelay> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Wed, Feb 08, 2017 at 10:25:16AM +0800, Chris Zhong wrote: > Hi all > > This patch serial is for RK3399 MIPI DSI. The MIPI DSI controller of > RK3399 is almost the same as RK3288, except a little bit of difference > in phy clock controlling and port id selection register. These patches > add RK3399 support and the power domain support. > > And these patches base on John Keeping's v3 patches[0], it fixes many bugs, > they have been tested on rk3288 evb board. > Hi Chris, The set looks good with the exception of 4/6, since we don't have any bounds checking in vop yet. Once the bounds checking is in place and John's set is merged, this set can be pulled into -misc. Thanks, Sean > [0]: > [01/24] https://patchwork.kernel.org/patch/9544089 > [02/24] https://patchwork.kernel.org/patch/9544061 > [03/24] https://patchwork.kernel.org/patch/9544065 > [04/24] https://patchwork.kernel.org/patch/9544077 > [05/24] https://patchwork.kernel.org/patch/9544033 > [06/24] https://patchwork.kernel.org/patch/9544037 > [07/24] https://patchwork.kernel.org/patch/9544029 > [08/24] https://patchwork.kernel.org/patch/9544031 > [09/24] https://patchwork.kernel.org/patch/9544083 > [10/24] https://patchwork.kernel.org/patch/9544063 > [11/24] https://patchwork.kernel.org/patch/9544085 > [12/24] https://patchwork.kernel.org/patch/9544093 > [13/24] https://patchwork.kernel.org/patch/9544081 > [14/24] https://patchwork.kernel.org/patch/9544057 > [15/24] https://patchwork.kernel.org/patch/9544079 > [16/24] https://patchwork.kernel.org/patch/9544035 > [17/24] https://patchwork.kernel.org/patch/9544105 > [18/24] https://patchwork.kernel.org/patch/9544059 > [21/24] https://patchwork.kernel.org/patch/9544009 > [22/24] https://patchwork.kernel.org/patch/9544049 > [23/24] https://patchwork.kernel.org/patch/9544055 > [24/24] https://patchwork.kernel.org/patch/9544109 > > > Changes in v6: > - no need check phy_cfg_clk before enable/disable > > Changes in v5: > - check the error of phy_cfg_clk in dw_mipi_dsi_bind > > Changes in v4: > - remove the unrelated change > > Changes in v3: > - base on John Keeping's patch series > > Chris Zhong (6): > dt-bindings: add rk3399 support for dw-mipi-rockchip > drm/rockchip/dsi: dw-mipi: support RK3399 mipi dsi > drm/rockchip/dsi: dw-mipi: correct the coding style > drm/rockchip/dsi: remove mode_valid function > dt-bindings: add power domain node for dw-mipi-rockchip > drm/rockchip/dsi: add dw-mipi power domain support > > .../display/rockchip/dw_mipi_dsi_rockchip.txt | 7 +- > drivers/gpu/drm/rockchip/dw-mipi-dsi.c | 156 ++++++++++++--------- > 2 files changed, 98 insertions(+), 65 deletions(-) > > -- > 2.6.3 > > _______________________________________________ > dri-devel mailing list > dri-devel at lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Sean Paul, Software Engineer, Google / Chromium OS