From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754062AbdBHQbu (ORCPT ); Wed, 8 Feb 2017 11:31:50 -0500 Received: from mail-pg0-f66.google.com ([74.125.83.66]:34715 "EHLO mail-pg0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752911AbdBHQbs (ORCPT ); Wed, 8 Feb 2017 11:31:48 -0500 From: Wei Yongjun To: Cyrille Pitchen , Marek Vasut , David Woodhouse , Brian Norris , Boris Brezillon , Richard Weinberger Cc: Wei Yongjun , linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH -next] mtd: aspeed: remove redundant dev_err call in aspeed_smc_probe() Date: Wed, 8 Feb 2017 16:23:10 +0000 Message-Id: <20170208162310.6048-1-weiyj.lk@gmail.com> X-Mailer: git-send-email 2.9.3 MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Wei Yongjun There is a error message within devm_ioremap_resource already, so remove the dev_err call to avoid redundant error message. Signed-off-by: Wei Yongjun --- drivers/mtd/spi-nor/aspeed-smc.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/mtd/spi-nor/aspeed-smc.c b/drivers/mtd/spi-nor/aspeed-smc.c index 7c86099..56051d3 100644 --- a/drivers/mtd/spi-nor/aspeed-smc.c +++ b/drivers/mtd/spi-nor/aspeed-smc.c @@ -723,17 +723,13 @@ static int aspeed_smc_probe(struct platform_device *pdev) res = platform_get_resource(pdev, IORESOURCE_MEM, 0); controller->regs = devm_ioremap_resource(dev, res); - if (IS_ERR(controller->regs)) { - dev_err(dev, "Cannot remap controller address.\n"); + if (IS_ERR(controller->regs)) return PTR_ERR(controller->regs); - } res = platform_get_resource(pdev, IORESOURCE_MEM, 1); controller->ahb_base = devm_ioremap_resource(dev, res); - if (IS_ERR(controller->ahb_base)) { - dev_err(dev, "Cannot remap controller address.\n"); + if (IS_ERR(controller->ahb_base)) return PTR_ERR(controller->ahb_base); - } ret = aspeed_smc_setup_flash(controller, np, res); if (ret)