From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751338AbdBHSTj (ORCPT ); Wed, 8 Feb 2017 13:19:39 -0500 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:54614 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750972AbdBHSTg (ORCPT ); Wed, 8 Feb 2017 13:19:36 -0500 Date: Wed, 8 Feb 2017 18:19:12 +0000 From: Mark Brown To: Dmitry Torokhov Cc: Liam Girdwood , linux-kernel@vger.kernel.org Message-ID: <20170208181912.2v25vdeji22ox5ct@sirena.org.uk> References: <20170203215604.23285-1-dmitry.torokhov@gmail.com> <20170203215604.23285-5-dmitry.torokhov@gmail.com> <20170204114819.xa3goicde4gadvrd@sirena.org.uk> <20170204174502.GA12980@dtor-ws> <20170205161246.mqn5wfxo2krtwps6@sirena.org.uk> <20170207005655.GB35854@dtor-ws> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="jqbwgtbi4cyf4lds" Content-Disposition: inline In-Reply-To: <20170207005655.GB35854@dtor-ws> X-Cookie: Disks travel in packs. User-Agent: NeoMutt/20161126 (1.7.1) X-SA-Exim-Connect-IP: 2001:470:1f1d:6b5::3 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH 5/5] regulator: core: lower severity level of message about using dummy supplies X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: No (on mezzanine.sirena.org.uk); Unknown failure Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --jqbwgtbi4cyf4lds Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Feb 06, 2017 at 04:56:55PM -0800, Dmitry Torokhov wrote: > I can definitely select the severity based on acpi_disabled flag, but I > think you should reconsider: from what I have seen in the kernel quite a > few driversi, even OF-specific ones, select regulator_get_optional() for > no good reason other than to avoid this "scary" warning. If its severity > were reduced quite a few drivers could be switched to normal > regulator_get(). We had problems with people writing obviously problematic code long before we had the warning (or optional regulators), I'm really unconvinced that the warning has anything much to do with it. There will also be some code that predates dummy regulators, or where that support was new enough that people weren't aware of it. We get exactly the same sort of problem with people writing constraints that are clear nonsense (things like a supply named with a specific voltage but a large voltage range). > Candidates for conversion (not complete, just examples): > drivers/input/touchscreen/zforce_ts.c > drivers/input/touchscreen/tsc200x-core.c These are broken, yes. The zforce code at least is old enough that it might predate dummy supplies. > drivers/power/avs/rockchip-io-domain.c This clearly cares about the voltages and could never work with a dummy regulator, it is potentially a good use of optional supplies as far as I can see (though I'm unsure about what an I/O domain without a reference supply would mean). > drivers/mfd/stmpe.c This is again just obviously not good, it just logs but doesn't act on a failure to enable the power supplies. --jqbwgtbi4cyf4lds Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCAAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAlibYR8ACgkQJNaLcl1U h9BW7Qf/VxGpe52fl1/+X1IJXA4aW/UgGCdObAL/PLgM7LhrpdA3JDp4reZZ2PXy 7YqkXMDcVQDXGkCQHDuarGEm/LBOYtt+YAMV02CQFHyp5S1glAN05ZWjQACMOIxL 2jWy3GT+GcNVOaK046KmR+5ISGZTt7zyAZfhdy2OgDLvKyPHEJaPXnCOaMn7rUQ/ dYQ0f5e4tuqYLrWDvfzuOF4KmzXUQpy4zZdo+Nyvk0YBi5uY3D0/z+s/+aN8fNSz 8KQB+crsJzAu4H+4CpQEnqjwQUg3Vgkd4D28007wtqsYKruwCSc/gEsJA8XAvbqG 001phKQ+OUAsGOZIJK3HkIH2TipIjA== =/+rN -----END PGP SIGNATURE----- --jqbwgtbi4cyf4lds--