From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752164AbdBIIy6 (ORCPT ); Thu, 9 Feb 2017 03:54:58 -0500 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:56937 "EHLO out1-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752013AbdBIIxl (ORCPT ); Thu, 9 Feb 2017 03:53:41 -0500 X-ME-Sender: X-Sasl-enc: Wg6qaLktC5106CSSoFbLF9MbIEsj2rkb4GBwUMZmUUBT 1486630318 Date: Thu, 9 Feb 2017 09:51:37 +0100 From: Greg KH To: Lee Jones Cc: Stephen Rothwell , Linus Walleij , linux-next@vger.kernel.org, linux-kernel@vger.kernel.org, Boris Brezillon , Alexander Stein , Andy Shevchenko Subject: Re: [PATCH] serial: st-asc: Use new GPIOD API to obtain RTS pin Message-ID: <20170209085137.GA25944@kroah.com> References: <20170208161113.1b597c01@canb.auug.org.au> <20170208092425.azqkx3nwf4jhsfz5@dell> <20170208130039.GA28327@kroah.com> <20170209082150.m7u53pxz6evt5ckh@dell> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170209082150.m7u53pxz6evt5ckh@dell> User-Agent: Mutt/1.7.2 (2016-11-26) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Feb 09, 2017 at 08:21:50AM +0000, Lee Jones wrote: > On Wed, 08 Feb 2017, Greg KH wrote: > > > On Wed, Feb 08, 2017 at 09:24:25AM +0000, Lee Jones wrote: > > > The commits mentioned below adapt the GPIO API to allow more information > > > to be passed directly through devm_get_gpiod_from_child() in the first > > > instance. This facilitates the removal of subsequent calls, such as > > > gpiod_direction_output(). This patch firstly moves to utilise the new > > > API and secondly removes the now superfluous call do set the direction. > > > > > > Fixes: a264d10ff45c ("gpiolib: Convert fwnode_get_named_gpiod() to configure GPIO") > > > Fixes: b2987d7438e0 ("gpio: Pass GPIO label down to gpiod_request") > > > Fixes: 4b0947974e59 ("gpio: Rename devm_get_gpiod_from_child()") > > > Reported-by: Stephen Rothwell > > > Suggested-by: Boris Brezillon > > > Signed-off-by: Lee Jones > > > --- > > > drivers/tty/serial/st-asc.c | 11 ++++++----- > > > 1 file changed, 6 insertions(+), 5 deletions(-) > > > > > > diff --git a/drivers/tty/serial/st-asc.c b/drivers/tty/serial/st-asc.c > > > index bcf1d33..c334bcc 100644 > > > --- a/drivers/tty/serial/st-asc.c > > > +++ b/drivers/tty/serial/st-asc.c > > > @@ -575,12 +575,13 @@ static void asc_set_termios(struct uart_port *port, struct ktermios *termios, > > > pinctrl_select_state(ascport->pinctrl, > > > ascport->states[NO_HW_FLOWCTRL]); > > > > > > - gpiod = devm_get_gpiod_from_child(port->dev, "rts", > > > - &np->fwnode); > > > - if (!IS_ERR(gpiod)) { > > > - gpiod_direction_output(gpiod, 0); > > > + gpiod = devm_fwnode_get_gpiod_from_child(port->dev, > > > + "rts", > > > + &np->fwnode, > > > + GPIOD_OUT_LOW, > > > + np->name); > > > > I can't apply this :( > > > > Usually, when you move apis around, you add it, then convert it, wait a > > kernel release, then remove the old one. That allows for issues like > > this when new code is added in one maintainer's branch but not yours. > > > > So how about reverting your "drop the function" patch and then wait for > > -rc2 to really remove it? > > I assume this is a question for LinusW? It's for whom ever is causing this breakage by removing an api in this manner. greg k-h