From: Karel Zak <kzak@redhat.com>
To: Carlos Santos <casantos@datacom.ind.br>
Cc: util-linux@vger.kernel.org
Subject: Re: [PATCH] build-sys: improve detection of the "isnan" function in uClibc
Date: Thu, 9 Feb 2017 11:33:50 +0100 [thread overview]
Message-ID: <20170209103350.hy4u5iulzx6chl2m@ws.net.home> (raw)
In-Reply-To: <1486567656-22277-1-git-send-email-casantos@datacom.ind.br>
On Wed, Feb 08, 2017 at 01:27:36PM -0200, Carlos Santos wrote:
> Since commit beceb14b450ded6560ed743634a5e80604a8edf3, MATH_LIBS is set
> to "-lm" when the isnan function is detected. In uClibc, however, isnan
> is a macro that calls __isnan, __isnanf, or __isnanl, depending on the
> size of the argument (double, float or long double).
>
> Fixes:
> http://autobuild.buildroot.net/results/2c2/2c29a78ed81ca844a87dcd076ab3e14ea080296d/
> http://autobuild.buildroot.net/results/404/404b10f359b2ae8a7216729fa1bab37fed2d3d4c/
>
> Signed-off-by: Carlos Santos <casantos@datacom.ind.br>
> ---
> configure.ac | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/configure.ac b/configure.ac
> index 3759921..3bb3ba8 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -435,6 +435,7 @@ AM_CONDITIONAL([HAVE_OPENAT], [test "x$have_openat" = xyes])
>
> AC_CHECK_FUNCS([isnan], [],
> [AC_CHECK_LIB([m], [isnan], [MATH_LIBS="-lm"])]
> + [AC_CHECK_LIB([m], [__isnan], [MATH_LIBS="-lm"])]
> )
> AC_SUBST([MATH_LIBS])
Applied, thanks. (It would be possible to use AC_COMPILE_IFELSE() monster, but if
AC_CHECK_LIB() is good enough than it's probably better.)
Karel
--
Karel Zak <kzak@redhat.com>
http://karelzak.blogspot.com
prev parent reply other threads:[~2017-02-09 10:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-08 15:27 [PATCH] build-sys: improve detection of the "isnan" function in uClibc Carlos Santos
2017-02-09 10:33 ` Karel Zak [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170209103350.hy4u5iulzx6chl2m@ws.net.home \
--to=kzak@redhat.com \
--cc=casantos@datacom.ind.br \
--cc=util-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.