From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753264AbdBKBir (ORCPT ); Fri, 10 Feb 2017 20:38:47 -0500 Received: from mail-pg0-f49.google.com ([74.125.83.49]:33260 "EHLO mail-pg0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753149AbdBKBip (ORCPT ); Fri, 10 Feb 2017 20:38:45 -0500 From: Jess Frazelle To: Stuart Yoder , Greg Kroah-Hartman , Bharat Bhushan , Bhaktipriya Shridhar , Nipun Gupta , Jess Frazelle , linux-kernel@vger.kernel.org (open list:QORIQ DPAA2 FSL-MC BUS DRIVER), devel@driverdev.osuosl.org (open list:STAGING SUBSYSTEM) Cc: kernel-hardening@lists.openwall.com Subject: [PATCH v2 4/5] staging: set msi_domain_ops as __ro_after_init Date: Fri, 10 Feb 2017 17:37:57 -0800 Message-Id: <20170211013758.3288-4-me@jessfraz.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20170211013758.3288-1-me@jessfraz.com> References: <20170211013758.3288-1-me@jessfraz.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Marked msi_domain_ops structs as __ro_after_init when called only during init. This protects the data structure from accidental corruption. Suggested-by: Kees Cook Signed-off-by: Jess Frazelle --- drivers/staging/fsl-mc/bus/irq-gic-v3-its-fsl-mc-msi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/fsl-mc/bus/irq-gic-v3-its-fsl-mc-msi.c b/drivers/staging/fsl-mc/bus/irq-gic-v3-its-fsl-mc-msi.c index 6b1cd574644f..0e2c1b5e13b7 100644 --- a/drivers/staging/fsl-mc/bus/irq-gic-v3-its-fsl-mc-msi.c +++ b/drivers/staging/fsl-mc/bus/irq-gic-v3-its-fsl-mc-msi.c @@ -51,7 +51,7 @@ static int its_fsl_mc_msi_prepare(struct irq_domain *msi_domain, return msi_info->ops->msi_prepare(msi_domain->parent, dev, nvec, info); } -static struct msi_domain_ops its_fsl_mc_msi_ops = { +static struct msi_domain_ops its_fsl_mc_msi_ops __ro_after_init = { .msi_prepare = its_fsl_mc_msi_prepare, }; -- 2.11.0 From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jess Frazelle Date: Fri, 10 Feb 2017 17:37:57 -0800 Message-Id: <20170211013758.3288-4-me@jessfraz.com> In-Reply-To: <20170211013758.3288-1-me@jessfraz.com> References: <20170211013758.3288-1-me@jessfraz.com> Subject: [kernel-hardening] [PATCH v2 4/5] staging: set msi_domain_ops as __ro_after_init To: Stuart Yoder , Greg Kroah-Hartman , Bharat Bhushan , Bhaktipriya Shridhar , Nipun Gupta , Jess Frazelle , "open list:QORIQ DPAA2 FSL-MC BUS DRIVER" , "open list:STAGING SUBSYSTEM" Cc: kernel-hardening@lists.openwall.com List-ID: Marked msi_domain_ops structs as __ro_after_init when called only during init. This protects the data structure from accidental corruption. Suggested-by: Kees Cook Signed-off-by: Jess Frazelle --- drivers/staging/fsl-mc/bus/irq-gic-v3-its-fsl-mc-msi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/fsl-mc/bus/irq-gic-v3-its-fsl-mc-msi.c b/drivers/staging/fsl-mc/bus/irq-gic-v3-its-fsl-mc-msi.c index 6b1cd574644f..0e2c1b5e13b7 100644 --- a/drivers/staging/fsl-mc/bus/irq-gic-v3-its-fsl-mc-msi.c +++ b/drivers/staging/fsl-mc/bus/irq-gic-v3-its-fsl-mc-msi.c @@ -51,7 +51,7 @@ static int its_fsl_mc_msi_prepare(struct irq_domain *msi_domain, return msi_info->ops->msi_prepare(msi_domain->parent, dev, nvec, info); } -static struct msi_domain_ops its_fsl_mc_msi_ops = { +static struct msi_domain_ops its_fsl_mc_msi_ops __ro_after_init = { .msi_prepare = its_fsl_mc_msi_prepare, }; -- 2.11.0