From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751288AbdBLQFO (ORCPT ); Sun, 12 Feb 2017 11:05:14 -0500 Received: from mail.fireflyinternet.com ([109.228.58.192]:59775 "EHLO fireflyinternet.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751217AbdBLQFN (ORCPT ); Sun, 12 Feb 2017 11:05:13 -0500 X-Default-Received-SPF: pass (skip=forwardok (res=PASS)) x-ip-name=78.156.65.138; Date: Sun, 12 Feb 2017 16:03:35 +0000 From: Chris Wilson To: linux-kernel@vger.kernel.org Cc: intel-gfx@lists.freedesktop.org, Tvrtko Ursulin , Thomas Gleixner , Hannes Reinecke , Jens Axboe , Bjorn Helgaas , Alexander Potapenko , Chen Fan , Ingo Molnar , "Peter Zijlstra (Intel)" , Sebastian Andrzej Siewior , Johannes Thumshirn , Emese Revfy , Sagi Grimberg , Eric Dumazet , Tom Herbert , Ben Hutchings Subject: Re: [PATCH v3] softirq: Prevent looping on disabled tasklets Message-ID: <20170212160335.GD14326@nuc-i3427.alporthouse.com> Mail-Followup-To: Chris Wilson , linux-kernel@vger.kernel.org, intel-gfx@lists.freedesktop.org, Tvrtko Ursulin , Thomas Gleixner , Hannes Reinecke , Jens Axboe , Bjorn Helgaas , Alexander Potapenko , Chen Fan , Ingo Molnar , "Peter Zijlstra (Intel)" , Sebastian Andrzej Siewior , Johannes Thumshirn , Emese Revfy , Sagi Grimberg , Eric Dumazet , Tom Herbert , Ben Hutchings References: <20170212140019.3450-1-chris@chris-wilson.co.uk> <20170212154609.20238-1-chris@chris-wilson.co.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170212154609.20238-1-chris@chris-wilson.co.uk> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Feb 12, 2017 at 03:46:09PM +0000, Chris Wilson wrote: > +void tasklet_enable(struct tasklet_struct *t) > +{ > + if (!atomic_dec_and_test(&t->count)) > + return; > + > + if (test_bit(TASKLET_STATE_SCHED, &t->state)) > + raise_softirq(HI_SOFTIRQ | TASKLET_SOFTIRQ); And of course this can't work as raise_softirq() is local to the cpu. -Chris -- Chris Wilson, Intel Open Source Technology Centre From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH v3] softirq: Prevent looping on disabled tasklets Date: Sun, 12 Feb 2017 16:03:35 +0000 Message-ID: <20170212160335.GD14326@nuc-i3427.alporthouse.com> References: <20170212140019.3450-1-chris@chris-wilson.co.uk> <20170212154609.20238-1-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from fireflyinternet.com (mail.fireflyinternet.com [109.228.58.192]) by gabe.freedesktop.org (Postfix) with ESMTPS id 46DF46E31F for ; Sun, 12 Feb 2017 16:05:09 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20170212154609.20238-1-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: linux-kernel@vger.kernel.org Cc: Jens Axboe , Hannes Reinecke , Sagi Grimberg , "Peter Zijlstra (Intel)" , intel-gfx@lists.freedesktop.org, Chen Fan , Eric Dumazet , Emese Revfy , Alexander Potapenko , Johannes Thumshirn , Bjorn Helgaas , Ben Hutchings , Thomas Gleixner , Ingo Molnar , Sebastian Andrzej Siewior , Tom Herbert List-Id: intel-gfx@lists.freedesktop.org T24gU3VuLCBGZWIgMTIsIDIwMTcgYXQgMDM6NDY6MDlQTSArMDAwMCwgQ2hyaXMgV2lsc29uIHdy b3RlOgo+ICt2b2lkIHRhc2tsZXRfZW5hYmxlKHN0cnVjdCB0YXNrbGV0X3N0cnVjdCAqdCkKPiAr ewo+ICsJaWYgKCFhdG9taWNfZGVjX2FuZF90ZXN0KCZ0LT5jb3VudCkpCj4gKwkJcmV0dXJuOwo+ ICsKPiArCWlmICh0ZXN0X2JpdChUQVNLTEVUX1NUQVRFX1NDSEVELCAmdC0+c3RhdGUpKQo+ICsJ CXJhaXNlX3NvZnRpcnEoSElfU09GVElSUSB8IFRBU0tMRVRfU09GVElSUSk7CgpBbmQgb2YgY291 cnNlIHRoaXMgY2FuJ3Qgd29yayBhcyByYWlzZV9zb2Z0aXJxKCkgaXMgbG9jYWwgdG8gdGhlIGNw dS4KLUNocmlzCgotLSAKQ2hyaXMgV2lsc29uLCBJbnRlbCBPcGVuIFNvdXJjZSBUZWNobm9sb2d5 IENlbnRyZQpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJ bnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0 cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK