From: Steven Rostedt <rostedt@goodmis.org>
To: Daniel Bristot de Oliveira <bristot@redhat.com>
Cc: linux-kernel@vger.kernel.org, Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Juri Lelli <juri.lelli@arm.com>,
Tommaso Cucinotta <tommaso.cucinotta@sssup.it>,
Luca Abeni <luca.abeni@santannapisa.it>
Subject: Re: [PATCH 2/2] sched/deadline: Throttle a constrained deadline task activated after the deadline
Date: Mon, 13 Feb 2017 10:33:03 -0500 [thread overview]
Message-ID: <20170213103303.0e3b3953@gandalf.local.home> (raw)
In-Reply-To: <a11b216b344a7ccdf7e3c89a6c8617bb446b91f7.1486754348.git.bristot@redhat.com>
On Fri, 10 Feb 2017 20:48:11 +0100
Daniel Bristot de Oliveira <bristot@redhat.com> wrote:
>
> +static inline bool dl_is_constrained(struct sched_dl_entity *dl_se)
> +{
> + return dl_se->dl_runtime < dl_se->dl_period;
> +}
> +
Is it ever appropriate for a dl task to have runtime == period? What
purpose would that serve? Just run the task as FIFO higher than
everything else.
Or was this suppose to be dl_deadline < dl_period?
-- Steve
next prev parent reply other threads:[~2017-02-13 15:33 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-10 19:48 [PATCH 0/2] sched/deadline: Fixes for constrained deadline tasks Daniel Bristot de Oliveira
2017-02-10 19:48 ` [PATCH 1/2] sched/deadline: Replenishment timer should fire in the next period Daniel Bristot de Oliveira
2017-02-10 21:47 ` Steven Rostedt
2017-02-11 7:12 ` luca abeni
2017-02-13 11:10 ` Peter Zijlstra
2017-02-13 14:59 ` Steven Rostedt
2017-02-13 15:35 ` Juri Lelli
2017-02-10 19:48 ` [PATCH 2/2] sched/deadline: Throttle a constrained deadline task activated after the deadline Daniel Bristot de Oliveira
2017-02-11 7:15 ` luca abeni
2017-02-11 8:00 ` Mike Galbraith
2017-02-11 14:35 ` Steven Rostedt
2017-02-13 11:12 ` Peter Zijlstra
2017-02-13 11:12 ` Peter Zijlstra
2017-02-13 13:16 ` Daniel Bristot de Oliveira
2017-02-13 15:33 ` Steven Rostedt [this message]
2017-02-13 15:46 ` Daniel Bristot de Oliveira
2017-02-13 16:21 ` Daniel Bristot de Oliveira
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170213103303.0e3b3953@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=bristot@redhat.com \
--cc=juri.lelli@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luca.abeni@santannapisa.it \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=tommaso.cucinotta@sssup.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.