From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752134AbdBMSEu (ORCPT ); Mon, 13 Feb 2017 13:04:50 -0500 Received: from mga07.intel.com ([134.134.136.100]:58941 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751472AbdBMSEt (ORCPT ); Mon, 13 Feb 2017 13:04:49 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.35,156,1484035200"; d="scan'208";a="1126040212" Date: Mon, 13 Feb 2017 13:14:06 -0500 From: Keith Busch To: Jess Frazelle Cc: "K. Y. Srinivasan" , Haiyang Zhang , Stephen Hemminger , Bjorn Helgaas , "open list:Hyper-V CORE AND DRIVERS" , "open list:PCI SUBSYSTEM" , open list , kernel-hardening@lists.openwall.com Subject: Re: [PATCH v2 3/5] pci: set msi_domain_ops as __ro_after_init Message-ID: <20170213181406.GD24425@localhost.localdomain> References: <20170211013758.3288-1-me@jessfraz.com> <20170211013758.3288-3-me@jessfraz.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170211013758.3288-3-me@jessfraz.com> User-Agent: Mutt/1.7.0 (2016-08-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Feb 10, 2017 at 05:37:56PM -0800, Jess Frazelle wrote: > Marked msi_domain_ops structs as __ro_after_init when called only during init. > This protects the data structure from accidental corruption. > > Suggested-by: Kees Cook > Signed-off-by: Jess Frazelle > > drivers/pci/host/pci-hyperv.c | 2 +- > drivers/pci/host/vmd.c | 2 +- Ok for vmd driver. Acked-by: Keith Busch > drivers/pci/msi.c | 2 +- > 3 files changed, 3 insertions(+), 3 deletions(-) From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Mon, 13 Feb 2017 13:14:06 -0500 From: Keith Busch Message-ID: <20170213181406.GD24425@localhost.localdomain> References: <20170211013758.3288-1-me@jessfraz.com> <20170211013758.3288-3-me@jessfraz.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170211013758.3288-3-me@jessfraz.com> Subject: [kernel-hardening] Re: [PATCH v2 3/5] pci: set msi_domain_ops as __ro_after_init To: Jess Frazelle Cc: "K. Y. Srinivasan" , Haiyang Zhang , Stephen Hemminger , Bjorn Helgaas , "open list:Hyper-V CORE AND DRIVERS" , "open list:PCI SUBSYSTEM" , open list , kernel-hardening@lists.openwall.com List-ID: On Fri, Feb 10, 2017 at 05:37:56PM -0800, Jess Frazelle wrote: > Marked msi_domain_ops structs as __ro_after_init when called only during init. > This protects the data structure from accidental corruption. > > Suggested-by: Kees Cook > Signed-off-by: Jess Frazelle > > drivers/pci/host/pci-hyperv.c | 2 +- > drivers/pci/host/vmd.c | 2 +- Ok for vmd driver. Acked-by: Keith Busch > drivers/pci/msi.c | 2 +- > 3 files changed, 3 insertions(+), 3 deletions(-)