From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stable-owner@vger.kernel.org>
Received: from mail.linuxfoundation.org ([140.211.169.12]:41158 "EHLO
        mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752126AbdBNOzQ (ORCPT
        <rfc822;stable@vger.kernel.org>); Tue, 14 Feb 2017 09:55:16 -0500
Date: Tue, 14 Feb 2017 06:55:16 -0800
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
        Borislav Petkov <bp@alien8.de>,
        Steven Rostedt <rostedt@goodmis.org>,
        Gabriel C <nix.or.die@gmail.com>,
        Mike Galbraith <efault@gmx.de>,
        stable <stable@vger.kernel.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        Ruslan Ruslichenko <rruslich@cisco.com>,
        Jiri Slaby <jslaby@suse.cz>, Ingo Molnar <mingo@kernel.org>
Subject: Re: Linux 4.9.6 ( Restore IO-APIC irq_chip retrigger callback ,
 breaks my box )
Message-ID: <20170214145516.GA14041@kroah.com>
References: <e0b5e99d-b18c-d54f-505a-d3dd4fb5dc77@gmail.com>
 <CA+55aFxEX1XtBBP2j6uAPfjwpkYm6oii6aL-2UL6mWniGNByXw@mail.gmail.com>
 <alpine.DEB.2.20.1702132029550.3790@nanos>
 <CA+55aFyGYN93b4KeTAqx9CSbAAHbEfQUsqpBz=9h2wzcEe0iTA@mail.gmail.com>
 <20170213204324.mdipw72ueirrkxob@pd.tnic>
 <CA+55aFx=To+Mdgc99VoSM5dvRjy=Ri4MJ97Ukibp0ZE026s7SA@mail.gmail.com>
 <alpine.DEB.2.20.1702132233340.8088@nanos>
 <CA+55aFyYBLHFpGYiwdDT_i6mkFcS-c=o4aVJy49UkHitDEGZsw@mail.gmail.com>
 <alpine.DEB.2.20.1702140915030.3635@nanos>
 <alpine.DEB.2.20.1702141501260.3635@nanos>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <alpine.DEB.2.20.1702141501260.3635@nanos>
Sender: stable-owner@vger.kernel.org
List-ID: <stable.vger.kernel.org>

On Tue, Feb 14, 2017 at 03:49:57PM +0100, Thomas Gleixner wrote:
> On Tue, 14 Feb 2017, Thomas Gleixner wrote:
> > On Mon, 13 Feb 2017, Linus Torvalds wrote:
> > > On Mon, Feb 13, 2017 at 1:35 PM, Thomas Gleixner <tglx@linutronix.de> wrote:
> > > >
> > > > arch/x86/platform/goldfish/goldfish.c
> > > >
> > > > static int __init goldfish_init(void)
> > > > {
> > > >         platform_device_register_simple("goldfish_pdev_bus", -1,
> > > >                                                 goldfish_pdev_bus_resources, 2);
> > > >         return 0;
> > > > }
> > > > device_initcall(goldfish_init);
> > > >
> > > > So it unconditionallyt registers that platform device, which has IRQ 4 as
> > > > irq resource and the driver happily matches on the platform devices.
> > > >
> > > > Wonderful crap, isn't it? It should be made 'depend on BROKEN'.
> > > 
> > > Ugh. Yeah, that's crazy. Random hardcoded interfaces that get enabled
> > > by people by mistake.
> > > 
> > > And yeah, it's not just the irq. It just randomly sets up memory addresses too.
> > > 
> > > That thing needs to be disabled some way. Maybe not marked "broken",
> > > but there needs to be something that actually enables it at runtime
> > > (like a kernel command line option or something like that).
> 
> I prefer to mark it broken, because that's what it is, but we can add a
> command line option as well. See below.

I have no problem marking all of the Goldfish stuff broken as it seems
to be a "dead" platform at the moment, no one is providing any updates
or cares about it, and the only users I know of it are using a _very_
old kernel version (the Android emulator).

Want me to send a patch for that as I think the Goldfish stuff
originally came through my tree...

thanks,

greg k-h