Re: [Qemu-devel] [PATCH v6 2/2] block/vxhs.c: Add qemu-iotests for new block device type "vxhs"

From: "Daniel P. Berrange" <berrange@redhat.com>
To: Jeff Cody <jcody@redhat.com>
Cc: ashish mittal <ashmit602@gmail.com>,
	Ketan Nilangekar <Ketan.Nilangekar@veritas.com>,
	Stefan Hajnoczi <stefanha@gmail.com>,
	qemu-devel <qemu-devel@nongnu.org>,
	Paolo Bonzini <pbonzini@redhat.com>,
	Kevin Wolf <kwolf@redhat.com>,
	Markus Armbruster <armbru@redhat.com>,
	Fam Zheng <famz@redhat.com>,
	Ashish Mittal <Ashish.Mittal@veritas.com>,
	Rakesh Ranjan <Rakesh.Ranjan@veritas.com>,
	Buddhi Madhav <Buddhi.Madhav@veritas.com>,
	Abhijit Dey <Abhijit.Dey@veritas.com>,
	"Venkatesha M.G." <Venkatesha.Mg@veritas.com>
Subject: Re: [Qemu-devel] [PATCH v6 2/2] block/vxhs.c: Add qemu-iotests for new block device type "vxhs"
Date: Tue, 14 Feb 2017 16:51:09 +0000	[thread overview]
Message-ID: <20170214165109.GF17056@redhat.com> (raw)
In-Reply-To: <20170214163517.GQ27752@localhost.localdomain>

On Tue, Feb 14, 2017 at 11:35:17AM -0500, Jeff Cody wrote:
> From 7c135439fd0151860cb0f6ef1a857dfbee6e6317 Mon Sep 17 00:00:00 2001
> From: Jeff Cody <jcody@redhat.com>
> Date: Tue, 14 Feb 2017 09:51:42 -0500
> Subject: [PATCH] qemu-iotests: exclude vxhs from image creation via protocol
> 
> The protocol VXHS does not support image creation.  Some tests expect
> to be able to create images through the protocol.  Exclude VXHS from
> these tests.

[snip]

> diff --git a/tests/qemu-iotests/017 b/tests/qemu-iotests/017
> index e3f9e75..4f9302d 100755
> --- a/tests/qemu-iotests/017
> +++ b/tests/qemu-iotests/017
> @@ -41,6 +41,7 @@ trap "_cleanup; exit \$status" 0 1 2 3 15
>  # Any format supporting backing files
>  _supported_fmt qcow qcow2 vmdk qed
>  _supported_proto generic
> +_unsupported_proto vxhs
>  _supported_os Linux
>  _unsupported_imgopts "subformat=monolithicFlat" "subformat=twoGbMaxExtentFlat"

I've no objection to your patch as is, just a thought for future
improvements.

There's quite a few block protos that doen't support image
creation. Rather than listing protocols in _unsupported_proto
it would be more scalable if we could list features. eg if
each test had

  _supported_feature imagecreate

Then, the tests/qemu-iotests/common file could set the list
of features supported by each protocol/format. Thus avoiding
the need to update all iotests when adding new protocols. We
could have features for "encryption", and "snapshots" and
"backing_files", etc too

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://entangle-photo.org       -o-    http://search.cpan.org/~danberr/ :|