From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752161AbdBORWD (ORCPT ); Wed, 15 Feb 2017 12:22:03 -0500 Received: from quartz.orcorp.ca ([184.70.90.242]:44891 "EHLO quartz.orcorp.ca" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751754AbdBORWC (ORCPT ); Wed, 15 Feb 2017 12:22:02 -0500 Date: Wed, 15 Feb 2017 10:21:57 -0700 From: Jason Gunthorpe To: Alan Tull Cc: Moritz Fischer , linux-kernel@vger.kernel.org, linux-fpga@vger.kernel.org Subject: Re: [RFC 7/8] fpga-region: add sysfs interface Message-ID: <20170215172157.GA3317@obsidianresearch.com> References: <1487175261-7051-1-git-send-email-atull@kernel.org> <1487175261-7051-8-git-send-email-atull@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1487175261-7051-8-git-send-email-atull@kernel.org> User-Agent: Mutt/1.5.24 (2015-08-30) X-Broken-Reverse-DNS: no host name found for IP address 10.0.0.156 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 15, 2017 at 10:14:20AM -0600, Alan Tull wrote: > Add a sysfs interface to control programming FPGA. > > Each fpga-region will get the following files which set values > in the fpga_image_info struct for that region. More files will > need to be added as fpga_image_info expands. > > firmware_name > * writing a name of a FPGA image file to firmware_name causes the > FPGA region to write the FPGA > > partial_config > * 0 : full reconfiguration > * 1 : partial reconfiguration This is really a property of the bitfile. It would be really nice to have a saner system for describing the bitfiles that doesn't rely on so much out of band stuff. Eg when doing partial reconfiguration it would be really sane to have some checks that the full bitfile is the correct basis for the partial bitfile. It also seems link Zynq needs an encrypted/not encrypted flag.. I wonder if we should require a Linux specific header on the bitfile instead? That would make the bitfile self describing at least. Jason