From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752238AbdBOSXO (ORCPT ); Wed, 15 Feb 2017 13:23:14 -0500 Received: from mail-he1eur01on0062.outbound.protection.outlook.com ([104.47.0.62]:44267 "EHLO EUR01-HE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751317AbdBOSXL (ORCPT ); Wed, 15 Feb 2017 13:23:11 -0500 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Mark.Rutland@arm.com; Date: Wed, 15 Feb 2017 18:23:03 +0000 From: Mark Rutland To: Andreas =?utf-8?Q?F=C3=A4rber?= CC: , , , , Rob Herring , Catalin Marinas , Will Deacon , , Subject: Re: [PATCH 11/11] ARM64: dts: Prepare Actions Semi S900 and Bubblegum-96 Message-ID: <20170215182303.GL31733@leverpostej> References: <20170215165528.10052-1-afaerber@suse.de> <20170215165528.10052-12-afaerber@suse.de> <20170215171232.GI31733@leverpostej> <267b586e-06ce-f123-b7cc-dc0feb880ca9@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <267b586e-06ce-f123-b7cc-dc0feb880ca9@suse.de> User-Agent: Mutt/1.5.21 (2010-09-15) X-Originating-IP: [217.140.96.140] X-ClientProxiedBy: DB5PR10CA0028.EURPRD10.PROD.OUTLOOK.COM (10.165.4.166) To DB6PR0802MB2390.eurprd08.prod.outlook.com (10.172.250.143) X-MS-Office365-Filtering-Correlation-Id: 9a8e1a8e-b5b8-47d9-5cd4-08d455cfb0ac X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(48565401081);SRVR:DB6PR0802MB2390; X-Microsoft-Exchange-Diagnostics: 1;DB6PR0802MB2390;3:+6Kyqn/vgSu94KGrzgQfj4YNo71mCtiRf620XneUxLs6mhnkkXMTnam99dgGUttuExW3wOhmDLCtkhbovp13hXIpUKm6LW3vZMceQIVHaPxXxZ6xlq/tdURNfnqFZw+rnkZ/nFzt2nM1hdFbszI4bmff5Q6ZBGrDl65EExuigi0TT8m7KVlDCvzfOowC0sjfKRjfCufGOYo9W6Yh+BYRypjYenXtBsm3xCgw9kRhJelHo52FZFUHRdvBw52XFiI+RRkZGgCmqoVMduR7/wlmKXPKpG858Lo6jzWHDC31RK0=;25:EeeXcAwefoq422goWS21oUAOKbY/Enr11UvgotaZmVBM6uWRNgVvnh+KGbLtN75vJRWAadxcV9XJESjszyVSI5DePIdn7V7YLffnYQyqDOpwl/Gr38/Zn2X840O3PsckZwnmHbMso31vHEZJizJPH9jmgY1EhGqBYIDjqTIDvVdhK+w3lc+jtNxZr397+Vt/QU05c2xWSy5HKtm6z1AZ73sO7Ub0B8P8pzHRL9r2MvwgVfJZLmjOWGR9D4MRBgLOaZ+Lsr9wgGBottW06exBNJXOBlVdG55t1QYxAckl5wlWaJvkYLuM9EsAR4wpHjdLpdqbVlts6GCF2WbfeYbSJqtDvpqOxHTAUgVoQzeVJYV+uzb9RzJ1Nlhn6fL87wfMbN+l12La5WEbBYg9AwoFgKge3mp0WdofsyD8E0pI6AfvAAXpCW7qmY3zkaI/FwMVi7T8PwfnGLyHdBLJpNk0xA== X-Microsoft-Exchange-Diagnostics: 1;DB6PR0802MB2390;31:i5ymRa8JPRUr0kgSOilEQUl0M+QTaGgVeU0NAl4Q4KYz5cH33ie3L5WzK8/dWTDuf+lBRD3DG8M4GWl9zaCfZI35YeUVIqh4gxAVpe1Aj8+ihYE8mlLVlpm1ayrC9Sm058uMo+kpyJqgj11U0er5AFCfdUb537dbH41YVOw1F9/JD2lcm0Ni0JR82bvEAoonxX7yTekKHt7oi7W3qVJAlyEUb/fvMKfvRAakCc85V3JzQFS3Kn9yLGXWsmsb89jb;20:MNmBQan0tHkcXaFcA/C5lbQl6y4o7STOn+U2yTnunyZdH6b7QYXs02FDCiA7VKPq6LsUaT7mK6/iwI/ktNlBOgGOcMukuyyUBXPcK/Ouh1Twp/xQ13gRxnzjuC/BjkQcfXGX5IVAR8Q/DOciDzhNdpnLQGeig1C/EsR2g7AvAUg= NoDisclaimer: True X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(258649278758335); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040375)(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046)(6055026)(6041248)(20161123555025)(20161123558025)(20161123560025)(20161123562025)(20161123564025)(6072148);SRVR:DB6PR0802MB2390;BCL:0;PCL:0;RULEID:;SRVR:DB6PR0802MB2390; X-Microsoft-Exchange-Diagnostics: 1;DB6PR0802MB2390;4:HFjgFsJ2fVpOEMV+JkmXAoTokBolBwy9VpNwwOiNypVXMsyQY8pAVV0BRgsZqs2wbkOr4kbbqwztaYa2hGXvL1J27YJCVIgw14xNgXWgaEHyeGQF1R78IizTSYK8TJ2B+FZ/AuKtLMvc5Jw8mTAiANf2qAWDmGZr0uaCGoZbbhqh0NfHv6+Ca15hcQ7Su8O8KbWK17HM5kLNAKScH6MrKY4YoNuQiRwIQHtPnA1F3Om5J2CFOgLx1qIxkzm83+ZsSulkdyMI5LDRMLkbErhzzApK3RAtKw/lpUdJW19fYs+W2gWmHQp3Gz7ra/K6dwTxqY4FKr17430GQiAiPTVgfgK9Rvnr9tMYoZ38FYmzGjnKg1kw+GqPjickiDtAgQs8lKmcIgR04vA3PyAUSob020n3B3+nSaPdkAPQTqJvHJqI8bgoKyHt9ml0GgRXvWqFj7cS6Ss+wt/9VlajXUQdM11iahGeJO3Xa7BqRGK3S1bQ0O0X/UsmHz+xwUOeyHFe0P+ns483sl6PthD1PFepP1JP26IxU9ze/NUiFS2vKzEFEJzXZciTizJo7ijLyFFZmTG8fb0tYaEwInNdiPne2W3ZIr/uaF1ccozd4cugHqFFwoD0smBabf0vlnEvhzgCC0urYSk4DVfkeM3Ihk7yAdv4/e71FQyKd4AKJyq2+Iw= X-Forefront-PRVS: 021975AE46 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6009001)(7916002)(39840400002)(39450400003)(39860400002)(39410400002)(39850400002)(199003)(24454002)(189002)(6916009)(33656002)(2950100002)(966004)(66066001)(305945005)(92566002)(47776003)(53936002)(86362001)(6496005)(101416001)(6666003)(3846002)(106356001)(105586002)(76176999)(50986999)(4326007)(54356999)(6116002)(1076002)(9686003)(42186005)(55016002)(6306002)(50466002)(229853002)(54906002)(97736004)(81166006)(25786008)(93886004)(81156014)(33716001)(68736007)(2906002)(5660300001)(2870700001)(83506001)(6246003)(38730400002)(4001350100001)(23676002)(8676002)(110136004)(389900002)(189998001)(7736002)(533714002)(18370500001);DIR:OUT;SFP:1101;SCL:1;SRVR:DB6PR0802MB2390;H:leverpostej;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtEQjZQUjA4MDJNQjIzOTA7MjM6ZXo3L3pteHVtTW1HVnlLdW5jMm9OV1Nq?= =?utf-8?B?QVpUSkc4clFzUDZ1R3djWW1MUzlTQUhyaGRHdG5WWXJJVDA3TVgvOUN6OHBy?= =?utf-8?B?Nk5iMWd1djViVDRFNkZJSVpmTWt3VW1qQmdmQzdzc2FiVzNNZkpGNG12VmFw?= =?utf-8?B?Uk5EQTFqb1FkajdSa0Z1SXE1b0FYdE5ORHFmbVVuMFI2OHdwWGFGdWdQSnRS?= =?utf-8?B?Q2I5eWxLTDE1MW9NdHpaZC9SbmMwRXoySEd3Z0pzajVvSzBGWmdITE5zdUxu?= =?utf-8?B?di9ZQk1PTmlKREJacmJ6OFF4dkNWSllHS1NpSUg1RzdxejBJSGF1VEo4YXYv?= =?utf-8?B?T09QMkdUeThkeVVxSEppMjYxTHRncDIzcGlWMTZ3anZ5Q3YySEdFUTZWWW51?= =?utf-8?B?RHEwWWVWTG02OFlIQ0V5a3RuL2FabzRVL1c3czA2RWZaUHUyaEtoT0RWZ2dx?= =?utf-8?B?K25PaHRZT1d5K3BKcGZvbDNkSERxUTJ6Ri9QZGd5TXlWQW9nWXk0cEJCTzNq?= =?utf-8?B?MC8wSThrb0l4enJpSll3a2d3bU43aUxuVUM3d01Vc1FTWXF4dlM5RmpLK3l3?= =?utf-8?B?SkhRRHdyTmMrWkdWeTU4NGZMK2ZVckZhUzkwSkpMTGxnaUxDOVUwb0E5bU9N?= =?utf-8?B?NDQzZUZOVXNnYlR2ZHFRZzJTK1FDMEVKbW5ZMkRMbk12SmNKbisyU3l2TGY3?= =?utf-8?B?VWZRMDBjdnZqWHBtazFQN3NaQ3dUMGxMU2w5Uml6N2RIeDFYL3VOaHE3NUZT?= =?utf-8?B?bmdxbCtKTGxvN2lReUtreUVKWTNoK1gybDJUQlV3bFdKSjlzWGdmVkNwWlFJ?= =?utf-8?B?Qnl1NXN4bmFyQmRETlpSdzdPTE5MRnlwWFAvT1lkdGtKZ3VDdXJiUDNsKzV1?= =?utf-8?B?OWdsRmZxbG5YVE9PWCtHOGNVR0pTRUdIbmlpaVNUV0hlQXgxQm11cEIvT3NQ?= =?utf-8?B?WHZCNzN2UVVVU1M5bzdPRS9xcFM0ZmtZa3hGcDZ2Y0xBakp5MVJzVUhxQWpV?= =?utf-8?B?R1hIMWcyaUZiRmVZRnhMbzV6dFFhRlp2Rk0zcE12WDZxZEExemFQclZFZkVN?= =?utf-8?B?MlB4aG1VYjZIMmtOeERRczBXMXQwZGxYcGd6MVE1L0lrUnBpdUVMdmFJMEQ2?= =?utf-8?B?VXE5cml5MjNGSGR4aHpxYUdpTDRjeFoyNzFGTVkvWnFPeDFQUUt1ck45YWl0?= =?utf-8?B?aENwNWF5K0FzMUsrNklLazVFL2JDMTlQTk9QdVB2cnZCOEV2OXdoNzNwWlhE?= =?utf-8?B?K1NySVRsUWp5TzVXU2JZV1JpdU03ZUNuTlg0RmgzZ01KbTI5RGFRMkUwNkww?= =?utf-8?B?YUhyMHk1ZGViaTdSQlBKS3lzaXVnMGVhVmkwenVKcWxONzFjMStKOUdZd0Zl?= =?utf-8?B?ZnliS3pORUpIbm5CZ08xbDNxamd5NjRKcWhyb2FXaXhURUs3T0ZEMkNKbDZ3?= =?utf-8?B?NTBJU3VNUEQrYzhOME9UMTZCTVdxQkROdFFjcGo5dGwxdkllZ2xrU2IvV0pQ?= =?utf-8?B?UkY4emVabmQrUDdvdWZuKzhkMWNBa3VNN0pQSTFOTmlnQnpNWVBZY0N3a0tV?= =?utf-8?B?Q09qU1JmVVJZZDAvT24zYkZjb05mMFZoeDN0L1BtSlhqejFtWndwYVREV09G?= =?utf-8?B?d2NLZnNGaXdhZkczR1djTUx3U0s3OVdKVi9QM2RUNE9jUnNwcTN0WlFXbVZ0?= =?utf-8?B?bm9Zc0FoQVIwRWovS1diVWNqUXNYM3A4c3l1Z25zcmhHMkVnakNQb0UvZWJz?= =?utf-8?B?K1MvZDdlYjBPbzhGdmxyYWkweUwzUzBBendsODlHQkF0akdubkpYVkQ1dnor?= =?utf-8?B?ZDRZM2RGU1lGU3ZKT290SlovUW0zYkRaOU1Eb2M2b1pZeU9GT0NncktWcGoz?= =?utf-8?B?N3hCOG9MU3ZmYlM1Q3pHQndib1Rhd3puSE02OTVza0pFNk9UaURXTTZ4SkIw?= =?utf-8?B?RW14SWNPNEcxZDA4VlZkTEIva090NFZIMWRUMmVaWlNDei9YcWZpdmh2UGlG?= =?utf-8?B?VlNrMTl4aWNkNGpQNUl0TVJxZ3ZyWTlKQkRGRzBnPT0=?= X-Microsoft-Exchange-Diagnostics: 1;DB6PR0802MB2390;6:C0BF/dqFEI6WhdwxPiaQFrD8Mc6i3yJXD/a+PktsCuT6nBsdIhZbNh6umZuiLiUGSmjZAJxaJg8aTBGBR9bMZ9gIxRrVxzVnu6l7cQ7fbW4kWePW9LDpqaITzE0tc68BkW8c+5Zpwut7QhZ8u5rIWM1WAu45li2OehAq+rlkhEmdYUejthCTZM18dc2JqSxUoV7vorvoGTnyLj6qA/5uqPZPql0QsuzVRuNR1N6p4IRyEKN96UcgZ91oGdnGnrfMrfF4q/8vay0YZIimHUjTHzYUKe94WYXt/dPr0zuo4M2jzb+pa+l4rgHwGYwHNqxjJ14PqmUvaQcEzND3LF0VzUaZY+TTqzr4HtDZXn4Frn+97DvsJkX9Yphv9l8ACpfeiWk2srXAyyxEXDG/Gu3DYOGhbVDqVhUc8gNgc6vdAPg=;5:1YV6tgGu7w26iLa6HUlVT4Tz0JPi4aEzxqjN63YEc+l/uqYMhTiZMOXesu2IoC8QSGi8AxZpho9kllpMAiAQsuFunZJZmrXxRW0GoQ92Co1IUnODijg9zxsIOdn+IpLmQdUJOmJYuvCgojkAEzMfJg==;24:Usk/TANpXTQu3oqNZaQEJwgr2ekkCzpLvhCGEjvBB2JFaPWK3g5BblqvclqWRqAFrfoCAoou+ZTh6meV/3NwF+eTIxZRcNI2Rhu7yggizDM= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;DB6PR0802MB2390;7:teUWhSrkdMLSTUdtW65nPzFjDT4b6QaLvyRNn4K9UFck5hPx5QjW6gkFSeJz5cC8jvpe1gU7zQ9TV+5DMc1fG5LK4J/sSno+zWRlaOyFgv+qTEXcDmE1zzQzR8cV7Df8FF2iicfw+KbasQCxr2M+cUTGcqrNCJFyHOHJQt7aXaRt/vKSJrYDs+feDsBNEa4glIKbKu0Qx5M+SkDZNsLB0CPOC0gnoO1HPCoepTLF1qAyat+X57hhBfhRp9j81H6TEUWiOLaDPih60Jv+1ISq98JTDpx/bGgLMWtzDu3INIMm+NNBihiONvnVq4OGXixF1z7wuzEW1/MjUGMo0psZWFfI4lhwj/8+Q9dgkMicm01NZLlhltI581rY8FY60zOB3IO7PLlaiHp/1da1XWqaEGBwbgdWmoyGeMkeR74vo8M5+PsD0/v/WGzO9Xo4B1UrJTDXRpvOX/HQ3H+3/9NI69gpzBJR56WpPn+AWd3UqkzBNG6nyCbJ/cdhE2pyoXPmeJbyYtZgiodZfANJav6UUQ== X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Feb 2017 18:23:07.4437 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0802MB2390 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Wed, Feb 15, 2017 at 07:14:14PM +0100, Andreas Färber wrote: > Am 15.02.2017 um 18:12 schrieb Mark Rutland: > > On Wed, Feb 15, 2017 at 05:55:28PM +0100, Andreas Färber wrote: > >> + reserved-memory { > >> + #address-cells = <2>; > >> + #size-cells = <2>; > >> + ranges; > >> + }; > > > > Why have this empty node? > > Forgotten about... I see these: > > reserving fdt memory region: addr=19000000 size=3000000 > reserving fdt memory region: addr=20000000 size=20000000 > reserving fdt memory region: addr=18fff000 size=1000 > reserving fdt memory region: addr=1f000000 size=1000000 > > Vendor tree says 0x1f000000 is for secure monitor; 0x19000000 for fb, > 0x20000000 for ion (ignoring), and 0x20000000 for afinfo - whatever that > may be (not me! :)). > > So as minimum: > > --- a/arch/arm64/boot/dts/actions/s900.dtsi > +++ b/arch/arm64/boot/dts/actions/s900.dtsi > @@ -86,6 +86,11 @@ > #address-cells = <2>; > #size-cells = <2>; > ranges; > + > + secmon@1f000000 { > + reg = <0x0 0x1f000000 0x0 0x1000000>; > + no-map; > + }; > }; > > psci { Once you've added that node, could you try booting with "memtest" on the command line? Assuming CONFIG_MEMTEST is enabled, that'll go and verify that the kernel can access all of the (unresereved) memory without issues, which should save us lots of pain later on if there's something else that needs to be reserved. > >> + timer { > >> + compatible = "arm,armv8-timer"; > >> + interrupts = >> + (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_LOW)>, > >> + >> + (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_LOW)>, > >> + >> + (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_LOW)>, > >> + >> + (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_LOW)>; > >> + }; > >> + > >> + soc { > >> + compatible = "simple-bus"; > >> + #address-cells = <2>; > >> + #size-cells = <2>; > >> + ranges; > >> + > >> + gic: interrupt-controller@e00f1000 { > >> + compatible = "arm,gic-400"; > >> + reg = <0x0 0xe00f1000 0x0 0x1000>, > >> + <0x0 0xe00f2000 0x0 0x1000>, > >> + <0x0 0xe00f4000 0x0 0x2000>, > >> + <0x0 0xe00f6000 0x0 0x2000>; > > > > I believe that the second entry should be 0x2000 in length. > > The vendor tree does have 0x1000, but that might be a mistake of course. > I vaguely recall having such discussions elsewhere in the past. It is a mistake, and a common one [1] at that! :) Thanks, Mark. [1] http://lists.infradead.org/pipermail/linux-arm-kernel/2017-January/480590.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Rutland Subject: Re: [PATCH 11/11] ARM64: dts: Prepare Actions Semi S900 and Bubblegum-96 Date: Wed, 15 Feb 2017 18:23:03 +0000 Message-ID: <20170215182303.GL31733@leverpostej> References: <20170215165528.10052-1-afaerber@suse.de> <20170215165528.10052-12-afaerber@suse.de> <20170215171232.GI31733@leverpostej> <267b586e-06ce-f123-b7cc-dc0feb880ca9@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Return-path: Content-Disposition: inline In-Reply-To: <267b586e-06ce-f123-b7cc-dc0feb880ca9-l3A5Bk7waGM@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Andreas =?utf-8?Q?F=C3=A4rber?= Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, mp-cs-/sSyCTpAT0ql5r2w9Jh5Rg@public.gmane.org, info-Ty1hIZOCd2XuufBYgWm87A@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Rob Herring , Catalin Marinas , Will Deacon , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, nd-5wv7dgnIgG8@public.gmane.org List-Id: devicetree@vger.kernel.org Hi, On Wed, Feb 15, 2017 at 07:14:14PM +0100, Andreas Färber wrote: > Am 15.02.2017 um 18:12 schrieb Mark Rutland: > > On Wed, Feb 15, 2017 at 05:55:28PM +0100, Andreas Färber wrote: > >> + reserved-memory { > >> + #address-cells = <2>; > >> + #size-cells = <2>; > >> + ranges; > >> + }; > > > > Why have this empty node? > > Forgotten about... I see these: > > reserving fdt memory region: addr=19000000 size=3000000 > reserving fdt memory region: addr=20000000 size=20000000 > reserving fdt memory region: addr=18fff000 size=1000 > reserving fdt memory region: addr=1f000000 size=1000000 > > Vendor tree says 0x1f000000 is for secure monitor; 0x19000000 for fb, > 0x20000000 for ion (ignoring), and 0x20000000 for afinfo - whatever that > may be (not me! :)). > > So as minimum: > > --- a/arch/arm64/boot/dts/actions/s900.dtsi > +++ b/arch/arm64/boot/dts/actions/s900.dtsi > @@ -86,6 +86,11 @@ > #address-cells = <2>; > #size-cells = <2>; > ranges; > + > + secmon@1f000000 { > + reg = <0x0 0x1f000000 0x0 0x1000000>; > + no-map; > + }; > }; > > psci { Once you've added that node, could you try booting with "memtest" on the command line? Assuming CONFIG_MEMTEST is enabled, that'll go and verify that the kernel can access all of the (unresereved) memory without issues, which should save us lots of pain later on if there's something else that needs to be reserved. > >> + timer { > >> + compatible = "arm,armv8-timer"; > >> + interrupts = >> + (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_LOW)>, > >> + >> + (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_LOW)>, > >> + >> + (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_LOW)>, > >> + >> + (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_LOW)>; > >> + }; > >> + > >> + soc { > >> + compatible = "simple-bus"; > >> + #address-cells = <2>; > >> + #size-cells = <2>; > >> + ranges; > >> + > >> + gic: interrupt-controller@e00f1000 { > >> + compatible = "arm,gic-400"; > >> + reg = <0x0 0xe00f1000 0x0 0x1000>, > >> + <0x0 0xe00f2000 0x0 0x1000>, > >> + <0x0 0xe00f4000 0x0 0x2000>, > >> + <0x0 0xe00f6000 0x0 0x2000>; > > > > I believe that the second entry should be 0x2000 in length. > > The vendor tree does have 0x1000, but that might be a mistake of course. > I vaguely recall having such discussions elsewhere in the past. It is a mistake, and a common one [1] at that! :) Thanks, Mark. [1] http://lists.infradead.org/pipermail/linux-arm-kernel/2017-January/480590.html -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: mark.rutland@arm.com (Mark Rutland) Date: Wed, 15 Feb 2017 18:23:03 +0000 Subject: [PATCH 11/11] ARM64: dts: Prepare Actions Semi S900 and Bubblegum-96 In-Reply-To: <267b586e-06ce-f123-b7cc-dc0feb880ca9@suse.de> References: <20170215165528.10052-1-afaerber@suse.de> <20170215165528.10052-12-afaerber@suse.de> <20170215171232.GI31733@leverpostej> <267b586e-06ce-f123-b7cc-dc0feb880ca9@suse.de> Message-ID: <20170215182303.GL31733@leverpostej> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi, On Wed, Feb 15, 2017 at 07:14:14PM +0100, Andreas F?rber wrote: > Am 15.02.2017 um 18:12 schrieb Mark Rutland: > > On Wed, Feb 15, 2017 at 05:55:28PM +0100, Andreas F?rber wrote: > >> + reserved-memory { > >> + #address-cells = <2>; > >> + #size-cells = <2>; > >> + ranges; > >> + }; > > > > Why have this empty node? > > Forgotten about... I see these: > > reserving fdt memory region: addr=19000000 size=3000000 > reserving fdt memory region: addr=20000000 size=20000000 > reserving fdt memory region: addr=18fff000 size=1000 > reserving fdt memory region: addr=1f000000 size=1000000 > > Vendor tree says 0x1f000000 is for secure monitor; 0x19000000 for fb, > 0x20000000 for ion (ignoring), and 0x20000000 for afinfo - whatever that > may be (not me! :)). > > So as minimum: > > --- a/arch/arm64/boot/dts/actions/s900.dtsi > +++ b/arch/arm64/boot/dts/actions/s900.dtsi > @@ -86,6 +86,11 @@ > #address-cells = <2>; > #size-cells = <2>; > ranges; > + > + secmon at 1f000000 { > + reg = <0x0 0x1f000000 0x0 0x1000000>; > + no-map; > + }; > }; > > psci { Once you've added that node, could you try booting with "memtest" on the command line? Assuming CONFIG_MEMTEST is enabled, that'll go and verify that the kernel can access all of the (unresereved) memory without issues, which should save us lots of pain later on if there's something else that needs to be reserved. > >> + timer { > >> + compatible = "arm,armv8-timer"; > >> + interrupts = >> + (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_LOW)>, > >> + >> + (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_LOW)>, > >> + >> + (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_LOW)>, > >> + >> + (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_LOW)>; > >> + }; > >> + > >> + soc { > >> + compatible = "simple-bus"; > >> + #address-cells = <2>; > >> + #size-cells = <2>; > >> + ranges; > >> + > >> + gic: interrupt-controller at e00f1000 { > >> + compatible = "arm,gic-400"; > >> + reg = <0x0 0xe00f1000 0x0 0x1000>, > >> + <0x0 0xe00f2000 0x0 0x1000>, > >> + <0x0 0xe00f4000 0x0 0x2000>, > >> + <0x0 0xe00f6000 0x0 0x2000>; > > > > I believe that the second entry should be 0x2000 in length. > > The vendor tree does have 0x1000, but that might be a mistake of course. > I vaguely recall having such discussions elsewhere in the past. It is a mistake, and a common one [1] at that! :) Thanks, Mark. [1] http://lists.infradead.org/pipermail/linux-arm-kernel/2017-January/480590.html