Re: [PATCH 3/4] smiapp: Get clock rate if it's not available through DT

[kbuild test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 3066 bytes --]

Hi Sakari,

[auto build test WARNING on linus/master]
[also build test WARNING on v4.10-rc8]
[cannot apply to linuxtv-media/master next-20170215]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Sakari-Ailus/smiapp-cleanups-clock-control-changes/20170214-010429
config: x86_64-randconfig-it0-02160426 (attached as .config)
compiler: gcc-4.9 (Debian 4.9.4-2) 4.9.4
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All warnings (new ones prefixed by >>):

   drivers/media/i2c/smiapp/smiapp-core.c: In function 'smiapp_probe':
>> drivers/media/i2c/smiapp/smiapp-core.c:2909:6: warning: format '%lu' expects argument of type 'long unsigned int', but argument 3 has type 'uint32_t' [-Wformat=]
         sensor->hwcfg->ext_clk, rate);
         ^

vim +2909 drivers/media/i2c/smiapp/smiapp-core.c

88ea1579 Sakari Ailus 2017-02-13  2893  		if (sensor->hwcfg->ext_clk) {
88ea1579 Sakari Ailus 2017-02-13  2894  			unsigned long rate;
88ea1579 Sakari Ailus 2017-02-13  2895  
88ea1579 Sakari Ailus 2017-02-13  2896  			rval = clk_set_rate(sensor->ext_clk,
88ea1579 Sakari Ailus 2017-02-13  2897  					    sensor->hwcfg->ext_clk);
3ecb8664 Sakari Ailus 2016-09-12  2898  			if (rval < 0) {
3ecb8664 Sakari Ailus 2016-09-12  2899  				dev_err(&client->dev,
3ecb8664 Sakari Ailus 2016-09-12  2900  					"unable to set clock freq to %u\n",
3ecb8664 Sakari Ailus 2016-09-12  2901  					sensor->hwcfg->ext_clk);
3ecb8664 Sakari Ailus 2016-09-12  2902  				return rval;
3ecb8664 Sakari Ailus 2016-09-12  2903  			}
3ecb8664 Sakari Ailus 2016-09-12  2904  
87cb6c6a Sakari Ailus 2017-02-13  2905  			rate = clk_get_rate(sensor->ext_clk);
87cb6c6a Sakari Ailus 2017-02-13  2906  			if (rate != sensor->hwcfg->ext_clk) {
87cb6c6a Sakari Ailus 2017-02-13  2907  				dev_err(&client->dev,
88ea1579 Sakari Ailus 2017-02-13  2908  					"can't set clock freq, asked for %lu but got %lu\n",
87cb6c6a Sakari Ailus 2017-02-13 @2909  					sensor->hwcfg->ext_clk, rate);
87cb6c6a Sakari Ailus 2017-02-13  2910  				return rval;
87cb6c6a Sakari Ailus 2017-02-13  2911  			}
88ea1579 Sakari Ailus 2017-02-13  2912  		} else {
88ea1579 Sakari Ailus 2017-02-13  2913  			sensor->hwcfg->ext_clk = clk_get_rate(sensor->ext_clk);
88ea1579 Sakari Ailus 2017-02-13  2914  			dev_dbg(&client->dev, "obtained clock freq %u\n",
88ea1579 Sakari Ailus 2017-02-13  2915  				sensor->hwcfg->ext_clk);
88ea1579 Sakari Ailus 2017-02-13  2916  		}
88ea1579 Sakari Ailus 2017-02-13  2917  	} else if (sensor->hwcfg->ext_clk) {

:::::: The code at line 2909 was first introduced by commit
:::::: 87cb6c6a8fdcfc1d0327e6c826165f0ba1b5eff0 smiapp: Verify clock frequency after setting it, prevent changing it

:::::: TO: Sakari Ailus <sakari.ailus@linux.intel.com>
:::::: CC: 0day robot <fengguang.wu@intel.com>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 31202 bytes --]