From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753096AbdBPInK (ORCPT <rfc822;w@1wt.eu>);
        Thu, 16 Feb 2017 03:43:10 -0500
Received: from foss.arm.com ([217.140.101.70]:38728 "EHLO foss.arm.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1751583AbdBPInJ (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 16 Feb 2017 03:43:09 -0500
Date: Thu, 16 Feb 2017 08:43:06 +0000
From: Juri Lelli <juri.lelli@arm.com>
To: "byungchul.park" <byungchul.park@lge.com>
Cc: juri.lelli@gmail.com, peterz@infradead.org, mingo@kernel.org,
        linux-kernel@vger.kernel.org, kernel-team@lge.com,
        "'Steven Rostedt'" <rostedt@goodmis.org>
Subject: Re: [PATCH v3 2/2] sched/rt: Remove unnecessary condition in
 push_rt_task()
Message-ID: <20170216084306.GJ1368@e106622-lin>
References: <1487212457-28839-1-git-send-email-byungchul.park@lge.com>
 <1487212457-28839-2-git-send-email-byungchul.park@lge.com>
 <20170215214537.7936f336@grimm.local.home>
 <001801d28824$7f3f70f0$7dbe52d0$@lge.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <001801d28824$7f3f70f0$7dbe52d0$@lge.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi,

On 16/02/17 16:15, byungchul.park wrote:
> > -----Original Message-----
> > From: Steven Rostedt [mailto:rostedt@goodmis.org]
> > Sent: Thursday, February 16, 2017 11:46 AM
> > To: Byungchul Park
> > Cc: peterz@infradead.org; mingo@kernel.org; linux-kernel@vger.kernel.org;
> > juri.lelli@gmail.com; kernel-team@lge.com
> > Subject: Re: [PATCH v3 2/2] sched/rt: Remove unnecessary condition in
> > push_rt_task()
> > 
> > On Thu, 16 Feb 2017 11:34:17 +0900
> > Byungchul Park <byungchul.park@lge.com> wrote:
> > 
> > > pick_next_pushable_task(rq) has BUG_ON(rq_cpu != task_cpu(task)) when
> > > it returns a task other than NULL, which means that task_cpu(task) must
> > > be rq->cpu. So if task == next_task, then task_cpu(next_task) must be
> > > rq->cpu as well. Remove the redundant condition and make code simpler.
> > >
> > > By this patch, unnecessary one branch and two LOAD operations in 'if'
> > > statement can be avoided.
> > >
> > > Signed-off-by: Byungchul Park <byungchul.park@lge.com>
> > > Reviewed-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
> > > Reviewed-by: Juri Lelli <juri.lelli@arm.com>
> > > ---
> > 
> > This is a different patch, I don't believe Juri reviewed it yet.
> 
> Hello juri,
> 
> I should have asked you first and been more careful before I added
> 'reviewed-by'. Can I ask you for your opinion about the additional one?
> 

Looks good to me, you can leave my Reviewed-by.

Steve, thanks for pointing out that I didn't yet reviewed it. :)

Thanks,

- Juri