From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?utf-8?B?TWljaGHFgiBLxJlwaWXFhA==?= Subject: Re: [PATCH v2 0/6] Move dell-led to drivers/platform/x86 Date: Thu, 16 Feb 2017 10:33:11 +0100 Message-ID: <20170216093311.GB1350@ozzy.nask.waw.pl> References: <20170116132204.6421-1-kernel@kempniu.pl> <20170213112640.GA1188@ozzy.nask.waw.pl> <20170215135455.GA2014@ozzy.nask.waw.pl> <20170215151224.GF32000@pali> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: Content-Disposition: inline In-Reply-To: <20170215151224.GF32000@pali> Sender: platform-driver-x86-owner@vger.kernel.org To: Pali =?utf-8?B?Um9ow6Fy?= Cc: Alex Hung , Jaroslav Kysela , Takashi Iwai , Anthony Wong , Richard Purdie , Jacek Anaszewski , Pavel Machek , Darren Hart , Andy Shevchenko , Linux LED Subsystem , "platform-driver-x86@vger.kernel.org" , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org List-Id: linux-leds@vger.kernel.org > > >> 6. Compiled and installed Linux kernel 4.10 rc8 > > >> > > >> -> Microphone mute led does not work > > > > > > This is even more confusing. Between 4.9, which you claim works fine, > > > and 4.10-rc8, which you claim does not work, I can see no changes to > > > either drivers/leds/dell-led.c or sound/pci/hda/dell_wmi_helper.c. > > > Kernel configuration issue? > > > > I was surprised too, and I compiled it twice and installed on both > > Ubuntu 16.04 and 16.10. > > > > I would guess it is config too. On 4.9, it was using Ubuntu default. > > On 4.10rc8, I am pretty much using the instruction on > > https://wiki.ubuntu.com/KernelTeam/GitKernelBuild. The .config is > > available @ http://paste.ubuntu.com/24001113/ > > In Patch 6/6 is: Kconfig option is renamed from > CONFIG_LEDS_DELL_NETBOOKS to CONFIG_DELL_WMI_LED. > So you need to update your config for testing. I also thought about this, but CONFIG_DELL_WMI_LED is only needed to support the Dell Activity LED (present in the Dell Latitude 2100 netbook). Meanwhile, Alex is only testing the microphone mute LED, which requires CONFIG_DELL_LAPTOP to be enabled. The cover letter for this patch series provides a more thorough explanation. -- Best regards, Michał Kępień From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754175AbdBPJdT (ORCPT ); Thu, 16 Feb 2017 04:33:19 -0500 Received: from mail-lf0-f66.google.com ([209.85.215.66]:36083 "EHLO mail-lf0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753941AbdBPJdQ (ORCPT ); Thu, 16 Feb 2017 04:33:16 -0500 Date: Thu, 16 Feb 2017 10:33:11 +0100 From: =?utf-8?B?TWljaGHFgiBLxJlwaWXFhA==?= To: Pali =?utf-8?B?Um9ow6Fy?= Cc: Alex Hung , Jaroslav Kysela , Takashi Iwai , Anthony Wong , Richard Purdie , Jacek Anaszewski , Pavel Machek , Darren Hart , Andy Shevchenko , Linux LED Subsystem , "platform-driver-x86@vger.kernel.org" , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 0/6] Move dell-led to drivers/platform/x86 Message-ID: <20170216093311.GB1350@ozzy.nask.waw.pl> References: <20170116132204.6421-1-kernel@kempniu.pl> <20170213112640.GA1188@ozzy.nask.waw.pl> <20170215135455.GA2014@ozzy.nask.waw.pl> <20170215151224.GF32000@pali> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20170215151224.GF32000@pali> User-Agent: Mutt/1.7.2 (2016-11-26) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > > >> 6. Compiled and installed Linux kernel 4.10 rc8 > > >> > > >> -> Microphone mute led does not work > > > > > > This is even more confusing. Between 4.9, which you claim works fine, > > > and 4.10-rc8, which you claim does not work, I can see no changes to > > > either drivers/leds/dell-led.c or sound/pci/hda/dell_wmi_helper.c. > > > Kernel configuration issue? > > > > I was surprised too, and I compiled it twice and installed on both > > Ubuntu 16.04 and 16.10. > > > > I would guess it is config too. On 4.9, it was using Ubuntu default. > > On 4.10rc8, I am pretty much using the instruction on > > https://wiki.ubuntu.com/KernelTeam/GitKernelBuild. The .config is > > available @ http://paste.ubuntu.com/24001113/ > > In Patch 6/6 is: Kconfig option is renamed from > CONFIG_LEDS_DELL_NETBOOKS to CONFIG_DELL_WMI_LED. > So you need to update your config for testing. I also thought about this, but CONFIG_DELL_WMI_LED is only needed to support the Dell Activity LED (present in the Dell Latitude 2100 netbook). Meanwhile, Alex is only testing the microphone mute LED, which requires CONFIG_DELL_LAPTOP to be enabled. The cover letter for this patch series provides a more thorough explanation. -- Best regards, Michał Kępień