From mboxrd@z Thu Jan 1 00:00:00 1970 From: Russell King - ARM Linux Subject: Re: [PATCH v3 1/3] ARM: l2c: allow CA9 optimizations to be disabled Date: Thu, 16 Feb 2017 16:06:19 +0000 Message-ID: <20170216160619.GQ27312@n2100.armlinux.org.uk> References: <20170216153726.22919-1-chris.brandt@renesas.com> <20170216153726.22919-2-chris.brandt@renesas.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20170216153726.22919-2-chris.brandt-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Chris Brandt Cc: Simon Horman , Magnus Damm , Geert Uytterhoeven , Rob Herring , Mark Rutland , Brad Mouring , Andrey Smirnov , Arnd Bergmann , Richard Cochran , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-renesas-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: devicetree@vger.kernel.org On Thu, Feb 16, 2017 at 10:37:24AM -0500, Chris Brandt wrote: > diff --git a/arch/arm/mm/cache-l2x0.c b/arch/arm/mm/cache-l2x0.c > index 2290be3..486cc6d 100644 > --- a/arch/arm/mm/cache-l2x0.c > +++ b/arch/arm/mm/cache-l2x0.c > @@ -57,6 +57,9 @@ static unsigned long sync_reg_offset = L2X0_CACHE_SYNC; > > struct l2x0_regs l2x0_saved_regs; > > +static bool l2x0_bresp_dis; > +static bool l2x0_flz_dis; Please use full "disable" here. Thanks. -- RMK's Patch system: http://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up according to speedtest.net. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from pandora.armlinux.org.uk ([78.32.30.218]:41848 "EHLO pandora.armlinux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754841AbdBPQGo (ORCPT ); Thu, 16 Feb 2017 11:06:44 -0500 Date: Thu, 16 Feb 2017 16:06:19 +0000 From: Russell King - ARM Linux To: Chris Brandt Cc: Simon Horman , Magnus Damm , Geert Uytterhoeven , Rob Herring , Mark Rutland , Brad Mouring , Andrey Smirnov , Arnd Bergmann , Richard Cochran , devicetree@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v3 1/3] ARM: l2c: allow CA9 optimizations to be disabled Message-ID: <20170216160619.GQ27312@n2100.armlinux.org.uk> References: <20170216153726.22919-1-chris.brandt@renesas.com> <20170216153726.22919-2-chris.brandt@renesas.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170216153726.22919-2-chris.brandt@renesas.com> Sender: linux-renesas-soc-owner@vger.kernel.org List-ID: On Thu, Feb 16, 2017 at 10:37:24AM -0500, Chris Brandt wrote: > diff --git a/arch/arm/mm/cache-l2x0.c b/arch/arm/mm/cache-l2x0.c > index 2290be3..486cc6d 100644 > --- a/arch/arm/mm/cache-l2x0.c > +++ b/arch/arm/mm/cache-l2x0.c > @@ -57,6 +57,9 @@ static unsigned long sync_reg_offset = L2X0_CACHE_SYNC; > > struct l2x0_regs l2x0_saved_regs; > > +static bool l2x0_bresp_dis; > +static bool l2x0_flz_dis; Please use full "disable" here. Thanks. -- RMK's Patch system: http://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up according to speedtest.net. From mboxrd@z Thu Jan 1 00:00:00 1970 From: linux@armlinux.org.uk (Russell King - ARM Linux) Date: Thu, 16 Feb 2017 16:06:19 +0000 Subject: [PATCH v3 1/3] ARM: l2c: allow CA9 optimizations to be disabled In-Reply-To: <20170216153726.22919-2-chris.brandt@renesas.com> References: <20170216153726.22919-1-chris.brandt@renesas.com> <20170216153726.22919-2-chris.brandt@renesas.com> Message-ID: <20170216160619.GQ27312@n2100.armlinux.org.uk> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Thu, Feb 16, 2017 at 10:37:24AM -0500, Chris Brandt wrote: > diff --git a/arch/arm/mm/cache-l2x0.c b/arch/arm/mm/cache-l2x0.c > index 2290be3..486cc6d 100644 > --- a/arch/arm/mm/cache-l2x0.c > +++ b/arch/arm/mm/cache-l2x0.c > @@ -57,6 +57,9 @@ static unsigned long sync_reg_offset = L2X0_CACHE_SYNC; > > struct l2x0_regs l2x0_saved_regs; > > +static bool l2x0_bresp_dis; > +static bool l2x0_flz_dis; Please use full "disable" here. Thanks. -- RMK's Patch system: http://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up according to speedtest.net.