All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Derek Robson <robsonde@gmail.com>
Cc: binoy.jayan@linaro.org, devel@driverdev.osuosl.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 01/15] Staging: rtl8192u: ieee80211: ieee80211_wx.c - style fix
Date: Thu, 16 Feb 2017 10:38:29 -0800	[thread overview]
Message-ID: <20170216183829.GA12340@kroah.com> (raw)
In-Reply-To: <f2df0dc2ab4acd6fc93ea419ab58585dfdfb3ad5.1487222627.git.robsonde@gmail.com>

On Thu, Feb 16, 2017 at 06:30:51PM +1300, Derek Robson wrote:
> Fixed style of block comments
> Found using checkpatch
> 
> Signed-off-by: Derek Robson <robsonde@gmail.com>
> ---
>  drivers/staging/rtl8192u/ieee80211/ieee80211_wx.c | 87 ++++++++++++-----------
>  1 file changed, 47 insertions(+), 40 deletions(-)
> 
> diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_wx.c b/drivers/staging/rtl8192u/ieee80211/ieee80211_wx.c
> index 563d7fed6e1c..0d24158e038a 100644
> --- a/drivers/staging/rtl8192u/ieee80211/ieee80211_wx.c
> +++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_wx.c
> @@ -1,34 +1,34 @@
>  /******************************************************************************
> -
> -  Copyright(c) 2004 Intel Corporation. All rights reserved.
> -
> -  Portions of this file are based on the WEP enablement code provided by the
> -  Host AP project hostap-drivers v0.1.3
> -  Copyright (c) 2001-2002, SSH Communications Security Corp and Jouni Malinen
> -  <jkmaline@cc.hut.fi>
> -  Copyright (c) 2002-2003, Jouni Malinen <jkmaline@cc.hut.fi>
> -
> -  This program is free software; you can redistribute it and/or modify it
> -  under the terms of version 2 of the GNU General Public License as
> -  published by the Free Software Foundation.
> -
> -  This program is distributed in the hope that it will be useful, but WITHOUT
> -  ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
> -  FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License for
> -  more details.
> -
> -  You should have received a copy of the GNU General Public License along with
> -  this program; if not, write to the Free Software Foundation, Inc., 59
> -  Temple Place - Suite 330, Boston, MA  02111-1307, USA.
> -
> -  The full GNU General Public License is included in this distribution in the
> -  file called LICENSE.
> -
> -  Contact Information:
> -  James P. Ketrenos <ipw2100-admin@linux.intel.com>
> -  Intel Corporation, 5200 N.E. Elam Young Parkway, Hillsboro, OR 97124-6497
> -
> -******************************************************************************/
> + *
> + *  Copyright(c) 2004 Intel Corporation. All rights reserved.
> + *
> + *  Portions of this file are based on the WEP enablement code provided by the
> + *  Host AP project hostap-drivers v0.1.3
> + *  Copyright (c) 2001-2002, SSH Communications Security Corp and Jouni Malinen
> + *  <jkmaline@cc.hut.fi>
> + *  Copyright (c) 2002-2003, Jouni Malinen <jkmaline@cc.hut.fi>
> + *
> + *  This program is free software; you can redistribute it and/or modify it
> + *  under the terms of version 2 of the GNU General Public License as
> + *  published by the Free Software Foundation.
> + *
> + *  This program is distributed in the hope that it will be useful, but WITHOUT
> + *  ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
> + *  FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License for
> + *  more details.
> + *
> + *  You should have received a copy of the GNU General Public License along with
> + *  this program; if not, write to the Free Software Foundation, Inc., 59
> + *  Temple Place - Suite 330, Boston, MA  02111-1307, USA.
> + *
> + *  The full GNU General Public License is included in this distribution in the
> + *  file called LICENSE.
> + *
> + *  Contact Information:
> + *  James P. Ketrenos <ipw2100-admin@linux.intel.com>
> + *  Intel Corporation, 5200 N.E. Elam Young Parkway, Hillsboro, OR 97124-6497
> + *
> + ******************************************************************************/
>  #include <linux/wireless.h>
>  #include <linux/kmod.h>
>  #include <linux/slab.h>
> @@ -108,7 +108,8 @@ static inline char *rtl819x_translate_scan(struct ieee80211_device *ieee,
>  	/* Add frequency/channel */
>  	iwe.cmd = SIOCGIWFREQ;
>  /*	iwe.u.freq.m = ieee80211_frequency(network->channel, network->mode);
> -	iwe.u.freq.e = 3; */
> + *	iwe.u.freq.e = 3;
> + */

Just delete commented out code, no need to go and make it "pretty".

Same thing for a number of the patches in this series.

thanks,

greg k-h

  reply	other threads:[~2017-02-16 18:38 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-16  5:30 [PATCH 00/15] Staging: rtl8192u - fixed block comments Derek Robson
2017-02-16  5:30 ` [PATCH 01/15] Staging: rtl8192u: ieee80211: ieee80211_wx.c - style fix Derek Robson
2017-02-16 18:38   ` Greg KH [this message]
2017-02-16  5:31 ` [PATCH 02/15] Staging: rtl8192u: r819xU_cmdpkt.c " Derek Robson
2017-02-16  5:31 ` [PATCH 03/15] Staging: rtl8192u: r8192U_dm.c " Derek Robson
2017-02-16  5:31 ` [PATCH 04/15] Staging: rtl8192u: r8192U_core.c " Derek Robson
2017-02-16  5:32 ` [PATCH 05/15] Staging: rtl8192u: r8192U.h " Derek Robson
2017-02-16  5:32 ` [PATCH 06/15] Staging: rtl8192u: ieee80211: rtl819x_TSProc.c " Derek Robson
2017-02-16  5:32 ` [PATCH 07/15] Staging: rtl8192u: ieee80211: ieee80211_softmac.c " Derek Robson
2017-02-16  5:32 ` [PATCH 08/15] Staging: rtl8192u: ieee80211: ieee80211_module.c " Derek Robson
2017-02-16  5:32 ` [PATCH 09/15] Staging: rtl8192u: ieee80211: rtl819x_HTProc.c " Derek Robson
2017-02-16  5:33 ` [PATCH 10/15] Staging: rtl8192u: ieee80211: rtl819x_BAProc.c " Derek Robson
2017-02-16  5:33 ` [PATCH 11/15] Staging: rtl8192u: ieee80211: rtl819x_HT.h " Derek Robson
2017-02-16 18:40   ` Greg KH
2017-02-16  5:33 ` [PATCH 12/15] Staging: rtl8192u: ieee80211: rtl819x_BA.h " Derek Robson
2017-02-16 18:40   ` Greg KH
2017-02-16  5:33 ` [PATCH 13/15] Staging: rtl8192u: ieee80211: ieee80211_tx.c " Derek Robson
2017-02-16  5:34 ` [PATCH 14/15] Staging: rtl8192u: ieee80211: ieee80211_rx.c " Derek Robson
2017-02-16  5:34 ` [PATCH 15/15] Staging: rtl8192u: ieee80211: ieee80211.h " Derek Robson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170216183829.GA12340@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=binoy.jayan@linaro.org \
    --cc=devel@driverdev.osuosl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robsonde@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.