All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: netdev@vger.kernel.org, tariqt@mellanox.com, saeedm@mellanox.com
Subject: Re: [PATCH net-next] mlx4: do not fire tasklet unless necessary
Date: Fri, 17 Feb 2017 10:55:54 -0500 (EST)	[thread overview]
Message-ID: <20170217.105554.1471478837157578274.davem@davemloft.net> (raw)
In-Reply-To: <1486729678.7793.139.camel@edumazet-glaptop3.roam.corp.google.com>

From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Fri, 10 Feb 2017 04:27:58 -0800

> From: Eric Dumazet <edumazet@google.com>
> 
> All rx and rx netdev interrupts are handled by respectively
> by mlx4_en_rx_irq() and mlx4_en_tx_irq() which simply schedule a NAPI.
> 
> But mlx4_eq_int() also fires a tasklet to service all items that were
> queued via mlx4_add_cq_to_tasklet(), but this handler was not called
> unless user cqe was handled.
> 
> This is very confusing, as "mpstat -I SCPU ..." show huge number of
> tasklet invocations.
> 
> This patch saves this overhead, by carefully firing the tasklet directly
> from mlx4_add_cq_to_tasklet(), removing four atomic operations per IRQ.
> 
> Signed-off-by: Eric Dumazet <edumazet@google.com>

Applied, thanks.

      parent reply	other threads:[~2017-02-17 15:56 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-10 12:27 [PATCH net-next] mlx4: do not fire tasklet unless necessary Eric Dumazet
2017-02-14 16:29 ` David Miller
2017-02-15 11:10 ` Saeed Mahameed
2017-02-15 13:29   ` Eric Dumazet
2017-02-15 13:59     ` Saeed Mahameed
2017-02-15 14:34       ` Eric Dumazet
2017-02-15 14:04     ` Eric Dumazet
2017-02-16 12:44       ` Saeed Mahameed
2017-02-16 15:49         ` Eric Dumazet
2017-02-16 21:17           ` Saeed Mahameed
2017-02-16 23:13             ` Eric Dumazet
2017-02-16 23:23               ` [PATCH net] mlx4: fix potential divide by 0 in mlx4_en_auto_moderation() Eric Dumazet
2017-02-19 22:21                 ` Saeed Mahameed
2017-02-19 22:33               ` [PATCH net-next] mlx4: do not fire tasklet unless necessary Saeed Mahameed
2017-02-15 14:52   ` Matan Barak (External)
2017-02-15 15:26     ` Eric Dumazet
2017-02-16 12:34       ` Saeed Mahameed
2017-02-16 12:38 ` Saeed Mahameed
2017-02-16 15:30   ` Eric Dumazet
2017-02-18  2:46     ` Eric Dumazet
2017-02-19 22:39       ` Saeed Mahameed
2017-02-17 15:55 ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170217.105554.1471478837157578274.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=eric.dumazet@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=saeedm@mellanox.com \
    --cc=tariqt@mellanox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.