From: Yinghai Lu <yinghai@kernel.org>
To: Bjorn Helgaas <bhelgaas@google.com>
Cc: Mika Westerberg <mika.westerberg@linux.intel.com>,
Keith Busch <keith.busch@intel.com>,
Mayurkumar Patel <mayurkumar.patel@intel.com>,
Ashok Raj <ashok.raj@intel.com>,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
Yinghai Lu <yinghai@kernel.org>
Subject: [PATCH] PCI,pciehp: Don't handle PDC for cards with attention button
Date: Thu, 16 Feb 2017 22:12:47 -0800 [thread overview]
Message-ID: <20170217061247.5591-1-yinghai@kernel.org> (raw)
On one system during power off slot, find card get power on right away.
# echo 0 > /sys/bus/pci/slots/1/power
pci_hotplug: power_write_file: power = 0
pciehp 0000:16:00.0:pcie004: pciehp_get_power_status: SLOTCTRL a8 value read 11f1
pciehp 0000:16:00.0:pcie004: pciehp_unconfigure_device: domain:bus:dev = 0000:17:00
pci 0000:17:00.0: PME# disabled
pci 0000:17:00.0: freeing pci_dev info
pciehp 0000:16:00.0:pcie004: pending interrupts 0x0010 from Slot Status
pciehp 0000:16:00.0:pcie004: pciehp_power_off_slot: SLOTCTRL a8 write cmd 400
pciehp 0000:16:00.0:pcie004: pending interrupts 0x0108 from Slot Status
pciehp 0000:16:00.0:pcie004: Slot(1): Link Down
pciehp 0000:16:00.0:pcie004: Slot(1): Link Down event ignored; already powering off
pciehp 0000:16:00.0:pcie004: pciehp_green_led_off: SLOTCTRL a8 write cmd 300
pciehp 0000:16:00.0:pcie004: pending interrupts 0x0018 from Slot Status <======
pciehp 0000:16:00.0:pcie004: Slot(1): Card present
pciehp 0000:16:00.0:pcie004: pciehp_get_power_status: SLOTCTRL a8 value read 17f1
pciehp 0000:16:00.0:pcie004: pending interrupts 0x0010 from Slot Status
pciehp 0000:16:00.0:pcie004: pciehp_power_on_slot: SLOTCTRL a8 write cmd 0
pciehp 0000:16:00.0:pcie004: pciehp_green_led_blink: SLOTCTRL a8 write cmd 200
pciehp 0000:16:00.0:pcie004: pending interrupts 0x0010 from Slot Status
pciehp 0000:16:00.0:pcie004: pciehp_check_link_active: lnk_status = f103
pciehp 0000:16:00.0:pcie004: pending interrupts 0x0108 from Slot Status
pciehp 0000:16:00.0:pcie004: Slot(1): Link Up
...
Somehow PDC bit get set, and during handling interrupt that is caused by
CC, that PDC also get handled, and the card get powered on again.
In pcie_enable_notification(), we already only enable notification
for PDC when attention button is not there.
So we can safely add checking in pciehp_isr() to skip that PDC handling.
Signed-off-by: Yinghai Lu <yinghai@kernel.org>
---
drivers/pci/hotplug/pciehp_hpc.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
Index: linux-2.6/drivers/pci/hotplug/pciehp_hpc.c
===================================================================
--- linux-2.6.orig/drivers/pci/hotplug/pciehp_hpc.c
+++ linux-2.6/drivers/pci/hotplug/pciehp_hpc.c
@@ -618,8 +618,9 @@ static irqreturn_t pciehp_isr(int irq, v
present = !!(status & PCI_EXP_SLTSTA_PDS);
ctrl_info(ctrl, "Slot(%s): Card %spresent\n", slot_name(slot),
present ? "" : "not ");
- pciehp_queue_interrupt_event(slot, present ? INT_PRESENCE_ON :
- INT_PRESENCE_OFF);
+ if (!ATTN_BUTTN(ctrl))
+ pciehp_queue_interrupt_event(slot, present ?
+ INT_PRESENCE_ON : INT_PRESENCE_OFF);
}
/* Check Power Fault Detected */
next reply other threads:[~2017-02-17 6:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-17 6:12 Yinghai Lu [this message]
2017-02-17 17:40 ` [PATCH] PCI,pciehp: Don't handle PDC for cards with attention button Raj, Ashok
2017-02-17 18:56 ` Yinghai Lu
2017-02-17 22:39 ` Bjorn Helgaas
2017-02-17 23:36 ` Yinghai Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170217061247.5591-1-yinghai@kernel.org \
--to=yinghai@kernel.org \
--cc=ashok.raj@intel.com \
--cc=bhelgaas@google.com \
--cc=keith.busch@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mayurkumar.patel@intel.com \
--cc=mika.westerberg@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.