All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mariusz Bialonczyk <manio@skyboo.net>
To: linux-kernel@vger.kernel.org, Evgeniy Polyakov <zbr@ioremap.net>
Subject: Re: [PATCH 1/4] Documentation: w1_therm: clearly state about binary value for precision
Date: Fri, 17 Feb 2017 09:54:41 +0100	[thread overview]
Message-ID: <20170217095441.ceb0b055a2a967ff6c857b50@skyboo.net> (raw)
In-Reply-To: <20170216090539.7049-1-manio@skyboo.net>

On Thu, 16 Feb 2017 10:05:36 +0100
Mariusz Bialonczyk <manio@skyboo.net> wrote:

> Signed-off-by: Mariusz Bialonczyk <manio@skyboo.net>
> ---
>  Documentation/w1/slaves/w1_therm | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/w1/slaves/w1_therm b/Documentation/w1/slaves/w1_therm
> index d1f93af..e10cd91 100644
> --- a/Documentation/w1/slaves/w1_therm
> +++ b/Documentation/w1/slaves/w1_therm
> @@ -42,6 +42,7 @@ SRAM, so it is reset when the sensor gets power-cycled.
>  To store the current precision configuration into EEPROM, the value 0
>  has to be written to the sysfs w1_slave file. Since the EEPROM has a limited
>  amount of writes (>50k), this command should be used wisely.
> +Note: this precision value has to be a binary one-byte value, not ASCII.
>  
>  The module parameter strong_pullup can be set to 0 to disable the
>  strong pullup, 1 to enable autodetection or 2 to force strong pullup.
> -- 
> 2.9.3
> 

Please skip this single patch. I was wrong about it.
w1_slave_store is using kstrtoint() so it is currently ok.

regards,
-- 
Mariusz Białończyk | xmpp/e-mail: manio@skyboo.net
http://manio.skyboo.net | https://github.com/manio

      parent reply	other threads:[~2017-02-17  8:54 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-16  9:05 [PATCH 1/4] Documentation: w1_therm: clearly state about binary value for precision Mariusz Bialonczyk
2017-02-16  9:05 ` [PATCH 2/4] w1: add missing DS2413 documentation Mariusz Bialonczyk
2017-02-16  9:05 ` [PATCH 3/4] w1: add support for DS2438 Smart Battery Monitor Mariusz Bialonczyk
2017-02-16  9:05 ` [PATCH 4/4] w1: add documentation for w1_ds2438 Mariusz Bialonczyk
2017-02-17  8:54 ` Mariusz Bialonczyk [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170217095441.ceb0b055a2a967ff6c857b50@skyboo.net \
    --to=manio@skyboo.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=zbr@ioremap.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.