From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S933876AbdBQJzC convert rfc822-to-8bit (ORCPT <rfc822;w@1wt.eu>);
        Fri, 17 Feb 2017 04:55:02 -0500
Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:59186 "EHLO
        mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK)
        by vger.kernel.org with ESMTP id S933923AbdBQJxE (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 17 Feb 2017 04:53:04 -0500
Date: Fri, 17 Feb 2017 10:52:53 +0100
From: Cornelia Huck <cornelia.huck@de.ibm.com>
To: Andrew Jones <drjones@redhat.com>
Cc: Radim =?UTF-8?B?S3LEjW3DocWZ?= <rkrcmar@redhat.com>,
        linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
        Paolo Bonzini <pbonzini@redhat.com>,
        Marc Zyngier <marc.zyngier@arm.com>,
        Christian Borntraeger <borntraeger@de.ibm.com>,
        James Hogan <james.hogan@imgtec.com>,
        Paul Mackerras <paulus@ozlabs.org>,
        Christoffer Dall <christoffer.dall@linaro.org>
Subject: Re: [PATCH 1/5] KVM: change API for requests to match bit
 operations
In-Reply-To: <20170217094935.u7ne57y7ko6h2mnz@kamzik.brq.redhat.com>
References: <20170216160449.13094-1-rkrcmar@redhat.com>
        <20170216160449.13094-2-rkrcmar@redhat.com>
        <20170217103014.5ada1f1c.cornelia.huck@de.ibm.com>
        <20170217094935.u7ne57y7ko6h2mnz@kamzik.brq.redhat.com>
Organization: IBM Deutschland Research & Development GmbH Vorsitzende des
 Aufsichtsrats: Martina Koederitz =?UTF-8?B?R2VzY2jDpGZ0c2bDvGhydW5nOg==?=
 Dirk Wittkopp Sitz der Gesellschaft: =?UTF-8?B?QsO2Ymxpbmdlbg==?=
 Registergericht: Amtsgericht Stuttgart, HRB 243294
X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.23; x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8BIT
X-TM-AS-GCONF: 00
X-Content-Scanned: Fidelis XPS MAILER
x-cbid: 17021709-0040-0000-0000-00000349E36C
X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused
x-cbparentid: 17021709-0041-0000-0000-00001EEF3E08
Message-Id: <20170217105253.12ce475d.cornelia.huck@de.ibm.com>
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-02-17_08:,,
 signatures=0
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0
 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam
 adjust=0 reason=mlx scancount=1 engine=8.0.1-1612050000
 definitions=main-1702170094
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, 17 Feb 2017 10:49:35 +0100
Andrew Jones <drjones@redhat.com> wrote:

> On Fri, Feb 17, 2017 at 10:30:14AM +0100, Cornelia Huck wrote:
> > On Thu, 16 Feb 2017 17:04:45 +0100
> > Radim Krčmář <rkrcmar@redhat.com> wrote:
> > > +static inline void kvm_request_set(unsigned req, struct kvm_vcpu *vcpu)
> > 
> > Should we make req unsigned long as well, so that it matches the bit
> > api even more?
> 
> The bitops API is inconsistent among architectures; some are int, some
> are unsigned int, some are unsigned long, and x86 is long. If we want
> to be consistent with something, then, IMO, we should be consistent with
> asm-generic/bitops, which is int, but actually unsigned makes more sense
> to me...

Inconsistent interfaces are great :/

Having (any) unsigned value makes the most sense to me as well.