From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from bombadil.infradead.org ([65.50.211.133]:59106 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933787AbdBQM7z (ORCPT ); Fri, 17 Feb 2017 07:59:55 -0500 From: Christoph Hellwig To: scott.bauer@intel.com, keith.busch@intel.com, jonathan.derrick@intel.com, axboe@fb.com Cc: linux-block@vger.kernel.org, linux-nvme@lists.infradead.org Subject: [PATCH 1/4] block/sed-opal: tone down not supported warnings Date: Fri, 17 Feb 2017 13:59:38 +0100 Message-Id: <20170217125941.14319-2-hch@lst.de> In-Reply-To: <20170217125941.14319-1-hch@lst.de> References: <20170217125941.14319-1-hch@lst.de> Sender: linux-block-owner@vger.kernel.org List-Id: linux-block@vger.kernel.org Not having OPAL or a sub-feature supported is an entirely normal condition for many drives, so don't warn about it. Keep the messages, but tone them down to debug only. Signed-off-by: Christoph Hellwig Reviewed-by: Scott Bauer --- block/sed-opal.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/block/sed-opal.c b/block/sed-opal.c index e95b8a57053d..bcdd5b6d02e8 100644 --- a/block/sed-opal.c +++ b/block/sed-opal.c @@ -387,16 +387,16 @@ static int opal_discovery0_end(struct opal_dev *dev) } if (!supported) { - pr_err("This device is not Opal enabled. Not Supported!\n"); + pr_debug("This device is not Opal enabled. Not Supported!\n"); return -EOPNOTSUPP; } if (!single_user) - pr_warn("Device doesn't support single user mode\n"); + pr_debug("Device doesn't support single user mode\n"); if (!found_com_id) { - pr_warn("Could not find OPAL comid for device. Returning early\n"); + pr_debug("Could not find OPAL comid for device. Returning early\n"); return -EOPNOTSUPP;; } @@ -1951,7 +1951,7 @@ void init_opal_dev(struct opal_dev *opal_dev, sec_send_recv *send_recv) mutex_init(&opal_dev->dev_lock); opal_dev->send_recv = send_recv; if (check_opal_support(opal_dev) < 0) - pr_warn("Opal is not supported on this device\n"); + pr_debug("Opal is not supported on this device\n"); opal_dev->initialized = true; } EXPORT_SYMBOL(init_opal_dev); -- 2.11.0 From mboxrd@z Thu Jan 1 00:00:00 1970 From: hch@lst.de (Christoph Hellwig) Date: Fri, 17 Feb 2017 13:59:38 +0100 Subject: [PATCH 1/4] block/sed-opal: tone down not supported warnings In-Reply-To: <20170217125941.14319-1-hch@lst.de> References: <20170217125941.14319-1-hch@lst.de> Message-ID: <20170217125941.14319-2-hch@lst.de> Not having OPAL or a sub-feature supported is an entirely normal condition for many drives, so don't warn about it. Keep the messages, but tone them down to debug only. Signed-off-by: Christoph Hellwig Reviewed-by: Scott Bauer --- block/sed-opal.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/block/sed-opal.c b/block/sed-opal.c index e95b8a57053d..bcdd5b6d02e8 100644 --- a/block/sed-opal.c +++ b/block/sed-opal.c @@ -387,16 +387,16 @@ static int opal_discovery0_end(struct opal_dev *dev) } if (!supported) { - pr_err("This device is not Opal enabled. Not Supported!\n"); + pr_debug("This device is not Opal enabled. Not Supported!\n"); return -EOPNOTSUPP; } if (!single_user) - pr_warn("Device doesn't support single user mode\n"); + pr_debug("Device doesn't support single user mode\n"); if (!found_com_id) { - pr_warn("Could not find OPAL comid for device. Returning early\n"); + pr_debug("Could not find OPAL comid for device. Returning early\n"); return -EOPNOTSUPP;; } @@ -1951,7 +1951,7 @@ void init_opal_dev(struct opal_dev *opal_dev, sec_send_recv *send_recv) mutex_init(&opal_dev->dev_lock); opal_dev->send_recv = send_recv; if (check_opal_support(opal_dev) < 0) - pr_warn("Opal is not supported on this device\n"); + pr_debug("Opal is not supported on this device\n"); opal_dev->initialized = true; } EXPORT_SYMBOL(init_opal_dev); -- 2.11.0