From mboxrd@z Thu Jan 1 00:00:00 1970 From: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= Subject: Re: [PATCH] drm/i915: Fix legacy cursor vs. watermarks for ILK-BDW Date: Fri, 17 Feb 2017 21:04:44 +0100 Message-ID: <20170217200443.vg2yba6rx5sysy37@perseus.defre.kleine-koenig.org> References: <0b3c8b9e-58c2-6efd-1dcd-2a78462ddff7@kleine-koenig.org> <20170217150159.11683-1-ville.syrjala@linux.intel.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1882104458==" Return-path: Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4285A6EDC6 for ; Fri, 17 Feb 2017 20:04:52 +0000 (UTC) In-Reply-To: <20170217150159.11683-1-ville.syrjala@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: ville.syrjala@linux.intel.com Cc: Daniel Vetter , intel-gfx@lists.freedesktop.org, Martin Peres List-Id: intel-gfx@lists.freedesktop.org --===============1882104458== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="xasor4dq5bjhuzts" Content-Disposition: inline --xasor4dq5bjhuzts Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hello Ville, On Fri, Feb 17, 2017 at 05:01:59PM +0200, ville.syrjala@linux.intel.com wro= te: > From: Ville Syrj=E4l=E4 >=20 > In order to make cursor updates actually safe wrt. watermark programming > we have to clear the legacy_cursor_update flag in the atomic state. That > will cause the regular atomic update path to do the necessary vblank > wait after the plane update if needed, otherwise the vblank wait would > be skipped and we'd feed the optimal watermarks to the hardware before > the plane update has actually happened. >=20 > [...] >=20 > Cc: Maarten Lankhorst > Cc: Daniel Vetter > Cc: Uwe Kleine-K=F6nig > Reported-by: Uwe Kleine-K=F6nig > Fixes: f79f26921ee1 ("drm/i915: Add a cursor hack to allow converting leg= acy page flip to atomic, v3.") > Signed-off-by: Ville Syrj=E4l=E4 Is this supposed to fix https://bugs.freedesktop.org/show_bug.cgi?id=3D98742 ? If so, the Fixes: line seems wrong because f79f26921ee1 isn't in 4.9 where I see the issue. If I want to fix 4.9---my ultimate goal is to fix the kernel that will go into the next stable release---I have to cherry-pick f79f26921ee1 first, I assume? Best regards Uwe --xasor4dq5bjhuzts Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEfnIqFpAYrP8+dKQLwfwUeK3K7AkFAlinV1gACgkQwfwUeK3K 7AkTIgf+L3+5HKnOKPo9/PmVnj6waZUxf4lEtoSsSGXwDit3+XGcM5A02pCeGRH0 NHs+c7OJjArWchuU8Yg32gl3zE8RTnAWmaSurDOnhN+djvttiMnQzFUDpIX5RbCm ulyZX9u13/42bnanX43U+j6g9QK4+ZnSCADBLZPHmNtTx/+W2qFDVVA3KIkPHZaY +75dDbTLEa0RHFDxzhfzBRsnncEfwNuBFrP1jjtBqloCb1OT465bWo3IE2juZu+f uPaM6QoAjxoygz7fWnlz4a/1cC0GALWDAf0DsMg4nruadyuDLsEq+AyrVLs3mUcf XpFXXAehFBowM5bhe+hRMuYLZuXZUg== =psjw -----END PGP SIGNATURE----- --xasor4dq5bjhuzts-- --===============1882104458== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4 IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg== --===============1882104458==--