From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935032AbdBQVi6 (ORCPT ); Fri, 17 Feb 2017 16:38:58 -0500 Received: from vps0.lunn.ch ([178.209.37.122]:44081 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934415AbdBQVi5 (ORCPT ); Fri, 17 Feb 2017 16:38:57 -0500 Date: Fri, 17 Feb 2017 22:38:02 +0100 From: Andrew Lunn To: Vivien Didelot Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@savoirfairelinux.com, "David S. Miller" , Florian Fainelli Subject: Re: [PATCH net-next v2 3/6] net: dsa: mv88e6xxx: add support for 6390 ATU Move Message-ID: <20170217213802.GI6096@lunn.ch> References: <20170217150531.2181-1-vivien.didelot@savoirfairelinux.com> <20170217150531.2181-4-vivien.didelot@savoirfairelinux.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170217150531.2181-4-vivien.didelot@savoirfairelinux.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Feb 17, 2017 at 10:05:28AM -0500, Vivien Didelot wrote: > The 6390 family of Marvell chips uses 5 bits to describe the ToPort and > FromPort values of PortVec in the ATU Move operation, while older > switches use 0xf. Hi Vivien Since you say 5 bits for 6390, it would be better to say 4 bits for older switches. Otherwise: Reviewed-by: Andrew Lunn Andrew