From: Andrew Lunn <andrew@lunn.ch>
To: Pavel Belous <Pavel.Belous@aquantia.com>
Cc: "David S . Miller" <davem@davemloft.net>,
netdev@vger.kernel.org,
Simon Edelhaus <Simon.Edelhaus@aquantia.com>,
Alexey Andriyanov <Alexey.Andriyanov@aquantia.com>,
Lino Sanfilippo <LinoSanfilippo@gmx.de>
Subject: Re: [PATCH net-next v2 11/12] net: ethernet: aquantia: Fixed memory allocation if AQ_CFG_RX_FRAME_MAX > 1 page.
Date: Fri, 17 Feb 2017 23:43:53 +0100 [thread overview]
Message-ID: <20170217224353.GP6096@lunn.ch> (raw)
In-Reply-To: <c45b44987d24c7aae83c796a3731295317ae83f7.1487365317.git.pavel.belous@aquantia.com>
> diff --git a/drivers/net/ethernet/aquantia/atlantic/aq_ring.c b/drivers/net/ethernet/aquantia/atlantic/aq_ring.c
> index 4c40644..0877625 100644
> --- a/drivers/net/ethernet/aquantia/atlantic/aq_ring.c
> +++ b/drivers/net/ethernet/aquantia/atlantic/aq_ring.c
> @@ -278,6 +278,8 @@ int aq_ring_rx_fill(struct aq_ring_s *self)
> struct aq_ring_buff_s *buff = NULL;
> int err = 0;
> int i = 0;
> + unsigned int pages_order = fls(AQ_CFG_RX_FRAME_MAX / PAGE_SIZE +
> + (AQ_CFG_RX_FRAME_MAX % PAGE_SIZE ? 1 : 0)) - 1;
Reverse Christmas tree?
Andrew
next prev parent reply other threads:[~2017-02-17 23:10 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-17 21:07 [PATCH net-next v2 00/12] net: ethernet: aquantia: improvements and fixes Pavel Belous
2017-02-17 21:07 ` [PATCH net-next v2 01/12] net: ethernet: aquantia: Removed extra assignment for skb->dev Pavel Belous
2017-02-17 21:07 ` [PATCH net-next v2 02/12] net: ethernet: aquantia: Removed busy_count field Pavel Belous
2017-02-17 21:07 ` [PATCH net-next v2 03/12] net: ethernet: aquantia: Removed unnecessary comparsion "old_mtu == new_mtu" Pavel Belous
2017-02-17 22:41 ` Andrew Lunn
2017-02-17 21:07 ` [PATCH net-next v2 04/12] net: ethernet: aquantia: Using module_pci_driver Pavel Belous
2017-02-17 21:07 ` [PATCH net-next v2 05/12] net: ethernet: aquantia: Superfluous initialization of "err" Pavel Belous
2017-02-17 21:07 ` [PATCH net-next v2 06/12] net: ethernet: aquantia: Fixed missing rtnl_unlock Pavel Belous
2017-02-17 21:07 ` [PATCH net-next v2 07/12] net: ethernet: aquantia: Using NETDEV_TX_OK instead 0 Pavel Belous
2017-02-17 21:07 ` [PATCH net-next v2 08/12] net: ethernet: aquantia: Null pointer check for aq_nic_ndev_alloc Pavel Belous
2017-02-17 21:07 ` [PATCH net-next v2 09/12] net: ethernet: aquantia: Call netdev_register after all initialized Pavel Belous
2017-02-17 21:07 ` [PATCH net-next v2 10/12] net: ethernet: aquantia: Fixed incorrect buff->len calculation Pavel Belous
2017-02-17 21:07 ` [PATCH net-next v2 11/12] net: ethernet: aquantia: Fixed memory allocation if AQ_CFG_RX_FRAME_MAX > 1 page Pavel Belous
2017-02-17 22:43 ` Andrew Lunn [this message]
2017-02-18 16:33 ` Pavel Belous
2017-02-18 11:50 ` Lino Sanfilippo
2017-02-18 16:44 ` Pavel Belous
2017-02-17 21:07 ` [PATCH net-next v2 12/12] net: ethernet: aquantia: Copying tx buffers is not needed Pavel Belous
2017-02-18 11:56 ` [PATCH net-next v2 00/12] net: ethernet: aquantia: improvements and fixes Lino Sanfilippo
2017-02-18 16:42 ` Pavel Belous
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170217224353.GP6096@lunn.ch \
--to=andrew@lunn.ch \
--cc=Alexey.Andriyanov@aquantia.com \
--cc=LinoSanfilippo@gmx.de \
--cc=Pavel.Belous@aquantia.com \
--cc=Simon.Edelhaus@aquantia.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.