All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Scott Bauer <scott.bauer@intel.com>
Cc: linux-block@vger.kernel.org, axboe@fb.com, keith.busch@intel.com,
	jonathan.derrick@intel.com, hch@lst.de
Subject: Re: [PATCH] block/sed-opal: Introduce free_opal_dev to free the structure and clean up state
Date: Sat, 18 Feb 2017 17:14:57 +0100	[thread overview]
Message-ID: <20170218161457.GA17922@lst.de> (raw)
In-Reply-To: <1487352313-3539-1-git-send-email-scott.bauer@intel.com>

On Fri, Feb 17, 2017 at 10:25:13AM -0700, Scott Bauer wrote:
> Before we free the opal structure we need to clean up any saved
> locking ranges that the user had told us to unlock from a suspend.
> Also fixup a list_for_each to list_for_each_safe in the save path.
> 
> Signed-off-by: Scott Bauer <scott.bauer@intel.com>

This looks fine to me, but I think the fix to add_suspend_info
should be a separate patch:

Reviewed-by: Christoph Hellwig <hch@lst.de>

      reply	other threads:[~2017-02-18 16:15 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-17 17:25 [PATCH] block/sed-opal: Introduce free_opal_dev to free the structure and clean up state Scott Bauer
2017-02-18 16:14 ` Christoph Hellwig [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170218161457.GA17922@lst.de \
    --to=hch@lst.de \
    --cc=axboe@fb.com \
    --cc=jonathan.derrick@intel.com \
    --cc=keith.busch@intel.com \
    --cc=linux-block@vger.kernel.org \
    --cc=scott.bauer@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.