From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753700AbdBRRH2 (ORCPT ); Sat, 18 Feb 2017 12:07:28 -0500 Received: from webczatnet.pl ([91.121.100.5]:46386 "EHLO webczatnet.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753093AbdBRRHZ (ORCPT ); Sat, 18 Feb 2017 12:07:25 -0500 From: =?UTF-8?q?Micha=C5=82=20Zegan?= To: Kevin Hilman , Carlo Caione Cc: linux-kernel@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-mmc@vger.kernel.org, Ulf Hansson , =?UTF-8?q?Micha=C5=82=20Zegan?= Subject: [PATCH v2] mmc: meson-gx: remove mmc host on device removal Date: Sat, 18 Feb 2017 18:06:47 +0100 Message-Id: <20170218170647.5860-2-webczat@webczatnet.pl> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20170218170647.5860-1-webczat@webczatnet.pl> References: <20170218170647.5860-1-webczat@webczatnet.pl> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The mmc host was added in meson_mmc_probe, but never removed in meson_mmc_remove. Fix that by removing the host before deallocating other resources. Signed-off-by: Michał Zegan Tested-by: Michał Zegan --- changes since v1: rebased on top of patchset at https://patchwork.kernel.org/patch/9581057/ This is in turn based on patchset at https://patchwork.kernel.org/patch/9561215/ drivers/mmc/host/meson-gx-mmc.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/mmc/host/meson-gx-mmc.c b/drivers/mmc/host/meson-gx-mmc.c index e759e4c2e4a0..336b6a2e94c6 100644 --- a/drivers/mmc/host/meson-gx-mmc.c +++ b/drivers/mmc/host/meson-gx-mmc.c @@ -791,6 +791,8 @@ static int meson_mmc_remove(struct platform_device *pdev) { struct meson_host *host = dev_get_drvdata(&pdev->dev); + mmc_remove_host(host->mmc); + /* disable interrupts */ writel(0, host->regs + SD_EMMC_IRQ_EN); -- 2.11.0 From mboxrd@z Thu Jan 1 00:00:00 1970 From: webczat@webczatnet.pl (=?UTF-8?q?Micha=C5=82=20Zegan?=) Date: Sat, 18 Feb 2017 18:06:47 +0100 Subject: [PATCH v2] mmc: meson-gx: remove mmc host on device removal In-Reply-To: <20170218170647.5860-1-webczat@webczatnet.pl> References: <20170218170647.5860-1-webczat@webczatnet.pl> Message-ID: <20170218170647.5860-2-webczat@webczatnet.pl> To: linus-amlogic@lists.infradead.org List-Id: linus-amlogic.lists.infradead.org The mmc host was added in meson_mmc_probe, but never removed in meson_mmc_remove. Fix that by removing the host before deallocating other resources. Signed-off-by: Micha? Zegan Tested-by: Micha? Zegan --- changes since v1: rebased on top of patchset at https://patchwork.kernel.org/patch/9581057/ This is in turn based on patchset at https://patchwork.kernel.org/patch/9561215/ drivers/mmc/host/meson-gx-mmc.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/mmc/host/meson-gx-mmc.c b/drivers/mmc/host/meson-gx-mmc.c index e759e4c2e4a0..336b6a2e94c6 100644 --- a/drivers/mmc/host/meson-gx-mmc.c +++ b/drivers/mmc/host/meson-gx-mmc.c @@ -791,6 +791,8 @@ static int meson_mmc_remove(struct platform_device *pdev) { struct meson_host *host = dev_get_drvdata(&pdev->dev); + mmc_remove_host(host->mmc); + /* disable interrupts */ writel(0, host->regs + SD_EMMC_IRQ_EN); -- 2.11.0