From: David Miller <davem@davemloft.net>
To: tlfalcon@linux.vnet.ibm.com
Cc: netdev@vger.kernel.org, nfont@linux.vnet.ibm.com,
jallen@linux.vnet.ibm.com
Subject: Re: [PATCH net] ibmvnic: Make CRQ interrupt tasklet wait for all capabilities crqs
Date: Sun, 19 Feb 2017 18:12:22 -0500 (EST) [thread overview]
Message-ID: <20170219.181222.1275918068118644004.davem@davemloft.net> (raw)
In-Reply-To: <1487182680-29421-3-git-send-email-tlfalcon@linux.vnet.ibm.com>
From: Thomas Falcon <tlfalcon@linux.vnet.ibm.com>
Date: Wed, 15 Feb 2017 12:18:00 -0600
> After sending device capability queries and requests to the vNIC Server,
> an interrupt is triggered and the responses are written to the driver's
> CRQ response buffer. Since the interrupt can be triggered before all
> responses are written and visible to the partition, there is a danger
> that the interrupt handler or tasklet can terminate before all responses
> are read, resulting in a failure to initialize the device.
>
> To avoid this scenario, when capability commands are sent, we set
> a flag that will be checked in the following interrupt tasklet that
> will handle the capability responses from the server. Once all
> responses have been handled, the flag is disabled; and the tasklet
> is allowed to terminate.
>
> Signed-off-by: Thomas Falcon <tlfalcon@linux.vnet.ibm.com>
Applied.
next prev parent reply other threads:[~2017-02-19 23:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-15 18:17 [PATCH net] ibmvnic: Handle processing of CRQ messages in a tasklet Thomas Falcon
2017-02-15 18:17 ` [PATCH net] ibmvnic: Use common counter for capabilities checks Thomas Falcon
2017-02-19 23:12 ` David Miller
2017-02-15 18:18 ` [PATCH net] ibmvnic: Make CRQ interrupt tasklet wait for all capabilities crqs Thomas Falcon
2017-02-19 23:12 ` David Miller [this message]
2017-02-19 23:12 ` [PATCH net] ibmvnic: Handle processing of CRQ messages in a tasklet David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170219.181222.1275918068118644004.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=jallen@linux.vnet.ibm.com \
--cc=netdev@vger.kernel.org \
--cc=nfont@linux.vnet.ibm.com \
--cc=tlfalcon@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.