Re: [auxdisplay: ht16k33] cac513f1a9: BUG: KASAN: global-out-of-bounds in __of_match_node at addr ffffffff82ea8cf8

[Fengguang Wu <fengguang.wu@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 2876 bytes --]

Hi Dmitry,

>> cac513f1a9  auxdisplay: ht16k33: rework input device initialization
>> +--------------------------------------------------------------------+----+
>> |                                                                    |    |
>> +--------------------------------------------------------------------+----+
>> | boot_successes                                                     | 0  |
>> | boot_failures                                                      | 26 |
>> | BUG:KASAN:global-out-of-bounds_in__of_match_node_at_addr           | 26 |
>> | BUG:KASAN:global-out-of-bounds_in__of_device_is_compatible_at_addr | 26 |
>> +--------------------------------------------------------------------+----+
>>
>> [   16.004589] OF: /testcase-data/phandle-tests/consumer-a: arguments longer than property
>> [   16.008292] irq: no irq domain found for /testcase-data/interrupts/intc0 !
>> [   16.008292] irq: no irq domain found for /testcase-data/interrupts/intc0 !
>> [   16.011090] ==================================================================
>> [   16.011090] ==================================================================
>> [   16.014687] BUG: KASAN: global-out-of-bounds in __of_match_node+0xf9/0x100 at addr ffffffff82ea8cf8
>> [   16.014687] BUG: KASAN: global-out-of-bounds in __of_match_node+0xf9/0x100 at addr ffffffff82ea8cf8
>> [   16.018072] Read of size 1 by task swapper/1
>> [   16.018072] Read of size 1 by task swapper/1
>> [   16.019363] Address belongs to variable img_ascii_lcd_matches+0x258/0x8c0
>> [   16.019363] Address belongs to variable img_ascii_lcd_matches+0x258/0x8c0
>
>Hmm, I am not sure what exactly happened, but I wonder if the patch
>below does not resolve this issue.

Yes it works.

Tested-by: Fengguang Wu <fengguang.wu@intel.com>

Thanks,
Fengguang

>auxdisplay: img-ascii-lcd: add missing sentinel entry in img_ascii_lcd_matches
>
>From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
>
>The OF device table must be terminated, otherwise we'll be walking past it
>and into areas unknown.
>
>Fixes: 0cad855fbd08 ("auxdisplay: img-ascii-lcd: driver for simple ASCII...")
>Cc: stable(a)vger.kernel.org
>Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
>---
> drivers/auxdisplay/img-ascii-lcd.c |    1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/drivers/auxdisplay/img-ascii-lcd.c b/drivers/auxdisplay/img-ascii-lcd.c
>index bf43b5d2aafc..83f1439e57fd 100644
>--- a/drivers/auxdisplay/img-ascii-lcd.c
>+++ b/drivers/auxdisplay/img-ascii-lcd.c
>@@ -218,6 +218,7 @@ static const struct of_device_id img_ascii_lcd_matches[] = {
> 	{ .compatible = "img,boston-lcd", .data = &boston_config },
> 	{ .compatible = "mti,malta-lcd", .data = &malta_config },
> 	{ .compatible = "mti,sead3-lcd", .data = &sead3_config },
>+	{ /* sentinel */ }
> };
>
> /**