From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752459AbdBTJv0 (ORCPT ); Mon, 20 Feb 2017 04:51:26 -0500 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:35028 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752326AbdBTJvY (ORCPT ); Mon, 20 Feb 2017 04:51:24 -0500 Date: Mon, 20 Feb 2017 15:20:24 +0530 From: "Naveen N. Rao" To: Masami Hiramatsu Cc: Arnaldo Carvalho de Melo , Ananth N Mavinakayanahalli , Michael Ellerman , Ingo Molnar , Namhyung Kim , linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org Subject: Re: [PATCH 0/2] powerpc: kretprobe updates References: <20170217194433.0b4707bbfa1de603d13fbd30@kernel.org> <20170217204254.GH4109@kernel.org> <20170219134211.0a43dfb2534563af5b6d440d@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170219134211.0a43dfb2534563af5b6d440d@kernel.org> User-Agent: Mutt/1.6.2 (2016-07-01) X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 17022009-0052-0000-0000-0000021896A9 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17022009-0053-0000-0000-000007CF74D5 Message-Id: <20170220095024.GB12165@naverao1-tp.localdomain> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-02-20_06:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1612050000 definitions=main-1702200099 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2017/02/19 01:42PM, Masami Hiramatsu wrote: > On Fri, 17 Feb 2017 17:42:54 -0300 > Arnaldo Carvalho de Melo wrote: > > > Em Fri, Feb 17, 2017 at 07:44:33PM +0900, Masami Hiramatsu escreveu: > > > On Thu, 16 Feb 2017 13:47:37 +0530 > > > "Naveen N. Rao" wrote: > > > > > > > I am posting the powerpc bits in the same thread so as to keep these > > > > changes together. I am not sure how this should be taken upstream as > > > > there are atleast three different trees involved: one for the core > > > > kprobes infrastructure, one for powerpc and one for perf. > > > > > Hmm, could you make these (and other related) patches and > > > other series in one series? Or wait for the other series > > > are merged correctly. > > > > Well, patches like these should be done in a way that the tooling parts > > can deal with kernels with or without the kernel changes, so that older > > tools work with new kernels and new tools work with older kernels. > > > > "work" as in the previous behaviour is kept when a new tool deals with > > an older kernel and an older tool would warn the user that what it needs > > is not present in that kernel. > > > > Is this the case? I just looked briefly at the patch commit logs. > > Thanks Arnaldo, > > Naveen, I think this one and your previous series are incompatible > with older kernel. So those should be merged in one series and > at least (1) update ftrace's README special file to show explicitly > which can accept text+offset style for kretprobes, and Sure - do you mean Documentation/trace/kprobetrace.txt? And, do you want me to include kernel version where this changed? > (2) update > perf probe side to ensure that (and fallback to previous logic if not). Sure. I am trying out an approach and will post it as soon as it's ready. Thanks! - Naveen