From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752555AbdBTKV1 (ORCPT ); Mon, 20 Feb 2017 05:21:27 -0500 Received: from mx2.suse.de ([195.135.220.15]:56733 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752194AbdBTKVY (ORCPT ); Mon, 20 Feb 2017 05:21:24 -0500 Date: Mon, 20 Feb 2017 11:21:22 +0100 From: Michal Hocko To: peter enderborg Cc: devel@driverdev.osuosl.org, Greg Kroah-Hartman , linux-kernel@vger.kernel.org, Arve =?iso-8859-1?B?SGr4bm5lduVn?= , Riley Andrews , Linus Torvalds , linux-mm@kvack.org Subject: Re: [PATCH 0/3 staging-next] android: Lowmemmorykiller task tree Message-ID: <20170220102121.GF2431@dhcp22.suse.cz> References: <20170210102732.GB10054@dhcp22.suse.cz> <5579dead-092d-2ce2-a9d4-f2b50721f0dc@sonymobile.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5579dead-092d-2ce2-a9d4-f2b50721f0dc@sonymobile.com> User-Agent: Mutt/1.6.0 (2016-04-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon 13-02-17 16:42:42, peter enderborg wrote: > On 02/10/2017 11:27 AM, Michal Hocko wrote: > > [I have only now see this cover - it answers some of the questions I've > > had to specific patches. It would be really great if you could use git > > send-email to post patch series - it just does the right thing(tm)] > > > > On Thu 09-02-17 14:21:40, peter enderborg wrote: > >> Lowmemorykiller efficiency problem and a solution. > >> > >> Lowmemorykiller in android has a severe efficiency problem. The basic > >> problem is that the registered shrinker gets called very often without > >> anything actually happening. > > Which is an inherent problem because lkml doesn't belong to shrinkers > > infrastructure. > > Not really what this patch address. I see it as a problem with shrinker > that there no slow-path-free (scan/count) where it should belong. > This patch address a specific problem where lot of cpu are wasted > in low memory conditions. Let me repeat. The specific problem you are trying to solve is _inherent_ to how the lmk is designed. Full stop. -- Michal Hocko SUSE Labs From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wj0-f197.google.com (mail-wj0-f197.google.com [209.85.210.197]) by kanga.kvack.org (Postfix) with ESMTP id 3CDFC6B0389 for ; Mon, 20 Feb 2017 05:21:25 -0500 (EST) Received: by mail-wj0-f197.google.com with SMTP id le4so11881801wjb.1 for ; Mon, 20 Feb 2017 02:21:25 -0800 (PST) Received: from mx2.suse.de (mx2.suse.de. [195.135.220.15]) by mx.google.com with ESMTPS id 140si11758901wmt.40.2017.02.20.02.21.23 for (version=TLS1 cipher=AES128-SHA bits=128/128); Mon, 20 Feb 2017 02:21:23 -0800 (PST) Date: Mon, 20 Feb 2017 11:21:22 +0100 From: Michal Hocko Subject: Re: [PATCH 0/3 staging-next] android: Lowmemmorykiller task tree Message-ID: <20170220102121.GF2431@dhcp22.suse.cz> References: <20170210102732.GB10054@dhcp22.suse.cz> <5579dead-092d-2ce2-a9d4-f2b50721f0dc@sonymobile.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5579dead-092d-2ce2-a9d4-f2b50721f0dc@sonymobile.com> Sender: owner-linux-mm@kvack.org List-ID: To: peter enderborg Cc: devel@driverdev.osuosl.org, Greg Kroah-Hartman , linux-kernel@vger.kernel.org, Arve =?iso-8859-1?B?SGr4bm5lduVn?= , Riley Andrews , Linus Torvalds , linux-mm@kvack.org On Mon 13-02-17 16:42:42, peter enderborg wrote: > On 02/10/2017 11:27 AM, Michal Hocko wrote: > > [I have only now see this cover - it answers some of the questions I've > > had to specific patches. It would be really great if you could use git > > send-email to post patch series - it just does the right thing(tm)] > > > > On Thu 09-02-17 14:21:40, peter enderborg wrote: > >> Lowmemorykiller efficiency problem and a solution. > >> > >> Lowmemorykiller in android has a severe efficiency problem. The basic > >> problem is that the registered shrinker gets called very often without > >> anything actually happening. > > Which is an inherent problem because lkml doesn't belong to shrinkers > > infrastructure. > > Not really what this patch address. I see it as a problem with shrinker > that there no slow-path-free (scan/count) where it should belong. > This patch address a specific problem where lot of cpu are wasted > in low memory conditions. Let me repeat. The specific problem you are trying to solve is _inherent_ to how the lmk is designed. Full stop. -- Michal Hocko SUSE Labs -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org