From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out4-smtp.messagingengine.com ([66.111.4.28]:54504 "EHLO out4-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753720AbdBTPUX (ORCPT ); Mon, 20 Feb 2017 10:20:23 -0500 Date: Mon, 20 Feb 2017 16:19:43 +0100 From: Greg KH To: Coly Li Cc: Kent Overstreet , stable@vger.kernel.org Subject: Re: [PATCH] bcache: Make gc wakeup sane, remove set_task_state() Message-ID: <20170220151943.GA9530@kroah.com> References: <1485177612-40394-1-git-send-email-colyli@suse.de> <20170123141634.GA12980@kroah.com> <20170123145407.GA24796@kroah.com> <20170220123137.GA28408@kroah.com> <20170220131258.hb2cg5myd2erbliq@kmo-pixel> <20170220140611.GA16122@kroah.com> <9d02d389-c432-bddb-f592-018db38372c7@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <9d02d389-c432-bddb-f592-018db38372c7@suse.de> Sender: stable-owner@vger.kernel.org List-ID: On Mon, Feb 20, 2017 at 10:36:13PM +0800, Coly Li wrote: > On 2017/2/20 下午10:06, Greg KH wrote: > > On Mon, Feb 20, 2017 at 04:12:58AM -0900, Kent Overstreet wrote: > >> On Mon, Feb 20, 2017 at 01:31:37PM +0100, Greg KH wrote: > >>> On Mon, Jan 23, 2017 at 03:54:07PM +0100, Greg KH wrote: > >>>> Kent, any hints? > >>> > >>> Without a response from the maintainer, I can't apply this... > >>> > >>> greg k-h > >> > >> Sorry I missed this - yes, this patch should be safe to apply and it does fix > >> that crash. The relevant code hasn't been changed in ages, 4.4 is definitely > >> fine. > > > > Ok, I've queued this up for 4.9, but for 4.4 it does not apply. Coly, > > can you provide a working backport for 4.4-stable? > > Greg, > > It is because the 'commit 29e6c57cc78e ("bcache: bch_gc_thread() is not > freezable")' remove a "try_to_freeze()" in bch_gc_thread(), which > happens in v4.7. > > I just rebase Kent's fix to v4.4 kernel, solve the conflict. Could you > please check and try the attached patch ? That worked, thanks! greg k-h