From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751043AbdBTXde (ORCPT ); Mon, 20 Feb 2017 18:33:34 -0500 Received: from gateway23.websitewelcome.com ([192.185.50.108]:45988 "EHLO gateway23.websitewelcome.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750835AbdBTXdd (ORCPT ); Mon, 20 Feb 2017 18:33:33 -0500 Date: Mon, 20 Feb 2017 17:07:37 -0600 Message-ID: <20170220170737.Horde.oIEVDEqpxIYRbG7skEFqQXp@gator4166.hostgator.com> From: "Gustavo A. R. Silva" To: Alan Stern Cc: oneukum@suse.com, gregkh@linuxfoundation.org, linux-usb@vger.kernel.org, usb-storage@lists.one-eyed-alien.net, linux-kernel@vger.kernel.org, Peter Senna Tschudin Subject: Re: [usb-storage] [PATCH] usb: storage: add missing pre-increment to variable References: <20170215073919.GA2356@embeddedgus> In-Reply-To: User-Agent: Horde Application Framework 5 Content-Type: text/plain; charset=utf-8; format=flowed; DelSp=Yes MIME-Version: 1.0 Content-Disposition: inline X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator4166.hostgator.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - embeddedor.com X-BWhitelist: no X-Source-IP: 108.167.133.22 X-Exim-ID: 1cfx3R-0009qL-6f X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: gator4166.hostgator.com [108.167.133.22]:38832 X-Source-Auth: garsilva@embeddedor.com X-Email-Count: 2 X-Source-Cap: Z3V6aWRpbmU7Z3V6aWRpbmU7Z2F0b3I0MTY2Lmhvc3RnYXRvci5jb20= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Alan, Quoting Alan Stern : > On Wed, 15 Feb 2017, Gustavo A. R. Silva wrote: > >> Add missing pre-increment to 'waitcount' variable used in do-while loop. >> >> Addresses-Coverity-ID: 1011631 >> Signed-off-by: Gustavo A. R. Silva >> --- >> drivers/usb/storage/jumpshot.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/usb/storage/jumpshot.c b/drivers/usb/storage/jumpshot.c >> index 011e527..a26c4bb 100644 >> --- a/drivers/usb/storage/jumpshot.c >> +++ b/drivers/usb/storage/jumpshot.c >> @@ -313,7 +313,7 @@ static int jumpshot_write_data(struct us_data *us, >> // >> msleep(50); >> } >> - } while ((result != USB_STOR_TRANSPORT_GOOD) && (waitcount < 10)); >> + } while ((result != USB_STOR_TRANSPORT_GOOD) && (++waitcount < 10)); >> >> if (result != USB_STOR_TRANSPORT_GOOD) >> usb_stor_dbg(us, "Gah! Waitcount = 10. Bad write!?\n"); >> > > This has already been reported and fixed. See > > http://marc.info/?l=linux-usb&m=148604164024557&w=2 > Awesome. Thanks for the info. -- Gustavo A. R. Silva