From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752141AbdBULVG (ORCPT <rfc822;w@1wt.eu>);
        Tue, 21 Feb 2017 06:21:06 -0500
Received: from mail.skyhub.de ([78.46.96.112]:59176 "EHLO mail.skyhub.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1752101AbdBULU4 (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 21 Feb 2017 06:20:56 -0500
Date: Tue, 21 Feb 2017 12:20:28 +0100
From: Borislav Petkov <bp@alien8.de>
To: Jiri Olsa <jolsa@redhat.com>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>,
        Jiri Olsa <jolsa@kernel.org>, David Ahern <dsahern@gmail.com>,
        Namhyung Kim <namhyung@kernel.org>,
        Peter Zijlstra <a.p.zijlstra@chello.nl>,
        lkml <linux-kernel@vger.kernel.org>, Ingo Molnar <mingo@kernel.org>
Subject: Re: [PATCHv2 4/5] perf stat: Add -a as a default target
Message-ID: <20170221112028.p2bznm4dn7ktpwzz@pd.tnic>
References: <20170217170034.GB15389@krava>
 <F05C67E5-96B5-4305-992C-166D068520E4@alien8.de>
 <20170218175225.5cylpqti7oluqehv@pd.tnic>
 <20170220071300.GA12002@krava>
 <20170220134433.GI4109@kernel.org>
 <20170220203149.yxietgdzi5lxdk5n@pd.tnic>
 <20170220212254.GC4071@kernel.org>
 <20170220224716.q6r3awztsf6t3k5a@pd.tnic>
 <20170221075437.GB7384@krava>
 <20170221110451.GA16152@krava>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20170221110451.GA16152@krava>
User-Agent: NeoMutt/20170113 (1.7.2)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Feb 21, 2017 at 12:04:51PM +0100, Jiri Olsa wrote:
> could you please test this change?

LGTM, thanks!

$ ./perf stat -v -e amd_nb/event=0xe0,umask=0x1f/ sleep 1
Using CPUID AuthenticAMD-21-2
amd_nb/event=0xe0,umask=0x1f/: 249356 1002053637 1002053637

 Performance counter stats for 'system wide':

           249,356      amd_nb/event=0xe0,umask=0x1f/

       1.002080419 seconds time elapsed

$ ./perf stat -v -e amd_nb/event=0xe0,umask=0x1f/,cycles sleep 1
Using CPUID AuthenticAMD-21-2
Warning:
amd_nb/event=0xe0,umask=0x1f/ event is not supported by the kernel.
failed to read counter amd_nb/event=0xe0,umask=0x1f/
amd_nb/event=0xe0,umask=0x1f/: 0 0 0
cycles: 1223719 815034 815034

 Performance counter stats for 'sleep 1':

   <not supported>      amd_nb/event=0xe0,umask=0x1f/
         1,223,719      cycles

       1.001679931 seconds time elapsed

$ ./perf stat -v -e amd_nb/event=0xe0,umask=0x1f/,amd_nb/event=0xe1,umask=0x3/ sleep 1
Using CPUID AuthenticAMD-21-2
amd_nb/event=0xe0,umask=0x1f/: 262994 1001697720 1001697720
amd_nb/event=0xe1,umask=0x3/: 0 1001701216 1001701216

 Performance counter stats for 'system wide':

           262,994      amd_nb/event=0xe0,umask=0x1f
                 0      amd_nb/event=0xe1,umask=0x3/

       1.001718951 seconds time elapsed

$ ./perf stat -v -e amd_nb/event=0xe0,umask=0x1f/,amd_nb/event=0xe1,umask=0x3/,amd_nb/event=0xe2,umask=0x3/ sleep 1
Using CPUID AuthenticAMD-21-2
amd_nb/event=0xe0,umask=0x1f/: 203936 1001654831 1001654831
amd_nb/event=0xe1,umask=0x3/: 0 1001657636 1001657636
amd_nb/event=0xe2,umask=0x3/: 988016 1001657991 1001657991

 Performance counter stats for 'system wide':

           203,936      amd_nb/event=0xe0,umask=0x1f/
                 0      amd_nb/event=0xe1,umask=0x3/
           988,016      amd_nb/event=0xe2,umask=0x3/

       1.001681434 seconds time elapsed

$ ./perf stat -v -a -e amd_nb/event=0xe0,umask=0x1f/,amd_nb/event=0xe1,umask=0x3/,amd_nb/event=0xe2,umask=0x3/,cycles sleep 1
Using CPUID AuthenticAMD-21-2
amd_nb/event=0xe0,umask=0x1f/: 365803 1001738673 1001738673
amd_nb/event=0xe1,umask=0x3/: 0 1001736790 1001736790
amd_nb/event=0xe2,umask=0x3/: 1884159 1001731876 1001731876
cycles: 156820391 8014227609 8014227609

 Performance counter stats for 'system wide':

           365,803      amd_nb/event=0xe0,umask=0x1f/
                 0      amd_nb/event=0xe1,umask=0x3/
         1,884,159      amd_nb/event=0xe2,umask=0x3/
       156,820,391      cycles

       1.001963906 seconds time elapsed

-- 
Regards/Gruss,
    Boris.

Good mailing practices for 400: avoid top-posting and trim the reply.