From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753281AbdBUOku (ORCPT ); Tue, 21 Feb 2017 09:40:50 -0500 Received: from nblzone-211-213.nblnetworks.fi ([83.145.211.213]:56934 "EHLO hillosipuli.retiisi.org.uk" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752763AbdBUOkn (ORCPT ); Tue, 21 Feb 2017 09:40:43 -0500 Date: Tue, 21 Feb 2017 16:40:34 +0200 From: Sakari Ailus To: Ramiro Oliveira Cc: linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, devicetree@vger.kernel.org, vladimir_zapolskiy@mentor.com, CARLOS.PALMINHA@synopsys.com, Arnd Bergmann , "David S. Miller" , Geert Uytterhoeven , Greg Kroah-Hartman , Guenter Roeck , Hans Verkuil , Lars-Peter Clausen , Mark Rutland , Mauro Carvalho Chehab , Pali =?iso-8859-1?Q?Roh=E1r?= , Pavel Machek , Robert Jarzmik , Rob Herring , Sakari Ailus , Steve Longerbeam Subject: Re: [PATCH v9 1/2] Add OV5647 device tree documentation Message-ID: <20170221144034.GJ16975@valkosipuli.retiisi.org.uk> References: <5a93352142495528dd56d5e281a8ed8ad6404a05.1487334912.git.roliveir@synopsys.com> <20170221115746.GF16975@valkosipuli.retiisi.org.uk> <3d0b775a-e1de-d957-de72-7751e2c59aea@synopsys.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3d0b775a-e1de-d957-de72-7751e2c59aea@synopsys.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Ramiro, On Tue, Feb 21, 2017 at 02:30:16PM +0000, Ramiro Oliveira wrote: > Hi Sakari, > > Thank you for your feedback. > > On 2/21/2017 11:57 AM, Sakari Ailus wrote: > > Hi Ramiro, > > > > On Fri, Feb 17, 2017 at 01:14:15PM +0000, Ramiro Oliveira wrote: > >> Create device tree bindings documentation. > >> > >> Signed-off-by: Ramiro Oliveira > >> Acked-by: Rob Herring > >> --- > >> .../devicetree/bindings/media/i2c/ov5647.txt | 35 ++++++++++++++++++++++ > >> 1 file changed, 35 insertions(+) > >> create mode 100644 Documentation/devicetree/bindings/media/i2c/ov5647.txt > >> > >> diff --git a/Documentation/devicetree/bindings/media/i2c/ov5647.txt b/Documentation/devicetree/bindings/media/i2c/ov5647.txt > >> new file mode 100644 > >> index 000000000000..31956426d3b9 > >> --- /dev/null > >> +++ b/Documentation/devicetree/bindings/media/i2c/ov5647.txt > >> @@ -0,0 +1,35 @@ > >> +Omnivision OV5647 raw image sensor > >> +--------------------------------- > >> + > >> +OV5647 is a raw image sensor with MIPI CSI-2 and CCP2 image data interfaces > >> +and CCI (I2C compatible) control bus. > >> + > >> +Required properties: > >> + > >> +- compatible : "ovti,ov5647". > >> +- reg : I2C slave address of the sensor. > >> +- clocks : Reference to the xclk clock. > >> +- clock-names : Should be "xclk". > >> +- clock-frequency : Frequency of the xclk clock. > >> + > >> +The common video interfaces bindings (see video-interfaces.txt) should be > >> +used to specify link to the image data receiver. The OV5647 device > >> +node should contain one 'port' child node with an 'endpoint' subnode. > > > > The remote-endpoint property in endpoint nodes should be mandatory, > > shouldn't it? Otherwise the sensor isn't connected to anything and hardly > > useful as such. The list of optional endpoint properties is a long one and > > it should be documented here which ones are recognised, either as optional > > or mandatory. > > > > I guess you're right, it should be mandatory, although at the moment I'm not > checking for it's presence in the driver so I'll add it to the driver. > > At the moment that's the only property I think it should be mandatory, and I > don't believe I need any optional one. > > Do you have a suggestion for any new property I should use? As you don't need any in the driver for the driver to work, you can omit them. -- Regards, Sakari Ailus e-mail: sakari.ailus@iki.fi XMPP: sailus@retiisi.org.uk From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sakari Ailus Subject: Re: [PATCH v9 1/2] Add OV5647 device tree documentation Date: Tue, 21 Feb 2017 16:40:34 +0200 Message-ID: <20170221144034.GJ16975@valkosipuli.retiisi.org.uk> References: <5a93352142495528dd56d5e281a8ed8ad6404a05.1487334912.git.roliveir@synopsys.com> <20170221115746.GF16975@valkosipuli.retiisi.org.uk> <3d0b775a-e1de-d957-de72-7751e2c59aea@synopsys.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <3d0b775a-e1de-d957-de72-7751e2c59aea-HKixBCOQz3hWk0Htik3J/w@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Ramiro Oliveira Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-media-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, vladimir_zapolskiy-nmGgyN9QBj3QT0dZR+AlfA@public.gmane.org, CARLOS.PALMINHA-HKixBCOQz3hWk0Htik3J/w@public.gmane.org, Arnd Bergmann , "David S. Miller" , Geert Uytterhoeven , Greg Kroah-Hartman , Guenter Roeck , Hans Verkuil , Lars-Peter Clausen , Mark Rutland , Mauro Carvalho Chehab , Pali =?iso-8859-1?Q?Roh=E1r?= , Pavel Machek , Robert Jarzmik , Rob Herring , Sakari Ailus , Steve Longerbeam List-Id: devicetree@vger.kernel.org Hi Ramiro, On Tue, Feb 21, 2017 at 02:30:16PM +0000, Ramiro Oliveira wrote: > Hi Sakari, > > Thank you for your feedback. > > On 2/21/2017 11:57 AM, Sakari Ailus wrote: > > Hi Ramiro, > > > > On Fri, Feb 17, 2017 at 01:14:15PM +0000, Ramiro Oliveira wrote: > >> Create device tree bindings documentation. > >> > >> Signed-off-by: Ramiro Oliveira > >> Acked-by: Rob Herring > >> --- > >> .../devicetree/bindings/media/i2c/ov5647.txt | 35 ++++++++++++++++++++++ > >> 1 file changed, 35 insertions(+) > >> create mode 100644 Documentation/devicetree/bindings/media/i2c/ov5647.txt > >> > >> diff --git a/Documentation/devicetree/bindings/media/i2c/ov5647.txt b/Documentation/devicetree/bindings/media/i2c/ov5647.txt > >> new file mode 100644 > >> index 000000000000..31956426d3b9 > >> --- /dev/null > >> +++ b/Documentation/devicetree/bindings/media/i2c/ov5647.txt > >> @@ -0,0 +1,35 @@ > >> +Omnivision OV5647 raw image sensor > >> +--------------------------------- > >> + > >> +OV5647 is a raw image sensor with MIPI CSI-2 and CCP2 image data interfaces > >> +and CCI (I2C compatible) control bus. > >> + > >> +Required properties: > >> + > >> +- compatible : "ovti,ov5647". > >> +- reg : I2C slave address of the sensor. > >> +- clocks : Reference to the xclk clock. > >> +- clock-names : Should be "xclk". > >> +- clock-frequency : Frequency of the xclk clock. > >> + > >> +The common video interfaces bindings (see video-interfaces.txt) should be > >> +used to specify link to the image data receiver. The OV5647 device > >> +node should contain one 'port' child node with an 'endpoint' subnode. > > > > The remote-endpoint property in endpoint nodes should be mandatory, > > shouldn't it? Otherwise the sensor isn't connected to anything and hardly > > useful as such. The list of optional endpoint properties is a long one and > > it should be documented here which ones are recognised, either as optional > > or mandatory. > > > > I guess you're right, it should be mandatory, although at the moment I'm not > checking for it's presence in the driver so I'll add it to the driver. > > At the moment that's the only property I think it should be mandatory, and I > don't believe I need any optional one. > > Do you have a suggestion for any new property I should use? As you don't need any in the driver for the driver to work, you can omit them. -- Regards, Sakari Ailus e-mail: sakari.ailus-X3B1VOXEql0@public.gmane.org XMPP: sailus-PCDdDYkjdNMDXYZnReoRVg@public.gmane.org -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html