From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753780AbdBUQaA (ORCPT ); Tue, 21 Feb 2017 11:30:00 -0500 Received: from vps0.lunn.ch ([178.209.37.122]:47245 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751904AbdBUQ3x (ORCPT ); Tue, 21 Feb 2017 11:29:53 -0500 Date: Tue, 21 Feb 2017 17:29:48 +0100 From: Andrew Lunn To: Enric Balletbo i Serra Cc: Peter Huewe , Marcel Selhorst , apronin@google.com, tpmdd-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, Bryan Freed Subject: Re: [tpmdd-devel] [PATCH 1/2] tpm: Apply an adapterlimit for retransmission. Message-ID: <20170221162948.GD25818@lunn.ch> References: <20170221144500.502-1-enric.balletbo@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170221144500.502-1-enric.balletbo@collabora.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Feb 21, 2017 at 03:44:59PM +0100, Enric Balletbo i Serra wrote: > From: Bryan Freed > > When the I2C Infineon part is attached to an I2C adapter that imposes > a size limitation, large requests will fail -EINVAL. > Retry them with size backoff without re-issuing the 0x05 command > as this appears to occasionally put the TPM in a bad state. Hi Enric Rather than trying small and smaller transfers, would it not be better to get the i2c core to expose the quirk info about transfer limits? Andrew