From: Jan Kara <jack@suse.cz>
To: Omar Sandoval <osandov@osandov.com>
Cc: James Bottomley <James.Bottomley@HansenPartnership.com>,
Dan Williams <dan.j.williams@intel.com>, Jan Kara <jack@suse.cz>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Jens Axboe <axboe@fb.com>,
linux-scsi@vger.kernel.org, linux-block@vger.kernel.org
Subject: Re: Manual driver binding and unbinding broken for SCSI
Date: Tue, 21 Feb 2017 18:14:41 +0100 [thread overview]
Message-ID: <20170221171441.GA15875@quack2.suse.cz> (raw)
In-Reply-To: <20170220021958.GA26238@vader>
On Sun 19-02-17 18:19:58, Omar Sandoval wrote:
> On Fri, Feb 17, 2017 at 04:43:56PM -0800, James Bottomley wrote:
> > This seems to be related to a 0day test we got on the block tree,
> > details here:
> >
> > http://marc.info/?t=148624068800001
> >
> > I root caused the above to something not being released when it should
> > be, so it looks like you have the same problem. It seems to be a
> > recent commit in the block tree, so could you bisect it since you have
> > a nice reproducer?
>
> These appear to actually be two separate issues.
>
> The unbind followed by bind crash only happens with scsi-mq. It reproes
> since at least 4.0.
>
> The unbind followed by a new device coming up crash happens both with
> and without scsi-mq. The earliest version I was able to check for that
> was 4.6, which did reproduce.
>
> I'll see if I can get some more info on these two issues separately.
Actually, the second issue is only a warning right? And if I understand the
issue correctly, it should be fixed by either Dan's patches in linux-block
or my patch 4 in the series which matches your test results. So that is
dealt with. I have no idea about the first issue though.
Honza
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
next prev parent reply other threads:[~2017-02-21 17:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-18 0:30 Manual driver binding and unbinding broken for SCSI Omar Sandoval
2017-02-18 0:43 ` James Bottomley
2017-02-20 2:19 ` Omar Sandoval
2017-02-21 17:14 ` Jan Kara [this message]
2017-02-22 10:21 ` Ming Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170221171441.GA15875@quack2.suse.cz \
--to=jack@suse.cz \
--cc=James.Bottomley@HansenPartnership.com \
--cc=axboe@fb.com \
--cc=dan.j.williams@intel.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=osandov@osandov.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.