From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] Bug in "package: add generic support for lz archives" ?
Date: Tue, 21 Feb 2017 22:55:09 +0100 [thread overview]
Message-ID: <20170221225509.28773ef3@free-electrons.com> (raw)
In-Reply-To: <1e78e6f82883e4ba95766459a39cbd2d49934152.1486930542.git.baruch@tkos.co.il>
Hello,
On Sun, 12 Feb 2017 22:15:39 +0200, Baruch Siach wrote:
> This commit teaches the generic package handling code how to extract .tar.lz
> archives. When lzip is not installed on the host, host-lzip gets built
> automatically.
>
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
This patch causes a regression: it seems to build host-lzip
unconditionally on systems that lack it, even if host-lzip is not
needed at all to uncompress some tarballs.
Take for example:
BR2_x86_64=y
BR2_x86_atom=y
BR2_TOOLCHAIN_EXTERNAL=y
BR2_TOOLCHAIN_EXTERNAL_CUSTOM=y
BR2_TOOLCHAIN_EXTERNAL_DOWNLOAD=y
BR2_TOOLCHAIN_EXTERNAL_URL="http://autobuild.buildroot.org/toolchains/tarballs/br-x86-64-musl-2017.02-rc1-2-g133c5ac.tar.bz2"
BR2_TOOLCHAIN_EXTERNAL_GCC_5=y
BR2_TOOLCHAIN_EXTERNAL_HEADERS_4_9=y
BR2_TOOLCHAIN_EXTERNAL_CUSTOM_MUSL=y
BR2_TOOLCHAIN_EXTERNAL_CXX=y
BR2_INIT_NONE=y
BR2_SYSTEM_BIN_SH_NONE=y
# BR2_PACKAGE_BUSYBOX is not set
BR2_PACKAGE_TCL=y
BR2_PACKAGE_EXPECT=y
# BR2_TARGET_ROOTFS_TAR is not set
Nothing is .lz compressed in there, and still, it builds host-lzip at
the beginning of the build:
>>> host-lzip 1.18 Extracting
>>> host-lzip 1.18 Patching
>>> host-lzip 1.18 Configuring
>>> host-lzip 1.18 Building
>>> host-lzip 1.18 Installing to host directory
>>> skeleton Extracting
>>> skeleton Patching
>>> skeleton Configuring
>>> skeleton Building
>>> skeleton Installing to staging directory
>>> skeleton Fixing libtool files
>>> skeleton Installing to target
Could you have a look ?
Thanks,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
next prev parent reply other threads:[~2017-02-21 21:55 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-12 20:15 [Buildroot] [PATCH v3 1/5] package: refactor listing of extractor dependencies Baruch Siach
2017-02-12 20:15 ` [Buildroot] [PATCH v3 2/5] package: add generic support for lz archives Baruch Siach
2017-02-14 13:43 ` Thomas De Schampheleire
2017-02-15 21:15 ` Thomas Petazzoni
2017-02-15 22:48 ` Arnout Vandecappelle
2017-02-16 7:32 ` Thomas Petazzoni
2017-02-16 8:25 ` Arnout Vandecappelle
2017-02-16 8:34 ` Thomas Petazzoni
2017-02-16 17:24 ` Arnout Vandecappelle
2017-02-16 17:41 ` Yann E. MORIN
2017-02-16 22:03 ` Peter Korsgaard
2017-02-16 22:11 ` Yann E. MORIN
2017-02-17 7:43 ` Arnout Vandecappelle
2017-02-17 17:07 ` Yann E. MORIN
2017-02-16 22:08 ` Peter Korsgaard
2017-02-16 8:36 ` Thomas De Schampheleire
2017-02-16 8:40 ` Thomas Petazzoni
2017-02-16 10:24 ` Thomas De Schampheleire
2017-02-21 21:55 ` Thomas Petazzoni [this message]
2017-02-22 5:32 ` [Buildroot] Bug in "package: add generic support for lz archives" ? Baruch Siach
2017-02-22 8:03 ` Thomas Petazzoni
2017-02-12 20:15 ` [Buildroot] [PATCH v3 3/5] ed: use generic extract command Baruch Siach
2017-02-12 20:15 ` [Buildroot] [PATCH v3 4/5] ddrescue: " Baruch Siach
2017-02-12 20:15 ` [Buildroot] [PATCH v3 5/5] ocrad: " Baruch Siach
2017-02-14 13:42 ` [Buildroot] [PATCH v3 1/5] package: refactor listing of extractor dependencies Thomas De Schampheleire
2017-02-14 21:39 ` Thomas Petazzoni
2017-02-15 7:04 ` Baruch Siach
2017-02-15 21:13 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170221225509.28773ef3@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.