From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752818AbdBUXCB (ORCPT <rfc822;w@1wt.eu>);
        Tue, 21 Feb 2017 18:02:01 -0500
Received: from out4-smtp.messagingengine.com ([66.111.4.28]:54846 "EHLO
        out4-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK)
        by vger.kernel.org with ESMTP id S1751754AbdBUXBx (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 21 Feb 2017 18:01:53 -0500
X-ME-Sender: <xms:4MasWJs9gM17HfPqBjjzvR_7vcVK_BkkiMWaH1XM8DBJLw0qvl0DbQ>
X-Sasl-enc: oGu3L4OktOmkbldzyTrMKl1V6QtGlY3QEC0k94LwqOoV 1487718111
Date: Wed, 22 Feb 2017 10:01:48 +1100
From: "Tobin C. Harding" <me@tobin.cc>
To: Andy Whitcroft <apw@canonical.com>, Joe Perches <joe@perches.com>
Cc: linux-kernel@vger.kernel.org
Subject: checkpatch suspected false positive
Message-ID: <20170221230148.GA25711@eros>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
X-Mailer: Mutt 1.5.24 (2015-08-30)
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Checkpatch may be giving a false positive of type CONST_STRUCT when
parsing files in drivers/staging/comedi/drivers.

$ pwd
build/kernel/linux-trees/gregKH/staging/

$ cd drivers/staging/comedi/drivers

$ checkpatch --terse --show-types *.c | grep CONST_STRUCT
addi_apci_3501.c:97: WARNING:CONST_STRUCT: struct comedi_lrange should normally be const
das16.c:972: WARNING:CONST_STRUCT: struct comedi_lrange should normally be const
das16.c:1006: WARNING:CONST_STRUCT: struct comedi_lrange should normally be const
jr3_pci.c:659: WARNING:CONST_STRUCT: struct comedi_lrange should normally be const
jr3_pci.c:667: WARNING:CONST_STRUCT: struct comedi_lrange should normally be const
jr3_pci.c:668: WARNING:CONST_STRUCT: struct comedi_lrange should normally be const
ni_670x.c:212: WARNING:CONST_STRUCT: struct comedi_lrange should normally be const

snippet from das16.c

/* get any user-defined input range */
if (pg_type == das16_pg_none && (min || max)) {
	struct comedi_lrange *lrange;
	struct comedi_krange *krange;

	/* allocate single-range range table */
	lrange = comedi_alloc_spriv(s, sizeof(*lrange) + sizeof(*krange));
	if (!lrange)
		return &range_unknown;

	/* initialize ai range */
	lrange->length = 1;
	krange = lrange->range;
	krange->min = min;
	krange->max = max;
	krange->flags = UNIT_volt;

	return lrange;
}

>>From snippet it may be seen that struct comedi_lrange *lrange should
not be const.

In the event that I am in the wrong and checkpatch is correct please
feel free to bluntly correct me.

thanks,
Tobin.